chrome_elf DrMemory test failures |
|||||
Issue descriptionSuspect https://codereview.chromium.org/2053953002/, but cannot revert due to patch failures. First failing build: https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%29/builds/5092 Sample error: ELFImportsTest.ChromeElfSanityCheck: c:\b\build\slave\drm-cr\build\src\chrome_elf\elf_imports_unittest.cc(107): error: Value of: match Actual: false Expected: true Illegal import in chrome_elf.dll: base.dll
,
Jun 20 2016
I was looking into reverting this CL as well. Note that this also causes failures on the win-asan builder, with unresolved external symbols in chrome_elf.dll: base.lib(base.win_util.obj) : error LNK2001: unresolved external symbol __imp__SystemParametersInfoW@16 base.lib(base.win_util.obj) : error LNK2001: unresolved external symbol __imp__SetPropW@12 base.lib(base.win_util.obj) : error LNK2001: unresolved external symbol __imp__GetForegroundWindow@0 base.lib(base.win_util.obj) : error LNK2001: unresolved external symbol __imp__GetSystemMetrics@4 base.lib(base.win_util.obj) : error LNK2001: unresolved external symbol __imp__RemovePropW@8 I'm guessing this is caused by Crashpad when SyzyASAN is enabled. Note that this has been blocking the win-asan build since Thursday.
,
Jun 20 2016
I tried to revert but it had a patch failure, and I don't have the bandwidth to manually revert.
,
Jun 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f546a78ac6eb865d418defe38cf70c1f0e3988c0 commit f546a78ac6eb865d418defe38cf70c1f0e3988c0 Author: chrisha <chrisha@chromium.org> Date: Mon Jun 20 15:39:25 2016 Remove Crashpad from chrome_elf sources. This fixes the win-asan build, which has been offline since https://crrev.com/f265187bf390845c6d353fa7c4a9a72575fd86dd This is a partial revert of https://codereview.chromium.org/2053953002/ TBR=caitkp@chromium.org BUG= 621460 Review-Url: https://codereview.chromium.org/2081713002 Cr-Commit-Position: refs/heads/master@{#400685} [modify] https://crrev.com/f546a78ac6eb865d418defe38cf70c1f0e3988c0/chrome_elf/BUILD.gn [modify] https://crrev.com/f546a78ac6eb865d418defe38cf70c1f0e3988c0/chrome_elf/DEPS [modify] https://crrev.com/f546a78ac6eb865d418defe38cf70c1f0e3988c0/chrome_elf/chrome_elf.gyp
,
Jun 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da08ee9bac6bf43aa2c8e0f08143abd9b87e73d8 commit da08ee9bac6bf43aa2c8e0f08143abd9b87e73d8 Author: Chris Hamilton <chrisha@chromium.org> Date: Mon Jun 20 19:49:32 2016 Remove Crashpad from chrome_elf sources. This fixes the win-asan build, which has been offline since https://crrev.com/f265187bf390845c6d353fa7c4a9a72575fd86dd This is a partial revert of https://codereview.chromium.org/2053953002/ TBR=caitkp@chromium.org BUG= 621460 Review-Url: https://codereview.chromium.org/2081713002 Cr-Commit-Position: refs/heads/master@{#400685} (cherry picked from commit f546a78ac6eb865d418defe38cf70c1f0e3988c0) Review URL: https://codereview.chromium.org/2081663003 . Cr-Commit-Position: refs/branch-heads/2773@{#2} Cr-Branched-From: ced2fcee2c85702055d028f4e3e48c5a75a7e41c-refs/heads/master@{#400610} [modify] https://crrev.com/da08ee9bac6bf43aa2c8e0f08143abd9b87e73d8/chrome_elf/BUILD.gn [modify] https://crrev.com/da08ee9bac6bf43aa2c8e0f08143abd9b87e73d8/chrome_elf/DEPS [modify] https://crrev.com/da08ee9bac6bf43aa2c8e0f08143abd9b87e73d8/chrome_elf/chrome_elf.gyp
,
Jun 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e10c4579e9e096bd9af5174315c36ffcb9ab7af3 commit e10c4579e9e096bd9af5174315c36ffcb9ab7af3 Author: ananta <ananta@chromium.org> Date: Mon Jun 20 23:49:47 2016 Remove dependency on base/win/win_util.cc from crashpad. Fixing the official ASAN builder which fails when chrome_crash_reporter_client_win.cc is compiled with chrome_elf.dll Crashpad is now included as part of chrome_elf and hence it cannot depend on functionality in base or elsewhere which pulls in user32 The ElfImportsTest.ChromeElfSanityCheck is disabled for component builds to fix Dr Memory issues. This reverts commit f546a78ac6eb865d418defe38cf70c1f0e3988c0. BUG= 621460 TBR=robertshield Review-Url: https://codereview.chromium.org/2077323004 Cr-Commit-Position: refs/heads/master@{#400839} [modify] https://crrev.com/e10c4579e9e096bd9af5174315c36ffcb9ab7af3/chrome_elf/BUILD.gn [modify] https://crrev.com/e10c4579e9e096bd9af5174315c36ffcb9ab7af3/chrome_elf/DEPS [modify] https://crrev.com/e10c4579e9e096bd9af5174315c36ffcb9ab7af3/chrome_elf/chrome_elf.gyp [modify] https://crrev.com/e10c4579e9e096bd9af5174315c36ffcb9ab7af3/chrome_elf/elf_imports_unittest.cc [modify] https://crrev.com/e10c4579e9e096bd9af5174315c36ffcb9ab7af3/components/crash/content/app/crashpad.cc
,
Sep 22 2016
I think this ticket might be good to close down now Ananta?! Feel free to re-open if you're not done with this. I've removed the chrome_elf drmemory blacklist in another CL: https://codereview.chromium.org/2355933002/ Ben, feel free to re-open (or better, open a new ticket) if we see the same failures again on this dr. bot.
,
Sep 22 2016
,
Sep 22 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Jun 20 2016