Issue metadata
Sign in to add a comment
|
Regression: Unnecessary 'Not valid' warning message is seen after clicking on 'Search engine' field at chrome://md-settings.
Reported by
jshan...@etouch.net,
Jun 20 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 53.0.2773.0 (Official Build) ced2fcee2c85702055d028f4e3e48c5a75a7e41c-refs/heads/master@{#400610}-32/64 bit OS: Windows(7,8,10), Mac (10.10.5)(10.11.4), Linux(Ubuntu 14.04 LTS) Steps: 1. Launch Chrome and navigate to chrome://md-settings/searchEngines 2. Click on 'Add search engine', then click on 'Search engine' field and observe. Actual: Unnecessary 'Not valid' warning message is seen after clicking on 'Search engine' field. Expected: No such warning message should be seen after clicking on 'Search engine' field. This is a regression issue broken in M-50, below is bisect info. Good build: 50.0.2654.0 Bad build: 50.0.2656.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/5a26b0e1b191fd26cea7c9776f478cc65bbb9781..006a19483ec7c5bfdd32b4be322745290dd4bd8f?pretty=fuller&n=100 Suspecting: r376362 ? Please help to re-assign if your change is not the cause for this issue.
,
Sep 22 2016
,
Sep 22 2016
,
Sep 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/033d1f2ef2f8e4124eca1c7de9db5a42e58c4601 commit 033d1f2ef2f8e4124eca1c7de9db5a42e58c4601 Author: dpapad <dpapad@chromium.org> Date: Fri Sep 23 18:25:49 2016 MD Settings: Search engine dialog, tweak logic to show "input invalid". Before, validation was triggered on focus, which ended up showing the "invalid" message before the user had any chance to type anything. Now validation is only triggered on input, which is less annoying to the user. BUG= 621456 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2366783002 Cr-Commit-Position: refs/heads/master@{#420670} [modify] https://crrev.com/033d1f2ef2f8e4124eca1c7de9db5a42e58c4601/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html [modify] https://crrev.com/033d1f2ef2f8e4124eca1c7de9db5a42e58c4601/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js [modify] https://crrev.com/033d1f2ef2f8e4124eca1c7de9db5a42e58c4601/chrome/test/data/webui/settings/search_engines_page_test.js
,
Sep 23 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sheriffbot@chromium.org
, Jul 4 2016