New issue
Advanced search Search tips

Issue 621442 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove client-side form classifier when server-side classifier is ready.

Project Member Reported by kolos@chromium.org, Jun 20 2016

Issue description

Client side classifier needs to collect some statistics and compare them with server-side outcomes. 

When the server-side classifier is ready, remove the form classifier from Chrome.
 

Comment 1 by vabr@chromium.org, Jun 21 2016

Labels: tracking_work

Comment 2 by vabr@chromium.org, May 2 2017

Labels: -tracking_work Type-Task

Comment 3 by kolos@chromium.org, Jun 19 2017

Labels: Hotlist-GoodFirstBug
The client side classifier could be removed.

The CL that should be "reverted": https://codereview.chromium.org/1883183002
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 19 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: kolos@chromium.org
Status: Assigned (was: Untriaged)
Is it fixed?

Comment 6 Deleted

nope, the generation is not launched completely. there is a chance that we need the data from the client side classifier. 
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9451b87d7edf04f0e830eede5126f754e123e9c1

commit 9451b87d7edf04f0e830eede5126f754e123e9c1
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Mon Jul 30 19:03:55 2018

Remove client-side password generation form classifier.

This classifier is superseded by server-side classifiers. Since
the generation logic in the renderer process is going to be refactored
and simplified, that the good time to remove it.

Bug: 866444,  621442 
Change-Id: I813d53fda594956813fc8cd83567712e34331cfb
Reviewed-on: https://chromium-review.googlesource.com/1146724
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579109}
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/chrome/renderer/autofill/fake_mojo_password_manager_driver.cc
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/chrome/renderer/autofill/fake_mojo_password_manager_driver.h
[delete] https://crrev.com/7732d4d0afcd71f550e351bbc368d49f12aa1f72/chrome/renderer/autofill/form_classifier_browsertest.cc
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/chrome/renderer/autofill/password_generation_agent_browsertest.cc
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/chrome/test/BUILD.gn
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/autofill/content/common/autofill_agent.mojom
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/autofill/content/common/autofill_driver.mojom
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/autofill/content/renderer/BUILD.gn
[delete] https://crrev.com/7732d4d0afcd71f550e351bbc368d49f12aa1f72/components/autofill/content/renderer/form_classifier.cc
[delete] https://crrev.com/7732d4d0afcd71f550e351bbc368d49f12aa1f72/components/autofill/content/renderer/form_classifier.h
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/autofill/content/renderer/password_generation_agent.cc
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/autofill/content/renderer/password_generation_agent.h
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/autofill/core/browser/autofill_field.cc
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/autofill/core/browser/autofill_field.h
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/autofill/core/browser/form_structure_unittest.cc
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/autofill/core/browser/proto/server.proto
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/password_manager/content/browser/content_password_manager_driver.cc
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/password_manager/content/browser/content_password_manager_driver.h
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/password_manager/core/browser/browser_save_password_progress_logger.cc
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/password_manager/core/browser/password_generation_manager.cc
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/password_manager/core/browser/password_generation_manager.h
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/password_manager/core/browser/password_generation_manager_unittest.cc
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/password_manager/core/browser/password_manager.h
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/password_manager/core/browser/password_manager_driver.h
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/password_manager/core/browser/vote_uploads_test_matchers.h
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/password_manager/core/browser/votes_uploader.cc
[modify] https://crrev.com/9451b87d7edf04f0e830eede5126f754e123e9c1/components/password_manager/core/browser/votes_uploader.h

Status: Fixed (was: Assigned)

Sign in to add a comment