New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 621429 link

Starred by 1 user
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Jun 2016
Cc:
tommycli@chromium.org
nyerramilli@chromium.org
dbeam@chromium.org
█ tkonch...@chromium.org
michae...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression:Double quote is seen on 'Disconnect your google account' message on sign out.

Reported by adha...@etouch.net, Jun 20 2016 
Chrome Version:53.0.2773.0 (Official Build) ced2fcee2c85702055d028f4e3e48c5a75a7e41c-refs/heads/master@{#400610} 32/64-bit.
OS:Windows(7,8,10), Mac (10.10.5)(10.11.4), Linux(Ubuntu 14.04 LTS) 

Steps:
1.Launch chrome,navigate to above chrome://md-settings.
2.Sign in to chrome with valid credentials,Click on sign out and observe the overlay.

Actual: Double quote is seen on 'Disconnect your google account' message i.e (after Google Dashboard link) on sign out. 
Expected: Double quote should not be seen on 'Disconnect your google account message'i.e (after Google Dashboard link) on sign out.

This is a regression issue, broken in M-52 series,will soon update other info.

Comment 1 by adha...@etouch.net, Jun 20 2016

Cc: dschuyler@chromium.org michae...@chromium.org
Labels: hasbisect
Owner: dbeam@chromium.org
Status: Assigned (was: Unconfirmed)
Builds between 52.0.2730.0 to 52.0.2733.0 are crashing on sign in hence providing Manual Regression range mentioned below:
Good build: 52.0.2729.0 
Bad build: 52.0.2734.0 

CL:
https://chromium.googlesource.com/chromium/src/+log/52.0.2729.0..52.0.2734.0?pretty=fuller&n=10000
(Unable to narrow down range since not able to sign in into chromium builds.)

Suspecting: r392839?, r393104 or 392788?
Please re-assign if your change is not cause of this issue.
Expected_Result.png
157 KB View Download
Actual_Result.png
141 KB View Download

Comment 2 by tkonch...@chromium.org, Jun 20 2016

Labels: ReleaseBlock-Stable
Adding RB label as this is a recent regression

Comment 3 by dbeam@chromium.org, Jun 20 2016

Cc: -dschuyler@chromium.org tommycli@chromium.org dbeam@chromium.org
Owner: dschuyler@chromium.org
https://codereview.chromium.org/1966093005/#msg11

Comment 4 by dschuyler@chromium.org, Jun 20 2016

Labels: -Pri-1 Pri-2
Owner: tommycli@chromium.org

Comment 5 by dbeam@chromium.org, Jun 21 2016

Owner: dbeam@chromium.org
Status: Started (was: Assigned)

Comment 6 by dbeam@chromium.org, Jun 21 2016

Labels: -Pri-2 -M-52 -ReleaseBlock-Stable Pri-3
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/448f1a611665ac32d8521e4b5e4252159a4a6afe

commit 448f1a611665ac32d8521e4b5e4252159a4a6afe
Author: dbeam <dbeam@chromium.org>
Date: Tue Jun 21 00:28:12 2016

MD Settings: remove accidentally left " from sync disconnect dialog

TBR=dschuyler@chromium.org
BUG= 621429 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
NOTRY=true

Review-Url: https://codereview.chromium.org/2089543002
Cr-Commit-Position: refs/heads/master@{#400851}

[modify] https://crrev.com/448f1a611665ac32d8521e4b5e4252159a4a6afe/chrome/browser/resources/settings/people_page/people_page.html

Comment 8 by dbeam@chromium.org, Jun 21 2016

Status: Fixed (was: Started)
►

Sign in to add a comment