New issue
Advanced search Search tips

Issue 621422 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Crash in cc::TileManager::OnRasterTaskCompleted

Project Member Reported by ClusterFuzz, Jun 20 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5797896536719360

Fuzzer: inferno_twister
Job Type: linux_asan_chrome_media
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000000
Crash State:
  cc::TileManager::OnRasterTaskCompleted
  cc::RasterTaskImpl::OnTaskCompleted
  cc::TileTaskManagerImpl::CheckForCompletedTasks
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_media&range=399951:400002

Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv96S0W2AEuik_Bt0pBhqO-VVl4EDk44Lg8kVFiFZ5Do7yyJJH9Q9TXu3ot2vg3QrRX3irwZC210fruId5lY3OiKdnuQuWfyq9AALlswyS5BI_mQIZHNNUUZBoPCpGd4QeBQZXyONYBGlMKx86dQIILB3jL-jO8DUKjetQbPgfoCQl__mjv8?testcase_id=5797896536719360


Filer: msrchandra

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Labels: findit-for-crash Te-Logged
Owner: sunn...@chromium.org
Status: Assigned (was: Available)
Suspected CLs	The result is a list of CLs that change the crashed files.

Author: sunnyps
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/3b0f0b8d3db0a9f66864d5b7da87c82f49e74a29
Time: Wed Jun 15 19:05:46 2016
Files tile_task_manager.cc, tile_manager.cc are changed in this cl (and is part of stack frame #4, "cc::TileTaskManagerImpl::CheckForCompletedTasks")
Minimum distance from crash line to modified line: 5. (file: tile_manager.cc, crashed on: 1016, modified: 1011).

Suspected Project: chromium
Suspected Component: Internals>Compositing

Assigning to the concern owner as per Findit.
@sunnyps -- Could you please look into the issue, pardon me if it has nothing to do with your changes.
Thank You.

This is related to issue 621130 (same underlying cause)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12074d3d1ac750fb170355f503d160f48cfefed0

commit 12074d3d1ac750fb170355f503d160f48cfefed0
Author: sunnyps <sunnyps@chromium.org>
Date: Tue Jun 21 01:57:48 2016

Revert of cc: Add mailbox support to ResourceProvider write locks. (patchset #24 id:460001 of https://codereview.chromium.org/1951193002/ )

Reason for revert:
 Bug 621422 , 621130

Some tasks can be completed twice which leads to crashes.

Original issue's description:
> cc: Add mailbox support to ResourceProvider write locks.
>
> This adds support for mailboxes to ScopedWriteLockGL. Using the mailbox
> requires using ScopedTextureProvider/ScopedSkSurfaceProvider which
> ensures that the texture id for the mailbox is destroyed after use on
> the worker context.
>
> This CL also includes the following cleanup:
> 1. ResourceProvider locks don't keep resource pointers around.
> 2. ScopedSamplerGL does not inherit from ScopedReadLockGL.
> 3. GpuRasterizer is folded back into GpuRasterBufferProvider.
> 4. TileTaskManager does not own RasterBufferProvider.
>
> BUG= 525259 
> R=piman@chromium.org
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/5fa5dbdf25bbec21b84f752d3f0642cd184467e2
> Committed: https://crrev.com/3b0f0b8d3db0a9f66864d5b7da87c82f49e74a29
> Cr-Original-Commit-Position: refs/heads/master@{#398204}
> Cr-Commit-Position: refs/heads/master@{#399983}

TBR=piman@chromium.org,reveman@chromium.org,vmiura@chromium.org,ericrk@chromium.org,vmpstr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 525259 , 621422 ,621130
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2081863002
Cr-Commit-Position: refs/heads/master@{#400873}

[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/BUILD.gn
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/cc.gyp
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/output/gl_renderer.cc
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/raster/bitmap_raster_buffer_provider.cc
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/raster/bitmap_raster_buffer_provider.h
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/raster/gpu_raster_buffer_provider.cc
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/raster/gpu_raster_buffer_provider.h
[add] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/raster/gpu_rasterizer.cc
[add] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/raster/gpu_rasterizer.h
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/raster/one_copy_raster_buffer_provider.cc
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/raster/one_copy_raster_buffer_provider.h
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/raster/raster_buffer_provider.h
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/raster/raster_buffer_provider_perftest.cc
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/raster/raster_buffer_provider_unittest.cc
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/raster/zero_copy_raster_buffer_provider.cc
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/raster/zero_copy_raster_buffer_provider.h
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/resources/resource_provider.cc
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/resources/resource_provider.h
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/resources/video_resource_updater.cc
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/test/fake_raster_buffer_provider.cc
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/test/fake_raster_buffer_provider.h
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/test/fake_tile_manager.cc
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/test/fake_tile_task_manager.cc
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/test/fake_tile_task_manager.h
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/test/layer_tree_pixel_resource_test.cc
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/tiles/tile_manager.cc
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/tiles/tile_manager.h
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/tiles/tile_task_manager.cc
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/tiles/tile_task_manager.h
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0/cc/trees/layer_tree_host_unittest_context.cc

Project Member

Comment 4 by ClusterFuzz, Jun 21 2016

ClusterFuzz has detected this issue as fixed in range 400850:400924.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5797896536719360

Fuzzer: inferno_twister
Job Type: linux_asan_chrome_media
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000000
Crash State:
  cc::TileManager::OnRasterTaskCompleted
  cc::RasterTaskImpl::OnTaskCompleted
  cc::TileTaskManagerImpl::CheckForCompletedTasks
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_media&range=399951:400002
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_media&range=400850:400924

Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv96S0W2AEuik_Bt0pBhqO-VVl4EDk44Lg8kVFiFZ5Do7yyJJH9Q9TXu3ot2vg3QrRX3irwZC210fruId5lY3OiKdnuQuWfyq9AALlswyS5BI_mQIZHNNUUZBoPCpGd4QeBQZXyONYBGlMKx86dQIILB3jL-jO8DUKjetQbPgfoCQl__mjv8?testcase_id=5797896536719360


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3071e4aabd0cb1f29cd624e77eb5f40722be965

commit b3071e4aabd0cb1f29cd624e77eb5f40722be965
Author: sunnyps <sunnyps@chromium.org>
Date: Thu Jun 23 21:21:30 2016

Reland of cc: Add mailbox support to ResourceProvider write locks. (patchset #24 id:460001 of https://codereview.chromium.org/1951193002/ )

Original issue's description:
> cc: Add mailbox support to ResourceProvider write locks.
>
> This adds support for mailboxes to ScopedWriteLockGL. Using the mailbox
> requires using ScopedTextureProvider/ScopedSkSurfaceProvider which
> ensures that the texture id for the mailbox is destroyed after use on
> the worker context.
>
> This CL also includes the following cleanup:
> 1. ResourceProvider locks don't keep resource pointers around.
> 2. ScopedSamplerGL does not inherit from ScopedReadLockGL.
> 3. GpuRasterizer is folded back into GpuRasterBufferProvider.
> 4. TileTaskManager does not own RasterBufferProvider.
>
> BUG= 525259 
> R=piman@chromium.org
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/5fa5dbdf25bbec21b84f752d3f0642cd184467e2
> Committed: https://crrev.com/3b0f0b8d3db0a9f66864d5b7da87c82f49e74a29
> Cr-Original-Commit-Position: refs/heads/master@{#398204}
> Cr-Commit-Position: refs/heads/master@{#399983}

R=piman@chromium.org
BUG= 525259 ,  621422 , 621130
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2081883002
Cr-Commit-Position: refs/heads/master@{#401717}

[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/BUILD.gn
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/cc.gyp
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/output/gl_renderer.cc
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/raster/gpu_raster_buffer_provider.cc
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/raster/gpu_raster_buffer_provider.h
[delete] https://crrev.com/cddcf0efb1c2f1050c9e90a6cb849d25576e74f6/cc/raster/gpu_rasterizer.cc
[delete] https://crrev.com/cddcf0efb1c2f1050c9e90a6cb849d25576e74f6/cc/raster/gpu_rasterizer.h
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/raster/one_copy_raster_buffer_provider.cc
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/raster/one_copy_raster_buffer_provider.h
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/raster/raster_buffer_provider.h
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/raster/raster_buffer_provider_perftest.cc
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/raster/raster_buffer_provider_unittest.cc
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/resources/resource_provider.cc
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/resources/resource_provider.h
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/resources/video_resource_updater.cc
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/test/fake_tile_manager.cc
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/test/fake_tile_task_manager.cc
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/test/fake_tile_task_manager.h
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/test/layer_tree_pixel_resource_test.cc
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/tiles/tile_manager.cc
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/tiles/tile_manager.h
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/tiles/tile_task_manager.cc
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/tiles/tile_task_manager.h
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965/cc/trees/layer_tree_host_unittest_context.cc

Project Member

Comment 6 by ClusterFuzz, Jun 24 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194

commit 4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194
Author: sunnyps <sunnyps@chromium.org>
Date: Mon Jun 27 21:34:25 2016

Revert of cc: Add mailbox support to ResourceProvider write locks. (patchset #5 id:70001 of https://codereview.chromium.org/2081883002/ )

Reason for revert:
Causing canvas crashes - bug 623101

Original issue's description:
> Reland of cc: Add mailbox support to ResourceProvider write locks. (patchset #24 id:460001 of https://codereview.chromium.org/1951193002/ )
>
> Original issue's description:
> > cc: Add mailbox support to ResourceProvider write locks.
> >
> > This adds support for mailboxes to ScopedWriteLockGL. Using the mailbox
> > requires using ScopedTextureProvider/ScopedSkSurfaceProvider which
> > ensures that the texture id for the mailbox is destroyed after use on
> > the worker context.
> >
> > This CL also includes the following cleanup:
> > 1. ResourceProvider locks don't keep resource pointers around.
> > 2. ScopedSamplerGL does not inherit from ScopedReadLockGL.
> > 3. GpuRasterizer is folded back into GpuRasterBufferProvider.
> > 4. TileTaskManager does not own RasterBufferProvider.
> >
> > BUG= 525259 
> > R=piman@chromium.org
> > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> >
> > Committed: https://crrev.com/5fa5dbdf25bbec21b84f752d3f0642cd184467e2
> > Committed: https://crrev.com/3b0f0b8d3db0a9f66864d5b7da87c82f49e74a29
> > Cr-Original-Commit-Position: refs/heads/master@{#398204}
> > Cr-Commit-Position: refs/heads/master@{#399983}
>
> R=piman@chromium.org
> BUG= 525259 ,  621422 , 621130
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965
> Cr-Commit-Position: refs/heads/master@{#401717}

TBR=piman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 525259 ,  621422 , 621130

Review-Url: https://codereview.chromium.org/2106503002
Cr-Commit-Position: refs/heads/master@{#402290}

[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/BUILD.gn
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/cc.gyp
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/output/gl_renderer.cc
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/raster/gpu_raster_buffer_provider.cc
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/raster/gpu_raster_buffer_provider.h
[add] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/raster/gpu_rasterizer.cc
[add] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/raster/gpu_rasterizer.h
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/raster/one_copy_raster_buffer_provider.cc
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/raster/one_copy_raster_buffer_provider.h
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/raster/raster_buffer_provider.h
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/raster/raster_buffer_provider_perftest.cc
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/raster/raster_buffer_provider_unittest.cc
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/resources/resource_provider.cc
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/resources/resource_provider.h
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/resources/video_resource_updater.cc
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/test/fake_tile_manager.cc
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/test/fake_tile_task_manager.cc
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/test/fake_tile_task_manager.h
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/test/layer_tree_pixel_resource_test.cc
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/tiles/tile_manager.cc
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/tiles/tile_manager.h
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/tiles/tile_task_manager.cc
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/tiles/tile_task_manager.h
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194/cc/trees/layer_tree_host_unittest_context.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d6ff0d0e4c450cfb12aef3b455f63d380731935

commit 5d6ff0d0e4c450cfb12aef3b455f63d380731935
Author: sunnyps <sunnyps@chromium.org>
Date: Tue Jun 28 00:40:11 2016

Reland of cc: Add mailbox support to ResourceProvider write locks. (patchset #1 id:1 of https://codereview.chromium.org/2106503002/ )

Original issue's description:
> Revert of cc: Add mailbox support to ResourceProvider write locks. (patchset #5 id:70001 of https://codereview.chromium.org/2081883002/ )
>
> Reason for revert:
> Causing canvas crashes - bug 623101
>
> Original issue's description:
> > Reland of cc: Add mailbox support to ResourceProvider write locks. (patchset #24 id:460001 of https://codereview.chromium.org/1951193002/ )
> >
> > Original issue's description:
> > > cc: Add mailbox support to ResourceProvider write locks.
> > >
> > > This adds support for mailboxes to ScopedWriteLockGL. Using the mailbox
> > > requires using ScopedTextureProvider/ScopedSkSurfaceProvider which
> > > ensures that the texture id for the mailbox is destroyed after use on
> > > the worker context.
> > >
> > > This CL also includes the following cleanup:
> > > 1. ResourceProvider locks don't keep resource pointers around.
> > > 2. ScopedSamplerGL does not inherit from ScopedReadLockGL.
> > > 3. GpuRasterizer is folded back into GpuRasterBufferProvider.
> > > 4. TileTaskManager does not own RasterBufferProvider.
> > >
> > > BUG= 525259 
> > > R=piman@chromium.org
> > > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> > >
> > > Committed: https://crrev.com/5fa5dbdf25bbec21b84f752d3f0642cd184467e2
> > > Committed: https://crrev.com/3b0f0b8d3db0a9f66864d5b7da87c82f49e74a29
> > > Cr-Original-Commit-Position: refs/heads/master@{#398204}
> > > Cr-Commit-Position: refs/heads/master@{#399983}
> >
> > R=piman@chromium.org
> > BUG= 525259 ,  621422 , 621130
> > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> >
> > Committed: https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965
> > Cr-Commit-Position: refs/heads/master@{#401717}
>
> TBR=piman@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG= 525259 ,  621422 , 621130
>
> Committed: https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194
> Cr-Commit-Position: refs/heads/master@{#402290}

TBR=piman@chromium.org
BUG= 525259 ,  621422 , 621130

Review-Url: https://codereview.chromium.org/2101043002
Cr-Commit-Position: refs/heads/master@{#402345}

[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/BUILD.gn
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/cc.gyp
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/output/gl_renderer.cc
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/raster/gpu_raster_buffer_provider.cc
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/raster/gpu_raster_buffer_provider.h
[delete] https://crrev.com/e3c66d54cbcd9a7fd73bc2222dcb859741cc121d/cc/raster/gpu_rasterizer.cc
[delete] https://crrev.com/e3c66d54cbcd9a7fd73bc2222dcb859741cc121d/cc/raster/gpu_rasterizer.h
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/raster/one_copy_raster_buffer_provider.cc
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/raster/one_copy_raster_buffer_provider.h
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/raster/raster_buffer_provider.h
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/raster/raster_buffer_provider_perftest.cc
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/raster/raster_buffer_provider_unittest.cc
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/resources/resource_provider.cc
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/resources/resource_provider.h
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/resources/video_resource_updater.cc
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/test/fake_tile_manager.cc
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/test/fake_tile_task_manager.cc
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/test/fake_tile_task_manager.h
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/test/layer_tree_pixel_resource_test.cc
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/tiles/tile_manager.cc
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/tiles/tile_manager.h
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/tiles/tile_task_manager.cc
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/tiles/tile_task_manager.h
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935/cc/trees/layer_tree_host_unittest_context.cc

Project Member

Comment 9 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment