MacViews: views_unittests regression in WidgetObserverTest.WidgetBoundsChangedNative at r400463 |
|||
Issue descriptionChrome Version : 53.0.2767.4 OS Version: OS X 10.11.5 WidgetObserverTest.WidgetBoundsChangedNative regressed in r400463 Author: mblsha <mblsha@yandex-team.ru> Date: Fri Jun 17 11:38:18 2016 -0700 MacViews: Implement Tab Dragging BridgedNativeWidget::RunMoveLoop() drags the window by manually processing mouse move events. Most of the tests in tab_drag_controller_interactive_uitest.cc pass, and I've added several Mac-specific ones to test for the edge cases. BUG= 594079 COLLABORATOR=tapted@chromium.org Also reviewed in http://crrev.com/1259913003/ Review-Url: https://codereview.chromium.org/1747803003 Cr-Commit-Position: refs/heads/master@{#400463} error like [ RUN ] WidgetObserverTest.WidgetBoundsChangedNative [34600:1295:0620/161917:24042947926071:ERROR:native_widget_mac.mm(282)] Not implemented reached in virtual void views::NativeWidgetMac::SetWindowIcons(const gfx::ImageSkia &, const gfx::ImageSkia &) ../../ui/views/widget/widget_unittest.cc:913: Failure Value of: widget_bounds_changed() Actual: true Expected: false [ FAILED ] WidgetObserverTest.WidgetBoundsChangedNative (111 ms)
,
Jun 21 2016
Can't comment on the CL for some reason, but I can confirm your finding. Tried out to modify views_nswindow_delegate.mm so the test could be left pristine, but I was on the wrong track. Thanks!
,
Jul 4 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 6 2016
Fix landed in r401752. Bugdroid decided not to update: MacViews: Fix WidgetObserverTest.WidgetBoundsChangedNative after r400463 If a Widget bounds is outside the work area when shown, OSX will move it inside when the widget is Show()n. r400463 added a handler for -[NSWindowDelegate windowDidMove:], invoking OnNativeWidgetMove(). There was only test coverage for movement done in combination with a resize, so this wasn't noticed earlier. WidgetBoundsChangedNative regressed on Mac, because the Widget now correctly observes the movement into the work area that OSX enforces. To cover the same codepaths as before, use an origin that's inside the work area, rather than (0,0). Add coverage that would have picked up the the missing OnNativeWidgetMove() call. Currently this fails on Mus, but not other native widget types. BUG= 621419 Committed: https://crrev.com/061e7a03a36519fc21c5987e84709310b505244b Cr-Commit-Position: refs/heads/master@{#401752} |
|||
►
Sign in to add a comment |
|||
Comment 1 by tapted@chromium.org
, Jun 21 2016Status: Started (was: Available)