New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 621413 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Nov 2016
Cc:
nyerramilli@chromium.org
█ tkonch...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Focus highlight is not centre aligned for ‘chrome://md-settings/searchEngines'

Reported by dmascare...@etouch.net, Jun 20 2016 
Chrome Version:53.0.2772.0 (Official Build)f3fbfe7d3230493784f1818e1ee6bd6246112470-refs/heads/master@{#400575} 32/64 bit
OS:Windows (7,8,10), Mac (10.10.5,10.11.4),Linux(Ubuntu 14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings/searchEngines
2. Press ‘Tab’ till the focus reaches on iron icon of ‘Default search engines’
3. Observe focus highlight.

Actual: Focus highlight is not centre aligned on iron icon.
Expected: Focus highlight should be centre aligned on iron icon.

This is regression issue, broken in ‘M 50’ and will soon update the bisect info.

Good build:50.0.2658.0
Bad build: 50.0.2659.0

Comment 1 by dmascare...@etouch.net, Jun 20 2016

Labels: hasbisect
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/7915ae0dd753d281344d748789818dab97c39a37..b22486777902c050ca3e90bee66d81b03dcf5688?pretty=fuller&n=100

Suspecting: r377204 ?

Kindly help to re-assign, if your changes are not cause for this issue.
Actual_highlight.png
81.6 KB View Download

Comment 2 by dpa...@chromium.org, Jun 27 2016

Labels: Proj-MaterialDesign-WebUI
The problem is caused by this line https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/search_engines_page/search_engine_entry.css?q=search_engine_entry.css&sq=package:chromium&dr&l=35. It turns out that changing the padding of a paper-icon-button, does not play well with the underlying paper-ripple effect.
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 4 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by tbuck...@chromium.org, Jul 22 2016

Labels: Hotlist-MD-Settings-SearchEngines

Comment 5 by dmascare...@etouch.net, Oct 3 2016

Labels: -M-54 M-55
Above issue is still reproducible on Latest Canary Version:55.0.2878.0 (Official Build) 6bf82374fb3a17659851bc4e830c063577ba80fd-refs/heads/master@{#422326}

Comment 6 by dpa...@chromium.org, Nov 10 2016

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5d74227c9d1a7b78ea14389baaf6a912fd6e660

commit c5d74227c9d1a7b78ea14389baaf6a912fd6e660
Author: dpapad <dpapad@chromium.org>
Date: Thu Nov 10 02:14:01 2016

MD Settings: Fix search engines dots icon centering.

BUG= 621413 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2489043003
Cr-Commit-Position: refs/heads/master@{#431144}

[modify] https://crrev.com/c5d74227c9d1a7b78ea14389baaf6a912fd6e660/chrome/browser/resources/settings/search_engines_page/search_engine_entry_css.html

Comment 8 by dpa...@chromium.org, Nov 10 2016

Status: Fixed (was: Started)
►

Sign in to add a comment