New issue
Advanced search Search tips

Issue 621403 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Find-in-page finds text in shadow DOM

Reported by zgoo...@eblong.com, Jun 20 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/601.6.17 (KHTML, like Gecko) Version/9.1.1 Safari/601.6.17

Steps to reproduce the problem:
1. Load an Electron app which creates shadow DOM elements
2. Call webcontents.findInPage(). (This is a Javascript wrapper around Chrome's WebContents.Find() method.)

What is the expected behavior?
I have created a search widget in the shadow DOM. The widget is just an <input> tag whose event handler calls webcontents.findInPage() In this use case, we want to only search the main DOM.

What went wrong?
The text in the shadow <input> tag was highlighted as part of the search results.

Did this work before? N/A 

Chrome version: 51.0.2704.84  Channel: stable
OS Version: OS X 10.11.5
Flash Version: Shockwave Flash 21.0 r0

I see that including the shadow DOM in the search is deliberate. (https://bugs.chromium.org/p/chromium/issues/detail?id=244955, https://bugs.chromium.org/p/chromium/issues/detail?id=353430) However, in my app  I need the opposite behavior.

It would be great if there were a flag in the options to include/exclude the shadow DOM.
 
Components: Blink>WebComponents UI>Browser>FindInPage

Comment 2 by tkent@chromium.org, Jun 24 2016

Cc: yosin@chromium.org

Comment 3 by tkent@chromium.org, Jul 29 2016

Owner: hayato@chromium.org
Assign hayato@ for confirmation/triage

Cc: -yosin@chromium.org hayato@chromium.org
Owner: yosin@chromium.org
Status: Assigned (was: Unconfirmed)
As far as I know, this is an expected behavior, and there is no flag to control the behavior.

yosin@, please correct me if my understanding is wrong.

Comment 5 by hayato@chromium.org, Oct 12 2016

Components: -Blink>WebComponents Blink>DOM>ShadowDOM

Comment 6 by yosin@chromium.org, Mar 23 2017

Owner: ----
Status: Available (was: Assigned)

Comment 7 by hayato@chromium.org, May 26 2017

Cc: -hayato@chromium.org
Components: -Blink>DOM>ShadowDOM
Project Member

Comment 8 by sheriffbot@chromium.org, May 28 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: Untriaged)
Mac triage: WontFix based on #4.

Sign in to add a comment