Issue metadata
Sign in to add a comment
|
Remove migration code for domain scoped settings after two milestones |
||||||||||||||||||||||||
Issue descriptionThere are some migration code for crbug.com/604612 to change domain scoped content settings to be origin scoped. The migration code should be removed after leaving in code for a long time and users have already been migrated (~M55).
,
Dec 5 2016
,
Jun 2 2017
Tim - you may be interested since I know you like this stuff :) The function is HostContentSettingsMap::MigrateDomainScopedSettings
,
Aug 22 2017
,
Nov 10 2017
,
Nov 12 2017
I'll take this one. :)
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/305f182f5cfff0758e0c6a46f46cf84feb660886 commit 305f182f5cfff0758e0c6a46f46cf84feb660886 Author: Dominick Ng <dominickn@chromium.org> Date: Mon Nov 13 23:09:24 2017 Remove migration code for domain scoped settings. This CL removes the domain to origin scoped migration code added for crbug.com/604612 . The pref used for the migration is now cleared on startup to ensure that dead data is not retained. BUG= 621398 Change-Id: I053091ae9e6e5f816a5e5ece84bd7f46882904fa Reviewed-on: https://chromium-review.googlesource.com/765554 Reviewed-by: Timothy Loh <timloh@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#516089} [modify] https://crrev.com/305f182f5cfff0758e0c6a46f46cf84feb660886/chrome/browser/content_settings/host_content_settings_map_factory.cc [modify] https://crrev.com/305f182f5cfff0758e0c6a46f46cf84feb660886/chrome/browser/content_settings/host_content_settings_map_unittest.cc [modify] https://crrev.com/305f182f5cfff0758e0c6a46f46cf84feb660886/components/content_settings/core/browser/content_settings_pref_provider.cc [modify] https://crrev.com/305f182f5cfff0758e0c6a46f46cf84feb660886/components/content_settings/core/browser/host_content_settings_map.cc [modify] https://crrev.com/305f182f5cfff0758e0c6a46f46cf84feb660886/components/content_settings/core/browser/host_content_settings_map.h [modify] https://crrev.com/305f182f5cfff0758e0c6a46f46cf84feb660886/components/content_settings/core/common/content_settings_pattern.cc [modify] https://crrev.com/305f182f5cfff0758e0c6a46f46cf84feb660886/components/content_settings/core/common/content_settings_pattern.h [modify] https://crrev.com/305f182f5cfff0758e0c6a46f46cf84feb660886/components/content_settings/core/common/content_settings_pattern_unittest.cc [modify] https://crrev.com/305f182f5cfff0758e0c6a46f46cf84feb660886/components/content_settings/core/common/pref_names.cc [modify] https://crrev.com/305f182f5cfff0758e0c6a46f46cf84feb660886/components/content_settings/core/common/pref_names.h
,
Nov 13 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by lshang@chromium.org
, Dec 4 2016Status: Available (was: Assigned)