New issue
Advanced search Search tips

Issue 621383 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on: View detail
issue 611224
issue 666561
issue 611802



Sign in to add a comment

Replace type converters with typemaps

Project Member Reported by sa...@chromium.org, Jun 20 2016

Issue description

Type converters are effectively deprecated.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977

commit f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977
Author: sammc <sammc@chromium.org>
Date: Tue Jun 21 05:39:39 2016

Mojo: Remove url type converters.

BUG=621383
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2083433002
Cr-Commit-Position: refs/heads/master@{#400900}

[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/chrome/browser/BUILD.gn
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/chrome/browser/browser_resources.grd
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/chrome/browser/resources/engagement/site_engagement.js
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/chrome/browser/ui/webui/engagement/BUILD.gn
[add] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/chrome/browser/ui/webui/engagement/OWNERS
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/chrome/browser/ui/webui/engagement/site_engagement.mojom
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/chrome/browser/ui/webui/engagement/site_engagement_ui.cc
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/chrome/chrome_browser.gypi
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/chrome/chrome_resources.gyp
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/chrome/chrome_web_ui_mojo_bindings.gyp
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/components/password_manager.gypi
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/components/password_manager/content/browser/BUILD.gn
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/components/password_manager/content/browser/credential_manager_impl.cc
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/components/password_manager/content/browser/credential_manager_impl.h
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/components/password_manager/content/browser/credential_manager_impl_unittest.cc
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/components/password_manager/content/public/cpp/BUILD.gn
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/components/password_manager/content/public/cpp/type_converters.cc
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/components/password_manager/content/public/interfaces/BUILD.gn
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/components/password_manager/content/public/interfaces/credential_manager.mojom
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/components/password_manager/content/renderer/BUILD.gn
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/components/password_manager/content/renderer/credential_manager_client.cc
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/components/password_manager/content/renderer/credential_manager_client_browsertest.cc
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/content/browser/BUILD.gn
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/content/browser/frame_host/frame_mojo_shell.cc
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/content/common/BUILD.gn
[add] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/content/common/image_downloader/OWNERS
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/content/common/image_downloader/image_downloader.mojom
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/content/content_browser.gypi
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/content/content_renderer.gypi
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/content/renderer/image_downloader/image_downloader_impl.cc
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/content/renderer/image_downloader/image_downloader_impl.h
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/device/device_tests.gyp
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/device/usb/mojo/type_converters.cc
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/ios/web/ios_web.gyp
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/media/mojo/clients/mojo_cdm.cc
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/media/mojo/clients/mojo_cdm.h
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/media/mojo/interfaces/BUILD.gn
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/media/mojo/interfaces/content_decryption_module.mojom
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/media/mojo/services/mojo_cdm_service.cc
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/mojo/common/BUILD.gn
[add] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/mojo/common/OWNERS
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/mojo/common/common_type_converters_unittest.cc
[delete] https://crrev.com/1201e5870ce0bcbb9e31518fcbc2ac2635d07187/mojo/common/url_type_converters.cc
[delete] https://crrev.com/1201e5870ce0bcbb9e31518fcbc2ac2635d07187/mojo/common/url_type_converters.h
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/mojo/mojo_base.gyp
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/net/interfaces/BUILD.gn
[add] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/net/interfaces/OWNERS
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/net/interfaces/proxy_resolver_service.mojom
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/net/net.gyp
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/net/proxy/mojo_proxy_resolver_impl.cc
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/net/proxy/mojo_proxy_resolver_impl.h
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/net/proxy/mojo_proxy_resolver_impl_unittest.cc
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/net/proxy/proxy_resolver_factory_mojo.cc
[modify] https://crrev.com/f6f4fcfe9f45b44df6706a5ee6dcd4c74fe7d977/net/proxy/proxy_resolver_factory_mojo_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/170917fcc907d4e4c9b13d2a367dc5da2ac6b406

commit 170917fcc907d4e4c9b13d2a367dc5da2ac6b406
Author: sammc <sammc@chromium.org>
Date: Sun Oct 09 23:26:04 2016

Replace //net TypeConverters with StructTraits.

BUG=621383

Review-Url: https://codereview.chromium.org/2083463002
Cr-Commit-Position: refs/heads/master@{#424110}

[modify] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/mojo/public/cpp/bindings/BUILD.gn
[modify] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/mojo/public/tools/bindings/chromium_bindings_configuration.gni
[modify] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/BUILD.gn
[modify] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/base/address_list.h
[add] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/dns/OWNERS
[modify] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/dns/host_resolver_mojo.cc
[modify] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/dns/host_resolver_mojo.h
[modify] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/dns/host_resolver_mojo_unittest.cc
[modify] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/dns/mojo_host_resolver_impl.cc
[modify] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/dns/mojo_host_resolver_impl.h
[modify] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/dns/mojo_host_resolver_impl_unittest.cc
[add] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/dns/mojo_host_struct_traits.cc
[add] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/dns/mojo_host_struct_traits.h
[delete] https://crrev.com/680f9d60ee6c44ef2677d869860017c2350fab63/net/dns/mojo_host_type_converters.cc
[delete] https://crrev.com/680f9d60ee6c44ef2677d869860017c2350fab63/net/dns/mojo_host_type_converters.h
[add] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/interfaces/host_resolver.typemap
[modify] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/interfaces/host_resolver_service.mojom
[add] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/interfaces/proxy_resolver.typemap
[modify] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/interfaces/proxy_resolver_service.mojom
[add] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/interfaces/typemaps.gni
[add] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/proxy/OWNERS
[modify] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/proxy/mojo_proxy_resolver_factory_impl_unittest.cc
[modify] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/proxy/mojo_proxy_resolver_impl.cc
[modify] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/proxy/mojo_proxy_resolver_impl_unittest.cc
[modify] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/proxy/mojo_proxy_resolver_v8_tracing_bindings.h
[modify] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/proxy/mojo_proxy_resolver_v8_tracing_bindings_unittest.cc
[add] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/proxy/mojo_proxy_struct_traits.cc
[add] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/proxy/mojo_proxy_struct_traits.h
[delete] https://crrev.com/680f9d60ee6c44ef2677d869860017c2350fab63/net/proxy/mojo_proxy_type_converters.cc
[delete] https://crrev.com/680f9d60ee6c44ef2677d869860017c2350fab63/net/proxy/mojo_proxy_type_converters.h
[modify] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/proxy/proxy_resolver_factory_mojo.cc
[modify] https://crrev.com/170917fcc907d4e4c9b13d2a367dc5da2ac6b406/net/proxy/proxy_resolver_factory_mojo_unittest.cc

Components: -Internals>Mojo Internals>Mojo>Bindings
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5c04f866115e2e1040d8f09fa34732ccbec54b3

commit b5c04f866115e2e1040d8f09fa34732ccbec54b3
Author: yzshen <yzshen@chromium.org>
Date: Mon Jan 23 20:11:33 2017

Mojo C++ bindings: add a "deprecated" comment to type_converter.h

BUG=621383

Review-Url: https://codereview.chromium.org/2652783002
Cr-Commit-Position: refs/heads/master@{#445455}

[modify] https://crrev.com/b5c04f866115e2e1040d8f09fa34732ccbec54b3/mojo/public/cpp/bindings/type_converter.h

Comment 5 by scheib@chromium.org, Jan 24 2017

Blockedon: 666561
Blockedon: 611224
Project Member

Comment 7 by sheriffbot@chromium.org, Apr 12 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-3 Pri-2
Status: Available (was: Untriaged)
Somehow people are still adding TypeConverter specializations to the tree. We should really delete this. Triaging with slightly higher priority.

Sign in to add a comment