New issue
Advanced search Search tips

Issue 621382 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update layout test expectations for v8:4955

Reported by jwo...@igalia.com, Jun 20 2016

Issue description

See https://bugs.chromium.org/p/v8/issues/detail?id=4955

Variable redeclaration errors are changing from TypeError to SyntaxError, which changes the expected output of inspector-protocol/console/console-let-const-with-api.html . The new output is more conformant to the ES spec.
 
Labels: Te-NeedsFurtherTriage

Comment 2 by adamk@chromium.org, Jun 21 2016

Components: Blink>JavaScript>Language
Labels: -OS-Linux -Te-NeedsFurtherTriage
Owner: adamk@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c932752b9e1e58cb30262b0bd213005c27c4fcde

commit c932752b9e1e58cb30262b0bd213005c27c4fcde
Author: jwolfe <jwolfe@igalia.com>
Date: Tue Jun 21 19:09:59 2016

Layout Test needs manual rebaseline due to  issue v8:4955 

The expected output of
inspector-protocol/console/console-let-const-with-api.html needs to
change which type of error is expected from variable redeclaration.
It used to be TypeError; now it's SyntaxError.

BUG= 621382 
LOG=n

Review-Url: https://codereview.chromium.org/2084963002
Cr-Commit-Position: refs/heads/master@{#401067}

[modify] https://crrev.com/c932752b9e1e58cb30262b0bd213005c27c4fcde/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ae52a5e1be50f8b38d215cd65754dd23f6c00ef

commit 9ae52a5e1be50f8b38d215cd65754dd23f6c00ef
Author: jwolfe <jwolfe@igalia.com>
Date: Wed Jun 22 19:59:36 2016

Rebaseline Layout Test for  issue v8:4955 

The expected output of
inspector-protocol/console/console-let-const-with-api.html needs to
change which type of error is expected from variable redeclaration.
It used to be TypeError; now it's SyntaxError.

BUG= 621382 
LOG=n
R=adamk

Review-Url: https://codereview.chromium.org/2089753002
Cr-Commit-Position: refs/heads/master@{#401389}

[modify] https://crrev.com/9ae52a5e1be50f8b38d215cd65754dd23f6c00ef/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/9ae52a5e1be50f8b38d215cd65754dd23f6c00ef/third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api-expected.txt

Comment 5 by adamk@chromium.org, Jun 23 2016

Status: Fixed (was: Assigned)

Sign in to add a comment