New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621381 link

Starred by 5 users

Issue metadata

Status: Archived
Owner: ----
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Window restores on relaunch after being closed

Project Member Reported by sdy@google.com, Jun 19 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36

Steps to reproduce the problem:
1. Have at least one tab open and "Continue where you left off" enabled in settings.
2. Close it by clicking the window's close button (for one or more tabs), the tab's close button (for a single tab), or cmd+shift+w.
3. Quit and relaunch Chrome.
4. Repeat steps 1-3 but use cmd+w to close all tabs instead.

What is the expected behavior?
In either case, the window should not be restored since it was closed before quit.

What went wrong?
- When the window was closed with cmd+shift+w, the window close button, or the last tab's 'x' button, the window comes back on relaunch.
- When the window was closed with cmd+w, it does not come back on relaunch.

Did this work before? No 

Chrome version: 53.0.2772.0  Channel: stable
OS Version: OS X 10.11.5
Flash Version: Shockwave Flash 22.0 r0
 

Comment 1 by sdy@google.com, Jun 19 2016

(shrike: this might be a good first bug for *me*, since it's small and actively bugs me.)

Also, correction: I tested on the canary channel.
Cc: rnimmagadda@chromium.org
Labels: Needs-Feedback
Unable to repro this issue on MAC (10.11.5) for Google Chrome Canary Version - 53.0.2773.0

Screen-recording is attached.

@sdy: Please have a look at the attached screen-recording and let us know if the procedure followed is correct. Else, please provide us the screen-recording for better understanding.

Thank you.
621381.mov
24.3 MB Download
Cc: pinkerton@chromium.org pawli...@chromium.org
I've seen this from time to time, but it's not easy to repro. I think pawliger saw it too. 
We seem to have regressed on restoring minimized and maximized state. Also if you change the minimized state or z order of windows during session restore we seem to force the window back to the original minimized state or z order when we shouldn't

Comment 5 by sdy@google.com, Jun 20 2016

@rnimmagadda, it looks like this only happens if it's the last open window. That was the difference in your test. Screen recording attached (had to compress it to get <10MB, sorry).
session_restoration_bug.mp4
8.8 MB View Download
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 20 2016

Labels: -Needs-Feedback Needs-Review
Owner: rnimmagadda@chromium.org
Thank you for providing more feedback. Adding requester "rnimmagadda@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Jun 20 2016

Labels: Hotlist-Google

Comment 8 by shrike@chromium.org, Jun 21 2016

Cc: shrike@chromium.org
I tracked down and fixed several possibly-related bugs last year (see  Issue 535645 ,  Issue 536201 ,  Issue 536280 ). My first thought is that someone may have made changed around the code I fixed, so once you figure out which source files most-likely contain the bug you might look at their change logs for recent changes. That's if you don't have a set of repro steps.

Happy to demo - can repro 100% with my session restore (about 8 windows, ~20 tabs)

Comment 10 by sdy@google.com, Jun 21 2016

@pawliger: Can you repro with multiple windows? I only have a test case for the last window (i.e. a window only comes back incorrectly if I close *all* windows, and then only the last one closed comes back.). Either way, I'm going to start working on this (and claim the bug as soon as I get my chromium.org account set up).
As I said in #9, I can repro 100% with multiple windows.

Comment 12 by sdy@google.com, Jun 21 2016

Sweet. Please post instructions and/or that demo when you have a chance.

Comment 13 by sdy@chromium.org, Jun 21 2016

Labels: -Needs-Review
Owner: sdy@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 14 by sdy@chromium.org, Jun 21 2016

Labels: allpublic

Comment 15 by sdy@chromium.org, Jun 30 2016

Status: Started (was: Assigned)
@pawliger, if you have a test case and/or demo for multiple windows, send it over.
See https://drive.google.com/open?id=0BwnThP3xKNFlVFJVRGU5NFRxbjg for a 1:30 experience of me quitting and launching Chrome dev and seeing 1) windows restore in different state than they were on quit 2) windows spontaneous activate, change z order, and maximize after I've minimized them during restore

Comment 17 by sdy@chromium.org, Jul 5 2016

@pawliger: Sorry for the lag, I've been OOO with spotty internet. I think you found a separate issue — I've been seeing the symptoms in this bug for a *long* time; it's not a recent regression like what you demonstrated.

Regardless, I can reproduce it reliably on dev and canary, and not on beta or release — so last known good is 52.0.2743.60, first known bad is 53.0.2783.5. I still have spotty internet so I can't do much searching or bisecting (also, having been on the team for ~1 week, I've never needed to pin down a regression among 7737 commits :) ). If you could file this separately or find an existing report (and cc me, I'm interested), maybe someone else could take a look — if they're in NYC, maybe I can peek over their shoulder while they track it down.
Hey sdy@,

For pawliger@'s bug, would you please go ahead and file that in a new bug? Especially if you're able to reproduce the problem at will, filing the bug yourself will ensure that your steps get captured, along with whatever other notes you have about the issue (regression range, etc.).

When you file the bug please add me to the cc list and I will send you steps next steps on finding the cause. There's a tool that should be able to help you further pin down the regression range so that you're not digging through several thousand commits.

Comment 19 by sdy@chromium.org, Sep 26 2016

Labels: Hotlist-MacQualityOfLife

Comment 20 by sdy@chromium.org, Oct 5 2016

Labels: -Hotlist-MacQualityOfLife Proj-MacQualityOfLife

Comment 21 by sdy@chromium.org, Dec 1 2016

Labels: -Proj-MacQualityOfLife Hotlist-MacQualityOfLife
Labels: -Hotlist-MacQualityOfLife Hotlist-PlatformExcellence
Migrating to more generic platform label, so that it can be applied to other platforms (i.e. I love the idea).

Comment 23 by sdy@chromium.org, Feb 23 2017

Cc: sdy@chromium.org
 Issue 625389  has been merged into this issue.

Comment 24 by sdy@chromium.org, Feb 23 2017

Owner: ----
Status: Available (was: Started)

Comment 25 by sdy@chromium.org, Nov 1 2017

Cc: sureshkumari@chromium.org
 Issue 659556  has been merged into this issue.
Status: Archived (was: Available)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Sign in to add a comment