New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 621348 link

Starred by 1 user
Status: Fixed
Owner:
█ spqc...@chromium.org
Last visit > 30 days ago
Closed: Jul 2016
Cc:
█ shrike@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Mac][MaterialDesign] In Incognito mode the volume badge on tabs playing sounds is faded on tab drag

Project Member Reported by meh...@chromium.org, Jun 19 2016 
Version: Chrome 53.0.2772.0 canary (64-bit)
OS: OSX 10.11.5

What steps will reproduce the problem?
(1) Open two tabs in an Incognito Window.
(2) In one of the tabs play a YouTube video. You will notice that the volume badge on that tab is bright.
(3) Now drag and drop the YouTube Video out of the Window.

What is the expected output? What do you see instead?
The volume badge on the tab with the video is faded after dragging it out of the Tabstrip.

Please use labels and text to provide additional information.
A screencast is attached.
Volume_Badge_issue.mov
558 KB Download

Comment 1 by durga.behera@chromium.org, Jun 20 2016

Cc: -shrike@chromium.org
Labels: M-53
Owner: shrike@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce the issue on Mac 10.11.5 using latest canary 53.0.2773.0.
This is a non regression issue seen since 52.0.2709.0 as the volume icon on the tab used to be shaded even before to drag the tab.

Note : Its not reproduced on Win 7 and Ubuntu 14.04.

Suspect from below Bisect info:
===============================
Good : 52.0.2708.0
Bad : 52.0.2709.0

Omahaproxy UI change Log:
===========================
https://chromium.googlesource.com/chromium/src/+log/52.0.2708.0..52.0.2709.0?pretty=fuller&n=10000

Suspect : https://codereview.chromium.org/1883033002
shrike@ : Could you please take a look into this if its related to your change.

Comment 2 by durga.behera@chromium.org, Jun 20 2016

Labels: has-Bisect

Comment 3 by shrike@chromium.org, Jun 20 2016

Cc: -spqc...@chromium.org shrike@chromium.org
Owner: spqc...@chromium.org

Comment 4 by spqc...@chromium.org, Jun 23 2016

Status: Started (was: Assigned)
This doesn't just occur with the volume badge. It also happens with the close tab button. Basically when we detach the tab, the tab is getting the incorrect "hasDarkTheme" value.
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 4 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a63ec95961ece7c912ddd2892d0435c331a0d4c7

commit a63ec95961ece7c912ddd2892d0435c331a0d4c7
Author: spqchan <spqchan@chromium.org>
Date: Fri Jul 08 18:06:25 2016

[Material][Mac] Fix the indicator and close button in a dragged tab

Override hasDarkTheme: in TabWindowOverlayWindow so that we
return the correct value. Make sure that the indicator icon updates its
color when it moves to a new window.

BUG= 621348 

Review-Url: https://codereview.chromium.org/2126953002
Cr-Commit-Position: refs/heads/master@{#404438}

[modify] https://crrev.com/a63ec95961ece7c912ddd2892d0435c331a0d4c7/chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa.mm
[modify] https://crrev.com/a63ec95961ece7c912ddd2892d0435c331a0d4c7/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

Comment 7 by spqc...@chromium.org, Jul 8 2016

Status: Fixed (was: Started)
►

Sign in to add a comment