New issue
Advanced search Search tips

Issue 621306 link

Starred by 4 users

Issue metadata

Status: Archived
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

"AccessibilityHighlightManagerTest.*" are flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 18 2016

Issue description

"AccessibilityHighlightManagerTest.TestCaretRingDrawsBluePixels" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySQsSBUZsYWtlIj5BY2Nlc3NpYmlsaXR5SGlnaGxpZ2h0TWFuYWdlclRlc3QuVGVzdENhcmV0UmluZ0RyYXdzQmx1ZVBpeGVscww.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Project Member

Comment 1 by chromium...@appspot.gserviceaccount.com, Jun 19 2016

Detected 4 new flakes for test/step "AccessibilityHighlightManagerTest.TestCaretRingDrawsBluePixels". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySQsSBUZsYWtlIj5BY2Nlc3NpYmlsaXR5SGlnaGxpZ2h0TWFuYWdlclRlc3QuVGVzdENhcmV0UmluZ0RyYXdzQmx1ZVBpeGVscww. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 2 by chromium...@appspot.gserviceaccount.com, Jun 20 2016

Detected 6 new flakes for test/step "AccessibilityHighlightManagerTest.TestCaretRingDrawsBluePixels". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySQsSBUZsYWtlIj5BY2Nlc3NpYmlsaXR5SGlnaGxpZ2h0TWFuYWdlclRlc3QuVGVzdENhcmV0UmluZ0RyYXdzQmx1ZVBpeGVscww. This message was posted automatically by the chromium-try-flakes app.
 Issue 621522  has been merged into this issue.
 Issue 621315  has been merged into this issue.
Cc: dpranke@chromium.org
Labels: OS-Chrome
Status: Available (was: Untriaged)
Summary: "AccessibilityHighlightManagerTest.*" are flaky (was: "AccessibilityHighlightManagerTest.TestCaretRingDrawsBluePixels" is flaky)
These are all occurring on  linux_chromium_chromeos_rel_ng which just flipped over to gn.

the usual pattern is that the test fails consistently for a run.

The CQ then retries the build & test and it usually works.

one of the CLs actually has 2 retries before success.
AccessibilityHighlightManagerTest.TestCaretRingDrawsBluePixels (run #1):
[ RUN      ] AccessibilityHighlightManagerTest.TestCaretRingDrawsBluePixels
[1757:1757:0620/055621:WARNING:chrome_browser_main_chromeos.cc(332)] Running as stub user with profile dir: test-user
[1757:1757:0620/055621:WARNING:audio_manager.cc(297)] Multiple instances of AudioManager detected
[1757:1757:0620/055621:WARNING:audio_manager.cc(271)] Multiple instances of AudioManager detected
[1757:1757:0620/055621:ERROR:logging_chrome.cc(172)] Unable to create symlink /tmp/.org.chromium.Chromium.IBv7O7/dPI4cxC/test-user/chrome_debug.log pointing at /tmp/.org.chromium.Chromium.IBv7O7/dPI4cxC/test-user/chrome_debug_20160620-055621.log: No such file or directory
Xlib:  extension "RANDR" missing on display ":9".
[1757:1804:0620/055621:WARNING:local_extension_cache.cc(259)] Extensions will not be installed from update URLs until /tmp/.org.chromium.Chromium.IBv7O7/dPI4cxC/stub_device_local_extension_cache/.initialized exists.
[1757:1757:0620/055621:WARNING:child_account_service.cc(302)] User instance wasn't found while setting child account flag.
[1757:1808:0620/055621:WARNING:freezer_cgroup_process_manager.cc(59)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes.
[1757:1757:0620/055621:INFO:power_button_observer.cc(38)] Creating PowerButtonObserver 0x38fc2a5c0460
[1757:1757:0620/055621:INFO:lock_state_controller.cc(230)] LockStateController::OnLoginStateChanged login_status_: 0, status: 2
[1849:1849:0620/055621:ERROR:service_registry_impl.cc(84)] mojom::ResourceUsageReporter not found
../../chrome/browser/chromeos/accessibility/accessibility_highlight_manager_browsertest.cc:166: Failure
The difference between 1487 and diff_count() is 1487, which exceeds 50, where

Cc: steve...@chromium.org dmazz...@chromium.org
Owner: dmazz...@chromium.org
Status: Assigned (was: Available)
I thought I remembered these test names from longer ago than Friday.

Git log tells me they were only added then.

Dmazzoni, as the adder can you get them to be less flaky or disable them until they are?

James Cook just noticed that some similar tests run under interactive_ui_tests.

Landing this change now to move them there:
https://codereview.chromium.org/2087623002

If they're still flaky there I'll disable until I can figure out a solution.

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/812f9f71170ea1d810237807c8d7f664ddc9ed2c

commit 812f9f71170ea1d810237807c8d7f664ddc9ed2c
Author: dmazzoni <dmazzoni@chromium.org>
Date: Mon Jun 20 22:10:42 2016

Move AccessibilityHighlightManagerTest to interactive_ui_tests

Other tests that take a pixel snapshot seem to be there, hopefully it will
be less flaky.

BUG=609173,  314889 ,  621306 

Review-Url: https://codereview.chromium.org/2087623002
Cr-Commit-Position: refs/heads/master@{#400808}

[rename] https://crrev.com/812f9f71170ea1d810237807c8d7f664ddc9ed2c/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc
[modify] https://crrev.com/812f9f71170ea1d810237807c8d7f664ddc9ed2c/chrome/chrome_tests.gypi

Comment 11 by xlai@chromium.org, Jun 20 2016

The flakiness now moves from browser tests to interactive_ui_tests. Example build: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/231176

Is it okay if you label the test as flaky first before finding a solution? This thing is blocking CLs from landing.
Disabling now.

Landing with NOTRY=true: https://codereview.chromium.org/2085483004/

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f27e6e4e922d911d49c782df059d16debe47b9d9

commit f27e6e4e922d911d49c782df059d16debe47b9d9
Author: dmazzoni <dmazzoni@chromium.org>
Date: Mon Jun 20 23:16:39 2016

Disable AccessibilityHighlightManagerTests because of flakiness

BUG= 621306 
NOTRY=true
TBR=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2085483004
Cr-Commit-Position: refs/heads/master@{#400826}

[modify] https://crrev.com/f27e6e4e922d911d49c782df059d16debe47b9d9/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc

Project Member

Comment 15 by chromium...@appspot.gserviceaccount.com, Jun 21 2016

Detected 15 new flakes for test/step "AccessibilityHighlightManagerTest.TestCursorRingDrawsRedPixels". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySQsSBUZsYWtlIj5BY2Nlc3NpYmlsaXR5SGlnaGxpZ2h0TWFuYWdlclRlc3QuVGVzdEN1cnNvclJpbmdEcmF3c1JlZFBpeGVscww. This message was posted automatically by the chromium-try-flakes app.
Labels: -Sheriff-Chromium
Project Member

Comment 17 by chromium...@appspot.gserviceaccount.com, Jun 21 2016

Labels: Sheriff-Chromium
Detected 17 new flakes for test/step "AccessibilityHighlightManagerTest.TestFocusRingDrawsOrangePixels". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySwsSBUZsYWtlIkBBY2Nlc3NpYmlsaXR5SGlnaGxpZ2h0TWFuYWdlclRlc3QuVGVzdEZvY3VzUmluZ0RyYXdzT3JhbmdlUGl4ZWxzDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 18 by chromium...@appspot.gserviceaccount.com, Jun 21 2016

Detected 6 new flakes for test/step "AccessibilityHighlightManagerTest.TestCaretRingDrawsBluePixels". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySQsSBUZsYWtlIj5BY2Nlc3NpYmlsaXR5SGlnaGxpZ2h0TWFuYWdlclRlc3QuVGVzdENhcmV0UmluZ0RyYXdzQmx1ZVBpeGVscww. This message was posted automatically by the chromium-try-flakes app.
Labels: -Sheriff-Chromium
DISABLE has landed
Project Member

Comment 20 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81b4256b39ac2a3e8391aff4921599394f19fc19

commit 81b4256b39ac2a3e8391aff4921599394f19fc19
Author: dmazzoni <dmazzoni@chromium.org>
Date: Tue Jun 21 20:58:14 2016

Fix flakiness in AccessibilityHighlightManagerTest and re-enable.

I ran these tests 10x on try servers with this change and saw no more
flakiness.

BUG= 621306 

Review-Url: https://codereview.chromium.org/2088903002
Cr-Commit-Position: refs/heads/master@{#401104}

[modify] https://crrev.com/81b4256b39ac2a3e8391aff4921599394f19fc19/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc

Status: Fixed (was: Assigned)
Labels: VerifyIn-53
Labels: VerifyIn-54
Labels: VerifyIn-55

Comment 25 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 26 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 27 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 28 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 29 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 31 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment