New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621302 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocked on:
issue 604520



Sign in to add a comment

Replace hard-coded Omnibox security vectors with calls to CreateVectorIcon()

Project Member Reported by shrike@chromium.org, Jun 18 2016

Issue description

M52 includes code that directly draws the security icons as vectors because the patch with the new security icons wasn't landed in M52. Now that the icons are landed and have been tweaked (specifically, adjusted down 1px for Retina), the M52 vector code should be replaced by the standard call to CreateVectorIcon().

We will want to confirm that these icons look good (e.g. that they do sit correctly on the baseline on Retina) before landing this patch.

 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 4 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfccc541278834822ffa03ce50252fe258c58d13

commit bfccc541278834822ffa03ce50252fe258c58d13
Author: spqchan <spqchan@chromium.org>
Date: Wed Jul 13 17:07:07 2016

[Material][Mac]Replaced hard coded Omnibox vectors

Removed the hard coded drawings for the Omnibox vector icons.
Replace them with a call to CreateVectorIcon()

BUG= 621302 

Review-Url: https://codereview.chromium.org/2129723003
Cr-Commit-Position: refs/heads/master@{#405201}

[modify] https://crrev.com/bfccc541278834822ffa03ce50252fe258c58d13/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

Status: Fixed (was: Assigned)

Sign in to add a comment