Adjust new Omnibox security icons |
|||||||
Issue descriptionVersion: 53.0.2770.0 Bring the (i) icon into spec, per Issue 604520, and adjust the position of the lock icon in HTTPSValid mode. Attached screenshots so the current state.
,
Jun 18 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56a023d3893944b000d4e3fa17fe9b6c5d492c48 commit 56a023d3893944b000d4e3fa17fe9b6c5d492c48 Author: shrike <shrike@chromium.org> Date: Thu Jun 23 18:50:32 2016 [Mac][Material Design] Adjust (i) and lock Omnibox icons. This cl brings the (i) icon into spec, and adjusts the position of the lock icon. The same lock icon is used in https-valid and ev modes but appears 1px too low in evcert mode on Retina machines. The issue is the text label that appears next to the lock is 1px too high - this cl fixes the position of the text label as well. R=tapted@chromium.org BUG= 621277 Review-Url: https://codereview.chromium.org/2077743005 Cr-Commit-Position: refs/heads/master@{#401666} [modify] https://crrev.com/56a023d3893944b000d4e3fa17fe9b6c5d492c48/chrome/browser/ui/cocoa/location_bar/bubble_decoration.h [modify] https://crrev.com/56a023d3893944b000d4e3fa17fe9b6c5d492c48/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm [modify] https://crrev.com/56a023d3893944b000d4e3fa17fe9b6c5d492c48/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm [modify] https://crrev.com/56a023d3893944b000d4e3fa17fe9b6c5d492c48/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
,
Jun 27 2016
,
Jun 27 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8fcb23b09379b9f26a2f4fb82829123c681ed5cf commit 8fcb23b09379b9f26a2f4fb82829123c681ed5cf Author: Jayson Adams <shrike@chromium.org> Date: Mon Jun 27 23:23:36 2016 [Mac][Material Design] Adjust (i) and lock Omnibox icons. This cl brings the (i) icon into spec, and adjusts the position of the lock icon. The same lock icon is used in https-valid and ev modes but appears 1px too low in evcert mode on Retina machines. The issue is the text label that appears next to the lock is 1px too high - this cl fixes the position of the text label as well. R=tapted@chromium.org BUG= 621277 Review-Url: https://codereview.chromium.org/2077743005 Cr-Commit-Position: refs/heads/master@{#401666} (cherry picked from commit 56a023d3893944b000d4e3fa17fe9b6c5d492c48) Review URL: https://codereview.chromium.org/2102853002 . Cr-Commit-Position: refs/branch-heads/2743@{#493} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/8fcb23b09379b9f26a2f4fb82829123c681ed5cf/chrome/browser/ui/cocoa/location_bar/bubble_decoration.h [modify] https://crrev.com/8fcb23b09379b9f26a2f4fb82829123c681ed5cf/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm [modify] https://crrev.com/8fcb23b09379b9f26a2f4fb82829123c681ed5cf/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm [modify] https://crrev.com/8fcb23b09379b9f26a2f4fb82829123c681ed5cf/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
,
Jun 28 2016
,
Jun 30 2016
Verified the issue on Latest Chrome Beta# 52.0.2743.60 on Mac OS X 10.11.5 and is same as provided screen shot in Comment# 1. Adding TE-Verified Labels as the issue is fixed. Also attaching a screenshot for reference. Thank You. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by shrike@chromium.org
, Jun 18 20167.5 KB
7.5 KB View Download
8.3 KB
8.3 KB View Download
26.4 KB
26.4 KB View Download