New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 621267 link

Starred by 2 users
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

CSS presubmit doesn't check styles with includes

Project Member Reported by dschuyler@chromium.org, Jun 18 2016 
In an .html file with styles inside of
<style include="foo">
add properties in a style that are not
in alphabetical order (which should be
caught by the css checker).

Problem: the css checker will not check
the order of those properties.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd8bd32b61e0698ac4d478699e76096a2397fa80

commit fd8bd32b61e0698ac4d478699e76096a2397fa80
Author: dschuyler <dschuyler@chromium.org>
Date: Mon Jun 20 21:18:23 2016

[Presubmit] check styles with include parameters

This CL causes the css checker to be run on style tags such as
<style include="foo"> that were previously ignored by presubmit.

BUG= 621267 

Review-Url: https://codereview.chromium.org/2073343003
Cr-Commit-Position: refs/heads/master@{#400782}

[modify] https://crrev.com/fd8bd32b61e0698ac4d478699e76096a2397fa80/chrome/browser/web_dev_style/css_checker.py
[modify] https://crrev.com/fd8bd32b61e0698ac4d478699e76096a2397fa80/chrome/browser/web_dev_style/css_checker_test.py

Comment 2 by dschuyler@chromium.org, Jun 20 2016

Status: Fixed (was: Started)
►

Sign in to add a comment