New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621265 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 650482
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

chromium hooks have undocumented dependency on curl for linux

Reported by jwo...@igalia.com, Jun 18 2016

Issue description

Following these instructions on a branch new Xubuntu 16.04 installation: http://dev.chromium.org/developers/how-tos/install-depot-tools , and then doing `fetch v8` or `fetch chromium` leads to an unhelpful error about install-sysroot.py returning non-zero exit status.

I traced down the problem to be that a python script was trying to invoke `curl`, which isn't installed by default in some (all?) Ubuntu flavors. One idea is to use `wget` on linux and `curl` on OSX. Another idea is to add notes to the wiki page.
 
Cc: aga...@chromium.org martiniss@chromium.org
Components: -Infra Infra>SDK
Labels: -Restrict-View-Google Infra-DX OS-Linux

Comment 2 by aga...@chromium.org, Jun 20 2016

Cc: -martiniss@chromium.org -aga...@chromium.org thestig@chromium.org mmoss@chromium.org phajdan.jr@chromium.org
Components: -Infra>SDK
Labels: -Infra-DX
Owner: sbc@chromium.org
Status: Assigned (was: Untriaged)
Summary: chromium hooks have undocumented dependency on curl for linux (was: depot_tools has undocumented dependency on curl for linux)
This isn't depot_tools. install-sysroot.py is one of chromium's hooks[1]. So while the complaint that an undocumented dependency on curl exists is valid, it needs to be taken up with the owners[2] of that script. Assigning to sbc@, who seems to be the de-facto owner of it.

[1] https://chromium.googlesource.com/chromium/src/+/9f7c5f271a7c493f3b1fe2c16dedad70686654c6/DEPS#583
[2] https://chromium.googlesource.com/chromium/src/+/9f7c5f271a7c493f3b1fe2c16dedad70686654c6/build/linux/OWNERS
[3] https://chromium.googlesource.com/chromium/src/+blame/9f7c5f271a7c493f3b1fe2c16dedad70686654c6/build/linux/sysroot_scripts/install-sysroot.py

Comment 3 by jru...@gmail.com, Oct 6 2016

Had this issue as well on a brand new Ubuntu 16.04 install. Stacktrace was extremely unhelpful. Should at least throw some sort of helpful exception.

Comment 4 by mmoss@chromium.org, Oct 6 2016

I think the problem here is that the initial fetch shouldn't run hooks, but the docs (http://dev.chromium.org/developers/how-tos/get-the-code) don't indicate that.

It's expected that there might be dependency issues, hence the instructions to run 'install-build-deps.sh' (which installs curl) right after the first fetch. It seems wrong that those instructions talk about running 'gclient runhooks', which seems to imply that hooks wouldn't already have been run, but it doesn't say to use 'fetch --nohooks', to prevent the (possibly broken) hooks from running in the first place.
Cc: thomasanderson@chromium.org
Labels: Pri-3 Type-Bug
Duplicate of  bug 650482 ?
Mergedinto: 650482
Status: Duplicate (was: Assigned)

Sign in to add a comment