recipe roller should not add reviewers unnecessarily |
|||||||
Issue descriptionCurrently the recipe roller adds as reviewers all the reviewers (or authors? I'm not exactly sure) of the CLs it's rolling downstream. This causes a lot of email spam, which we want to avoid. The roller should only add reviewers if it's a non-trivial CL, or if the tryjobs fail.
,
Jun 21 2016
,
Jun 21 2016
Issue 620767 has been merged into this issue.
,
Jun 21 2016
I've started work on this; it looks like we can't add reviewers through the command line once we've uploaded a patchset, however...
,
Jun 21 2016
... for Rietveld. It should already work for Gerrit.
,
Jun 21 2016
ah.. :( the roller currently always uses rietveld, as far as I know. Guess i'll have to add it in :/
,
Jun 21 2016
Actually, for all the repos that roller operates in, we can use Gerrit -> they are all Git. Bonus: we can then easily do rolling.
,
Jun 21 2016
by rolling i mean we can easily try the rolls because Gerrit gives us actual refs and hashes that could be used as in recipe deps config.
,
Jun 21 2016
Ok, sounds like I need to move the roller to Gerrit. Here we go!
,
Jun 27 2016
,
Jun 27 2016
,
Jun 29 2016
,
Jun 29 2016
,
Aug 8 2016
Ok, update. I didn't end up moving the roller to gerrit; that's kinda hard. I'm not sure what the best way to progress here is; I don't think it's really possible to edit the reviewers for a Rietveld CL from the command line, and I'm not sure what the best way to do that is. Moving to gerrit would be fine, but that's a fairly bit change I think.
,
Aug 9 2016
If bug 621746 is addressed we can remove this as a blocker for recipes in repos launch - the amount of email spam should be much lower.
,
May 15 2017
This is fixed |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by martiniss@chromium.org
, Jun 18 2016