New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621264 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 620511



Sign in to add a comment

recipe roller should not add reviewers unnecessarily

Project Member Reported by martiniss@chromium.org, Jun 18 2016

Issue description

Currently the recipe roller adds as reviewers all the reviewers (or authors? I'm not exactly sure) of the CLs it's rolling downstream. This causes a lot of email spam, which we want to avoid. 

The roller should only add reviewers if it's a non-trivial CL, or if the tryjobs fail. 
 
I can hopefully work on this next week.
Cc: martiniss@chromium.org
 Issue 621998  has been merged into this issue.
 Issue 620767  has been merged into this issue.
Owner: martiniss@chromium.org
Status: Started (was: Available)
I've started work on this; it looks like we can't add reviewers through the command line once we've uploaded a patchset, however...
... for Rietveld. It should already work for Gerrit.
ah.. :( the roller currently always uses rietveld, as far as I know. Guess i'll have to add it in :/
Actually, for all the repos that roller operates in, we can use Gerrit -> they are all Git. Bonus: we can then easily do rolling.
by rolling i mean we can easily try the rolls  because Gerrit gives us actual refs and hashes that could be used as in recipe deps config.
Ok, sounds like I need to move the roller to Gerrit. Here we go!
Status: Assigned (was: Started)
Status: Started (was: Assigned)
Blocking: 584077

Comment 13 by jam@chromium.org, Jun 29 2016

Blocking: 620511
Ok, update. I didn't end up moving the roller to gerrit; that's kinda hard. I'm not sure what the best way to progress here is; I don't think it's really possible to edit the reviewers for a Rietveld CL from the command line, and I'm not sure what the best way to do that is.

Moving to gerrit would be fine, but that's a fairly bit change I think.
If  bug 621746  is addressed we can remove this as a blocker for recipes in repos launch - the amount of email spam should be much lower.
Status: Fixed (was: Started)
This is fixed

Sign in to add a comment