MD History: Cannot navigate to file:// entries |
||||||||||
Issue descriptionVersion: r400472 developer build, and presumable other builds with MD History enabled. OS: Windows, and presumably other OSes as well What steps will reproduce the problem? (1) Visit file:///path/to/foo/ (2) Open History (3) See fancy MD History page, see entry for file:///path/to/foo/ (4) Click the entry for file:///path/to/foo/ What is the expected output? Navigate to file:///path/to/foo/ What do you see instead? Nothing happens.
,
Jun 20 2016
,
Jun 20 2016
,
Jun 22 2016
,
Jul 1 2016
,
Jul 4 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 26 2016
This is a regression (works in non-MD history), and IMO should be fixed for launch (it's a useful feature, again IMO). [86087:86087:0726/155401:ERROR:CONSOLE(0)] "Not allowed to load local resource: file:///usr/local/google/home/michaelpg/Downloads/testimage.png", source: chrome://history/ (0) I'm guessing MD History is bypassing this event listener: https://cs.chromium.org/chromium/src/ui/webui/resources/js/util.js?q=util.js&sq=package:chromium&dr&l=226 which redirects clicks on file:// links.
,
Jul 26 2016
probably the event is being trapped at shadow boundaries
,
Jul 27 2016
+1 to release-blocking for launch. I use this all the time (both at work and personal use). If it's a simple fix, please do merge. kthxbye
,
Aug 9 2016
,
Aug 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0684a6f3db61f973734e654292e00ade79e8bd5d commit 0684a6f3db61f973734e654292e00ade79e8bd5d Author: calamity <calamity@chromium.org> Date: Wed Aug 10 05:48:58 2016 Use event path to detect if anchor has been clicked in WebUIs. This CL fixes an issue where MD History could not open file URLs due to the way the global anchor click listener for WebUIs worked. This has been fixed by checking the event path, as is done in iron-location's global click handler. BUG= 621260 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2184123003 Cr-Commit-Position: refs/heads/master@{#410972} [modify] https://crrev.com/0684a6f3db61f973734e654292e00ade79e8bd5d/chrome/test/data/webui/md_history/history_list_test.js [modify] https://crrev.com/0684a6f3db61f973734e654292e00ade79e8bd5d/chrome/test/data/webui/util_test.html [modify] https://crrev.com/0684a6f3db61f973734e654292e00ade79e8bd5d/ui/webui/resources/js/util.js
,
Aug 16 2016
,
Oct 25 2016
Verified on ChromeOS 8743.74.0, 54.0.2840.77 |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by tsergeant@chromium.org
, Jun 20 2016