Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19a9b8f1411afe64b2163261a04245f617e25e17

commit 19a9b8f1411afe64b2163261a04245f617e25e17
Author: apacible <apacible@chromium.org>
Date: Sat Jun 25 23:57:12 2016

[Media Router] Allow users to update cloud services pref when sync is not active.

There are two places users can update their cloud services pref:
- First run flow, with a checkbox
- Contextual menu, with a toggle

Currently, users can only update their cloud services pref if they have sync enabled. There is no technical tie-in between having sync active and using cloud services. This change makes it such that users can toggle their cloud services pref locally if sync is inactive. Now, we only check that the user is authenticated. While sync is off, however, the pref will not sync across their devices.

In the event where the user has already acknowledged the first run flow (locally on the profile), then turned on sync, we continue to enable cloud services.

BUG= 621255 ,  623330 

Review-Url: https://codereview.chromium.org/2078213002
Cr-Commit-Position: refs/heads/master@{#402072}

[modify] https://crrev.com/19a9b8f1411afe64b2163261a04245f617e25e17/chrome/browser/ui/toolbar/media_router_contextual_menu.cc
[add] https://crrev.com/19a9b8f1411afe64b2163261a04245f617e25e17/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc
[modify] https://crrev.com/19a9b8f1411afe64b2163261a04245f617e25e17/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/19a9b8f1411afe64b2163261a04245f617e25e17/chrome/chrome_tests_unit.gypi

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03b18e91b52deceb82445a6739abeb595d781c15

commit 03b18e91b52deceb82445a6739abeb595d781c15
Author: apacible <apacible@chromium.org>
Date: Sun Jun 26 00:21:17 2016

Revert of [Media Router] Allow users to update cloud services pref when sync is not active. (patchset #3 id:160001 of https://codereview.chromium.org/2078213002/ )

Reason for revert:
Caused failure on official bots.

Original issue's description:
> [Media Router] Allow users to update cloud services pref when sync is not active.
>
> There are two places users can update their cloud services pref:
> - First run flow, with a checkbox
> - Contextual menu, with a toggle
>
> Currently, users can only update their cloud services pref if they have sync enabled. There is no technical tie-in between having sync active and using cloud services. This change makes it such that users can toggle their cloud services pref locally if sync is inactive. Now, we only check that the user is authenticated. While sync is off, however, the pref will not sync across their devices.
>
> In the event where the user has already acknowledged the first run flow (locally on the profile), then turned on sync, we continue to enable cloud services.
>
> BUG= 621255 ,  623330 
>
> Committed: https://crrev.com/19a9b8f1411afe64b2163261a04245f617e25e17
> Cr-Commit-Position: refs/heads/master@{#402072}

TBR=pkasting@chromium.org,imcheng@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 621255 ,  623330 

Review-Url: https://codereview.chromium.org/2098193002
Cr-Commit-Position: refs/heads/master@{#402073}

[modify] https://crrev.com/03b18e91b52deceb82445a6739abeb595d781c15/chrome/browser/ui/toolbar/media_router_contextual_menu.cc
[delete] https://crrev.com/19a9b8f1411afe64b2163261a04245f617e25e17/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc
[modify] https://crrev.com/03b18e91b52deceb82445a6739abeb595d781c15/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/03b18e91b52deceb82445a6739abeb595d781c15/chrome/chrome_tests_unit.gypi

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eae3fc0f7fd78faa2d97ce24c150af30f7f4de1f

commit eae3fc0f7fd78faa2d97ce24c150af30f7f4de1f
Author: apacible <apacible@chromium.org>
Date: Tue Jun 28 23:45:33 2016

[Reland] [Media Router] Allow users to update cloud services pref when sync is not active.

There are two places users can update their cloud services pref:
- First run flow, with a checkbox
- Contextual menu, with a toggle

Currently, users can only update their cloud services pref if they have sync enabled. There is no technical tie-in between having sync active and using cloud services. This change makes it such that users can toggle their cloud services pref locally if sync is inactive. Now, we only check that the user is authenticated. While sync is off, however, the pref will not sync across their devices.

In the event where the user has already acknowledged the first run flow (locally on the profile), then turned on sync, we continue to enable cloud services.

[Reland Comments] This was initially reverted because it caused failures on official bots; there were #includes that were mistakenly removed.

BUG= 621255 ,  623330 

Committed: https://crrev.com/19a9b8f1411afe64b2163261a04245f617e25e17
Cr-Commit-Position: refs/heads/master@{#402072}

patch from issue 2078213002 at patchset 160001 (http://crrev.com/2078213002#ps160001)

Review-Url: https://codereview.chromium.org/2093353002
Cr-Commit-Position: refs/heads/master@{#402596}

[modify] https://crrev.com/eae3fc0f7fd78faa2d97ce24c150af30f7f4de1f/chrome/browser/ui/toolbar/media_router_contextual_menu.cc
[add] https://crrev.com/eae3fc0f7fd78faa2d97ce24c150af30f7f4de1f/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc
[modify] https://crrev.com/eae3fc0f7fd78faa2d97ce24c150af30f7f4de1f/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/eae3fc0f7fd78faa2d97ce24c150af30f7f4de1f/chrome/chrome_tests_unit.gypi

Your change meets the bar and is auto-approved for M52 (branch: 2743)

apacible@, can this be manually tested so that we can verify it on Canary before you merge the CL in to the M52 branch ?

pucchakayala@: yes, you can manually test a few scenarios:
- no user sign in (no menu item)
- user signed in w/sync enabled (menu item)
- user signed in w/out sync enabled (menu item)

You can enable Media Router on chrome://flags, and install the existing cast extension to get the icon on the extensions toolbar. Right click the icon to get the contextual menu.

I just tested in today's Canary; do you need to manually verify it on your end before I merge the CL?

Rechecked this on chrome canary version 53.0.2785.0 on Windows 7, MAC 10.11.5, Ubuntu 14.04. Enabled flag "Media Router" and installed Chrome Cast Extension. Signed into chrome ( With Sync and Without Sync). "Enable Cloud Service" Menu item was displayed in  the contextual menu. Signed out from chrome and menu item disappears.

Adding TE-Verified labels.

Missed screenshot's in the above comment. Attaching now.

Thanks.!

Deleted: With Menu Item-Signedinflow.png 35.7 KB

	With Menu Item-Signedinflow.png 35.7 KB View Download

Deleted: Without Menu Item- Signed out flow.png 26.6 KB

	Without Menu Item- Signed out flow.png 26.6 KB View Download

apacible@, can you please merge the CL in to M52 branch asap as this is verified by you in # 11 & #12.

Will do today. I'm getting to a good stopping point on a cros bug before switching gears.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df14c0d9212169faf3450c4d82b60d9d358fab1e

commit df14c0d9212169faf3450c4d82b60d9d358fab1e
Author: apacible <apacible@chromium.org>
Date: Sat Jul 02 02:44:07 2016

[Reland] [Media Router] Allow users to update cloud services pref when sync is not active.

There are two places users can update their cloud services pref:
- First run flow, with a checkbox
- Contextual menu, with a toggle

Currently, users can only update their cloud services pref if they have sync enabled. There is no technical tie-in between having sync active and using cloud services. This change makes it such that users can toggle their cloud services pref locally if sync is inactive. Now, we only check that the user is authenticated. While sync is off, however, the pref will not sync across their devices.

In the event where the user has already acknowledged the first run flow (locally on the profile), then turned on sync, we continue to enable cloud services.

[Reland Comments] This was initially reverted because it caused failures on official bots; there were #includes that were mistakenly removed.

BUG= 621255 ,  623330 
TBR=msw, imcheng
NOTRY=true
NOPRESUBMIT=true

Committed: https://crrev.com/19a9b8f1411afe64b2163261a04245f617e25e17
Cr-Commit-Position: refs/heads/master@{#402072}

patch from issue 2078213002 at patchset 160001 (http://crrev.com/2078213002#ps160001)

Review-Url: https://codereview.chromium.org/2093353002
Cr-Commit-Position: refs/heads/master@{#402596}
(cherry picked from commit eae3fc0f7fd78faa2d97ce24c150af30f7f4de1f)

Review-Url: https://codereview.chromium.org/2115203002
Cr-Commit-Position: refs/branch-heads/2743@{#575}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/df14c0d9212169faf3450c4d82b60d9d358fab1e/chrome/browser/ui/toolbar/media_router_contextual_menu.cc
[add] https://crrev.com/df14c0d9212169faf3450c4d82b60d9d358fab1e/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc
[modify] https://crrev.com/df14c0d9212169faf3450c4d82b60d9d358fab1e/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/df14c0d9212169faf3450c4d82b60d9d358fab1e/chrome/chrome_tests_unit.gypi

Verified the issue on Windows 7, Ubuntu 14.04 and Mac OS 10.11.5 using chrome latest M52-52.0.2743.75 by following steps mentioned in the comment #11. Observed "Enable Cloud Service" menu item is displayed in the contextual menu after signing in to chrome and not seen when not signed in to chrome as expected. Hence adding TE-Verified label.

ChromeOS build 8530.96.0 / 53.0.2785.154