MD Settings: sub-pages collapse instantly before the section collapses |
|||
Issue descriptionThe open/close animation is janky again: on returning to the basic page from a sub-page, the section is supposed to gradually shrink from the full height to the original section height. Instead it instantly snaps to the height of the sub-page, then shrinks to the original section height.
,
Jun 28 2016
this regressed in https://codereview.chromium.org/2054013002 when we started setting height: 100% on settings-main.
,
Jul 22 2016
,
Aug 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c4ce51ea1886af904821bdd1dd0d6d3e6932d6f commit 6c4ce51ea1886af904821bdd1dd0d6d3e6932d6f Author: michaelpg <michaelpg@chromium.org> Date: Thu Aug 25 03:28:58 2016 MD Settings: fix collapse animation once and for all Makes the collapsing card position: absolute (instead of fixed). Anchoring it to the section makes it actually follow the section, so it always moves toward the right position even if the containter's scroll/height/size changes. Should reduce jarring jumps at the end of transitions. Also moves the style changes into Web Animations instead of inline. This makes the animations fire-and-forget. Transition clean up is largely automatic, there are no styles to (forget to) remove (at the wrong time). If a transition is buggy, we're still likely to end up in the right place. This fixes several animation bugs (but likely introduces new ones). BUG= 589681 , 621245 , 622172 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2230123002 Cr-Commit-Position: refs/heads/master@{#414289} [modify] https://crrev.com/6c4ce51ea1886af904821bdd1dd0d6d3e6932d6f/chrome/browser/resources/settings/settings_main/settings_main.html [modify] https://crrev.com/6c4ce51ea1886af904821bdd1dd0d6d3e6932d6f/chrome/browser/resources/settings/settings_main/settings_main.js [modify] https://crrev.com/6c4ce51ea1886af904821bdd1dd0d6d3e6932d6f/chrome/browser/resources/settings/settings_page/compiled_resources2.gyp [modify] https://crrev.com/6c4ce51ea1886af904821bdd1dd0d6d3e6932d6f/chrome/browser/resources/settings/settings_page/main_page_behavior.html [modify] https://crrev.com/6c4ce51ea1886af904821bdd1dd0d6d3e6932d6f/chrome/browser/resources/settings/settings_page/main_page_behavior.js [modify] https://crrev.com/6c4ce51ea1886af904821bdd1dd0d6d3e6932d6f/chrome/browser/resources/settings/settings_page/settings_section.html [modify] https://crrev.com/6c4ce51ea1886af904821bdd1dd0d6d3e6932d6f/chrome/browser/resources/settings/settings_page/settings_section.js [modify] https://crrev.com/6c4ce51ea1886af904821bdd1dd0d6d3e6932d6f/chrome/browser/resources/settings/settings_page_css.html [modify] https://crrev.com/6c4ce51ea1886af904821bdd1dd0d6d3e6932d6f/chrome/test/data/webui/settings/cr_settings_browsertest.js
,
Sep 7 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tbuck...@chromium.org
, Jun 20 2016Labels: -Pri-3 Hotlist-MD-Settings-Navigation Pri-2
Status: Assigned (was: Untriaged)