New issue
Advanced search Search tips

Issue 621234 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Figure out if mus needs to restrict capture in some way

Project Member Reported by sky@chromium.org, Jun 17 2016

Issue description

Mus currently (I'm going to change it) restricts capture in such a way that you can only grab capture if an event is targeted at the client. This is problematic for tab dragging where capture needs to change from the window manager to the client and back again at random points. I'm going to make it so setcapture can be requested at any time. We need to figure out if this is an issue and if so address it. We could always restrict it for embedded apps (e.g. renderers).
 
Our initial concerns lied with apps grabbing capture when they didn't actually require it. The restriction for having an interaction was to ensure that the user was actively working with the app. We didn't go over the use case you mentioned.

I'm fine removing this restriction, as long as we keep the restriction that the app be visible. That way a user sees the interaction occurring.

I'd be okay with restricting it from embedded apps as well.
Components: Internals>MUS
Labels: Proj-Mustash
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 5 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS

Comment 6 by e...@chromium.org, Mar 9 2018

Cc: -e...@chromium.org
Un-cc-ing me from all bugs on my final day.
Labels: -Proj-Mustash Proj-Mash-SingleProcess
Status: Available (was: Untriaged)
Labels: -Pri-3 Pri-2
Renderers (currently) don't need capture. For the time being I think we should disallow it for ConnectionType::kEmbedding.
Owner: sky@chromium.org
Status: Started (was: Available)
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47f53f436bef696450921bd1f19ce3888b3640d4

commit 47f53f436bef696450921bd1f19ce3888b3640d4
Author: Scott Violet <sky@chromium.org>
Date: Tue Sep 25 03:45:15 2018

window-service: disallow capture with kEmbedFlagEmbedderInterceptsEvents

This is primarily to prevent a bad renderer from forcing capture.

BUG= 621234 
TEST=none

Change-Id: I66475bff12f260f8adaf95c1ee0d65d3931bf58d
Reviewed-on: https://chromium-review.googlesource.com/1241834
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593817}
[modify] https://crrev.com/47f53f436bef696450921bd1f19ce3888b3640d4/services/ws/window_tree.cc
[modify] https://crrev.com/47f53f436bef696450921bd1f19ce3888b3640d4/services/ws/window_tree.h
[modify] https://crrev.com/47f53f436bef696450921bd1f19ce3888b3640d4/services/ws/window_tree_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment