New issue
Advanced search Search tips

Issue 621223 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 563721



Sign in to add a comment

[People] Add Special Disconnect dialog for Managed Profiles

Project Member Reported by tommycli@chromium.org, Jun 17 2016

Issue description

Managed profiles currently have the same dialog as unmanaged profiles.

They need a different one as specified by the mocks.
 
Labels: Hotlist-MD-Settings-People
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d05058f45ac24c192143f721572339af69f0acd

commit 3d05058f45ac24c192143f721572339af69f0acd
Author: tommycli <tommycli@chromium.org>
Date: Thu Jun 30 00:01:05 2016

Settings People Revamp: Add special Disconnect logic for domain profiles

Disconnecting a profile with a domain, i.e. "managed by google.com"
should force the user to delete the local profile.

BUG= 621223 ,563721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2102803002
Cr-Commit-Position: refs/heads/master@{#403001}

[modify] https://crrev.com/3d05058f45ac24c192143f721572339af69f0acd/chrome/app/settings_chromium_strings.grdp
[modify] https://crrev.com/3d05058f45ac24c192143f721572339af69f0acd/chrome/app/settings_google_chrome_strings.grdp
[modify] https://crrev.com/3d05058f45ac24c192143f721572339af69f0acd/chrome/app/settings_strings.grdp
[modify] https://crrev.com/3d05058f45ac24c192143f721572339af69f0acd/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/3d05058f45ac24c192143f721572339af69f0acd/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/3d05058f45ac24c192143f721572339af69f0acd/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/3d05058f45ac24c192143f721572339af69f0acd/chrome/browser/ui/webui/settings/people_handler.cc
[modify] https://crrev.com/3d05058f45ac24c192143f721572339af69f0acd/chrome/test/data/webui/settings/people_page_test.js

Status: Fixed (was: Assigned)
Labels: TE-Verified-M53 TE-Verified-53.0.2785.8
Verified the issue on Mac 10.11.5,Ubuntu 14.04 and Win 7 using 53.0.2785.8 and its working fine as per the mock on Issue 563721.
621223_July_7.mp4
423 KB View Download

Sign in to add a comment