New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 621221 link

Starred by 2 users
Status: Fixed
Owner:
bsep@chromium.org
Closed: Jul 2016
Cc:
█ kavvaru@chromium.org
kylixrd@chromium.org
malaykeshav@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 605745
issue 613414



Sign in to add a comment

date picker too wide when use-zoom-for-dsf is on

Project Member Reported by bsep@chromium.org, Jun 17 2016 
Version: 53.0.2770.0 (Official Build) canary (64-bit)
OS: Windows 10

The date picker is too wide when use-zoom-for-dsf is on. It's supposed to be the same width as the input element, but at 2x dsf it looks like it's 100% too wide. See the attached screenshot.

For an example look at the layout test fast/hidpi/static/data-suggestion-picker-appearance.html, which contains this element:
<input type="date" id="date" value="10000-12-31" list="suggestions" style="width: 200px;">
date-picker-usezoom.PNG
38.2 KB View Download

Comment 1 by bsep@chromium.org, Jun 23 2016

Blocking: 613414
Owner: bsep@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e94f26e8f22e96fda6ade9ccb35380906ee77ab

commit 0e94f26e8f22e96fda6ade9ccb35380906ee77ab
Author: bsep <bsep@chromium.org>
Date: Fri Jul 01 02:36:42 2016

Fix date picker datalist suggestion dropdown size with use-zoom-for-dsf.

When a date picker has a suggestion list it's supposed to be the same
width as the input element. With use-zoom-for-dsf on I discovered that
it was too wide because the width that was being passed in was using
"root frame" coords that were not scaled correctly.

BUG= 621221 

Review-Url: https://codereview.chromium.org/2095113002
Cr-Commit-Position: refs/heads/master@{#403394}

[modify] https://crrev.com/0e94f26e8f22e96fda6ade9ccb35380906ee77ab/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/0e94f26e8f22e96fda6ade9ccb35380906ee77ab/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
[modify] https://crrev.com/0e94f26e8f22e96fda6ade9ccb35380906ee77ab/third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp
[modify] https://crrev.com/0e94f26e8f22e96fda6ade9ccb35380906ee77ab/third_party/WebKit/Source/core/html/forms/DateTimeChooser.h
[modify] https://crrev.com/0e94f26e8f22e96fda6ade9ccb35380906ee77ab/third_party/WebKit/Source/web/DateTimeChooserImpl.cpp
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18124bdd33246b22593292188c2c15b060bf3c9e

commit 18124bdd33246b22593292188c2c15b060bf3c9e
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Fri Jul 01 03:54:56 2016

Auto-rebaseline for r403394

https://chromium.googlesource.com/chromium/src/+/0e94f26e8

BUG= 621221 
TBR=bsep@chromium.org

Review URL: https://codereview.chromium.org/2112203002 .

Cr-Commit-Position: refs/heads/master@{#403406}

[modify] https://crrev.com/18124bdd33246b22593292188c2c15b060bf3c9e/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/34cd52f2597a5663901f27ca6e7f9dacb5bc2fd2/third_party/WebKit/LayoutTests/platform/linux-precise/virtual/scalefactor200withzoom/fast/hidpi/static/data-suggestion-picker-appearance-expected.png
[modify] https://crrev.com/18124bdd33246b22593292188c2c15b060bf3c9e/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200withzoom/fast/hidpi/static/data-suggestion-picker-appearance-expected.png
[modify] https://crrev.com/18124bdd33246b22593292188c2c15b060bf3c9e/third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor200withzoom/fast/hidpi/static/data-suggestion-picker-appearance-expected.png
[delete] https://crrev.com/34cd52f2597a5663901f27ca6e7f9dacb5bc2fd2/third_party/WebKit/LayoutTests/platform/win7/virtual/scalefactor200withzoom/fast/hidpi/static/data-suggestion-picker-appearance-expected.png

Comment 4 by bsep@chromium.org, Jul 6 2016

Labels: Merge-Request-53

Comment 5 by dimu@google.com, Jul 6 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 6 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d0823f5455d1a2918b764006a7dad26106bfc5e

commit 2d0823f5455d1a2918b764006a7dad26106bfc5e
Author: Bret Sepulveda <bsep@chromium.org>
Date: Wed Jul 06 18:06:48 2016

Fix date picker datalist suggestion dropdown size with use-zoom-for-dsf.

When a date picker has a suggestion list it's supposed to be the same
width as the input element. With use-zoom-for-dsf on I discovered that
it was too wide because the width that was being passed in was using
"root frame" coords that were not scaled correctly.

BUG= 621221 

Review-Url: https://codereview.chromium.org/2095113002
Cr-Commit-Position: refs/heads/master@{#403394}
(cherry picked from commit 0e94f26e8f22e96fda6ade9ccb35380906ee77ab)

Review URL: https://codereview.chromium.org/2128613002 .

Cr-Commit-Position: refs/branch-heads/2785@{#32}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/2d0823f5455d1a2918b764006a7dad26106bfc5e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/2d0823f5455d1a2918b764006a7dad26106bfc5e/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
[modify] https://crrev.com/2d0823f5455d1a2918b764006a7dad26106bfc5e/third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp
[modify] https://crrev.com/2d0823f5455d1a2918b764006a7dad26106bfc5e/third_party/WebKit/Source/core/html/forms/DateTimeChooser.h
[modify] https://crrev.com/2d0823f5455d1a2918b764006a7dad26106bfc5e/third_party/WebKit/Source/web/DateTimeChooserImpl.cpp
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e672c3a2d43edb8a839c5d141278d38fd57eea3a

commit e672c3a2d43edb8a839c5d141278d38fd57eea3a
Author: Bret Sepulveda <bsep@chromium.org>
Date: Wed Jul 06 18:12:21 2016

Auto-rebaseline for r403394

https://chromium.googlesource.com/chromium/src/+/0e94f26e8

BUG= 621221 
TBR=bsep@chromium.org

Review URL: https://codereview.chromium.org/2112203002 .

Cr-Commit-Position: refs/heads/master@{#403406}
(cherry picked from commit 18124bdd33246b22593292188c2c15b060bf3c9e)

Review URL: https://codereview.chromium.org/2130483002 .

Cr-Commit-Position: refs/branch-heads/2785@{#33}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/e672c3a2d43edb8a839c5d141278d38fd57eea3a/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/2d0823f5455d1a2918b764006a7dad26106bfc5e/third_party/WebKit/LayoutTests/platform/linux-precise/virtual/scalefactor200withzoom/fast/hidpi/static/data-suggestion-picker-appearance-expected.png
[modify] https://crrev.com/e672c3a2d43edb8a839c5d141278d38fd57eea3a/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200withzoom/fast/hidpi/static/data-suggestion-picker-appearance-expected.png
[modify] https://crrev.com/e672c3a2d43edb8a839c5d141278d38fd57eea3a/third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor200withzoom/fast/hidpi/static/data-suggestion-picker-appearance-expected.png
[delete] https://crrev.com/2d0823f5455d1a2918b764006a7dad26106bfc5e/third_party/WebKit/LayoutTests/platform/win7/virtual/scalefactor200withzoom/fast/hidpi/static/data-suggestion-picker-appearance-expected.png

Comment 8 by bsep@chromium.org, Jul 6 2016

Status: Fixed (was: Assigned)

Comment 9 by kavvaru@chromium.org, Jul 7 2016

Cc: kavvaru@chromium.org
Labels: Needs-Feedback
Tested the issue on windows 10(HighDPI) using chrome version 53.0.2785.8 with the below steps

1. Enabled the flag use-zoom-for-dsf from chrome://flags
2. Opened the html file with the code snippet from comment#0
3.Clicked on date arrow button
4.Observed different date picker overlay

Please find the attached screen shot and confirm anything missed here.
Please provide us any sample html file to verify the issue from test team end.

Thanks,
621221.png
151 KB View Download

Comment 10 by bsep@chromium.org, Jul 7 2016 

Apologizes for the confusing repro information. The date picker needs a datalist suggestion element. I've attached an HTML file that should show it off.
date-picker.html
291 bytes View Download
►

Sign in to add a comment