New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 621212 link

Starred by 1 user
Status: Fixed
Owner:
█ ntang@chromium.org
Last visit > 30 days ago
Closed: Sep 2016
Cc:
█ jean@chromium.org
█ autumn@chromium.org
█ sbasi@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Moblab does not honor the results_storage_server parameter

Project Member Reported by ntang@google.com, Jun 17 2016 
The moblab does not honor results_storage_server parameter in the configuration file. It explicitely use the image_storage_server to store bucket. This could be very confusing to the users. Instead, we should only use image_storage_server bucket if results_storage_server is empty.
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 18 2016

Labels: Hotlist-Google

Comment 2 by sbasi@chromium.org, Jun 20 2016 

How do you want to address this?

Comment 3 by ntang@google.com, Jun 20 2016 

Feels like by default, image_storage_server and results_storage_server should point to the same bucket for Moblab users. But when the users chaneg the results_storage_server intentionally, we should honor the setting.

Comment 4 by ntang@google.com, Jun 25 2016

Owner: ntang@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0a30d467b58126b10589cad8be448ebe4f5a530b

commit 0a30d467b58126b10589cad8be448ebe4f5a530b
Author: Michael Tang <ntang@google.com>
Date: Mon Jun 27 18:44:04 2016

Honor the results_storage_server parameter in moblab.

By default, the results_storage_server in global_config.ini is empty
now. Both lab and moblab could set the value and take effect. If not
set, the lab takes the original default value, and moblab takes the
image bucket uri.

BUG= chromium:621212 
TEST=unit test.

Change-Id: Ifd712b53bcffa76af17db8cd4d87947323291b08
Reviewed-on: https://chromium-review.googlesource.com/356126
Commit-Ready: Michael Tang <ntang@chromium.org>
Tested-by: Michael Tang <ntang@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>

[modify] https://crrev.com/0a30d467b58126b10589cad8be448ebe4f5a530b/frontend/client/src/autotest/public/afeclient.css
[modify] https://crrev.com/0a30d467b58126b10589cad8be448ebe4f5a530b/frontend/afe/site_rpc_interface.py
[modify] https://crrev.com/0a30d467b58126b10589cad8be448ebe4f5a530b/frontend/afe/site_rpc_interface_unittest.py
[modify] https://crrev.com/0a30d467b58126b10589cad8be448ebe4f5a530b/contrib/show_offload_failures
[modify] https://crrev.com/0a30d467b58126b10589cad8be448ebe4f5a530b/moblab_config.ini
[modify] https://crrev.com/0a30d467b58126b10589cad8be448ebe4f5a530b/client/common_lib/site_utils_unittest.py
[modify] https://crrev.com/0a30d467b58126b10589cad8be448ebe4f5a530b/client/common_lib/site_utils.py
[modify] https://crrev.com/0a30d467b58126b10589cad8be448ebe4f5a530b/frontend/client/src/autotest/moblab/wizard/CloudStorageCard.java
[modify] https://crrev.com/0a30d467b58126b10589cad8be448ebe4f5a530b/frontend/client/src/autotest/moblab/rpc/CloudStorageInfo.java
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 20 2016

Labels: merge-merged-release-R53-8530.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f27c812fd65ecc7c7f8621c9f9da7f8d8f969a96

commit f27c812fd65ecc7c7f8621c9f9da7f8d8f969a96
Author: Michael Tang <ntang@google.com>
Date: Mon Jun 27 18:44:04 2016

Honor the results_storage_server parameter in moblab.

By default, the results_storage_server in global_config.ini is empty
now. Both lab and moblab could set the value and take effect. If not
set, the lab takes the original default value, and moblab takes the
image bucket uri.

BUG= chromium:621212 
TEST=unit test.

Change-Id: Ifd712b53bcffa76af17db8cd4d87947323291b08
Reviewed-on: https://chromium-review.googlesource.com/356126
Commit-Ready: Michael Tang <ntang@chromium.org>
Tested-by: Michael Tang <ntang@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/386992
Trybot-Ready: Michael Tang <ntang@chromium.org>
Commit-Queue: Michael Tang <ntang@chromium.org>

[modify] https://crrev.com/f27c812fd65ecc7c7f8621c9f9da7f8d8f969a96/frontend/client/src/autotest/public/afeclient.css
[modify] https://crrev.com/f27c812fd65ecc7c7f8621c9f9da7f8d8f969a96/frontend/afe/site_rpc_interface.py
[modify] https://crrev.com/f27c812fd65ecc7c7f8621c9f9da7f8d8f969a96/frontend/afe/site_rpc_interface_unittest.py
[modify] https://crrev.com/f27c812fd65ecc7c7f8621c9f9da7f8d8f969a96/contrib/show_offload_failures
[modify] https://crrev.com/f27c812fd65ecc7c7f8621c9f9da7f8d8f969a96/client/common_lib/site_utils_unittest.py
[modify] https://crrev.com/f27c812fd65ecc7c7f8621c9f9da7f8d8f969a96/client/common_lib/site_utils.py
[modify] https://crrev.com/f27c812fd65ecc7c7f8621c9f9da7f8d8f969a96/frontend/client/src/autotest/moblab/wizard/CloudStorageCard.java
[modify] https://crrev.com/f27c812fd65ecc7c7f8621c9f9da7f8d8f969a96/frontend/client/src/autotest/moblab/rpc/CloudStorageInfo.java

Comment 7 by ntang@google.com, Sep 20 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment