Rename BlobChannelService to something that doesn't use the word "service" |
||||||
Issue descriptionben@ on chromium-dev proposed this naming convention for Mojo interfaces: "TL;DR: You should only use the *Service suffix if the object implementing the interface binds multiple pipes (e.g. using mojo::BindingSet) to multiple connected clients." BlobChannelService does not qualify. Update BlobChannelService to interface with multiple requests, meaning the BlobChannelSender will now interact with just one BlobChannelService.
,
Jun 20 2016
,
Jun 30 2016
,
Jul 21 2016
,
Aug 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a2db3214e124e79496ff3d7123b7d9813694532 commit 7a2db3214e124e79496ff3d7123b7d9813694532 Author: lethalantidote <lethalantidote@chromium.org> Date: Tue Aug 16 23:34:04 2016 BlobChannelService is modified to be Mojo Service. BlobChannelService is made to be a Mojo Service, and now keeps a 1:many relationship between itself and requests. BUG= 621202 Review-Url: https://codereview.chromium.org/2189503004 Cr-Commit-Position: refs/heads/master@{#412374} [modify] https://crrev.com/7a2db3214e124e79496ff3d7123b7d9813694532/blimp/engine/BUILD.gn [modify] https://crrev.com/7a2db3214e124e79496ff3d7123b7d9813694532/blimp/engine/app/blimp_browser_main_parts.cc [modify] https://crrev.com/7a2db3214e124e79496ff3d7123b7d9813694532/blimp/engine/app/blimp_browser_main_parts.h [modify] https://crrev.com/7a2db3214e124e79496ff3d7123b7d9813694532/blimp/engine/app/blimp_content_browser_client.cc [modify] https://crrev.com/7a2db3214e124e79496ff3d7123b7d9813694532/blimp/engine/mojo/blob_channel_service.cc [modify] https://crrev.com/7a2db3214e124e79496ff3d7123b7d9813694532/blimp/engine/mojo/blob_channel_service.h [modify] https://crrev.com/7a2db3214e124e79496ff3d7123b7d9813694532/blimp/engine/renderer/blob_channel_sender_proxy_unittest.cc [modify] https://crrev.com/7a2db3214e124e79496ff3d7123b7d9813694532/blimp/engine/session/blimp_engine_session.cc [modify] https://crrev.com/7a2db3214e124e79496ff3d7123b7d9813694532/blimp/engine/session/blimp_engine_session.h
,
Aug 17 2016
,
Dec 9 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by w...@chromium.org
, Jun 20 2016Summary: Rename BlobChannelService to something that doesn't use the word "service" (was: Rename BlobChannelService to something that doesn't use the word)