New issue
Advanced search Search tips

Issue 621139 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Devices at 1.25x scale initially render tabs wrong

Project Member Reported by abodenha@chromium.org, Jun 17 2016

Issue description

Chrome OS Version  :  8350.21.1 / 52.0.2743.32
13" FHD devices

What steps will reproduce the problem?
1. log in
2. @ NTP open some new tabs
3. Change resolution (Ctrl-Shift-+) to 1536x864

What is the expected output?

No jaggy diagonals on tabstrip tabs.

What do you see instead?

Diagonals for background tabs on the tabstrip are jagged.
The diagonals are straight for the foreground tab, and for any background tab under the pointer.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)

Always.

 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 18 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by osh...@chromium.org, Jun 18 2016

Labels: -Pri-1 Pri-2
There is a known issue that happen when you switch. I don't think this is P1.

Comment 3 by osh...@chromium.org, Jun 18 2016

Blocking: -485650
Also this is unrelated to crbug.com/485650.
Owner: glevin@chromium.org
glevin@ can you take a look at this one? oshima@ knows what needs to be done.
Status: Started (was: Assigned)
See attached for before (bad) and after (good) results.
tabs_before.png
10.0 KB View Download
tabs_after.png
7.1 KB View Download
Components: UI>Browser>TabStrip
Labels: -MovedFrom-52 Proj-MaterialDesign-NativeUI OS-Chrome OS-Linux OS-Windows
Project Member

Comment 7 by sheriffbot@chromium.org, Jul 4 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/875add8fab36691c4bb5a32fbc503e986e07b743

commit 875add8fab36691c4bb5a32fbc503e986e07b743
Author: glevin <glevin@chromium.org>
Date: Thu Jul 14 23:15:53 2016

Move private static members and methods into namespace

BUG= 621139 

This is in preparation for https://codereview.chromium.org/2118853002/,
which will also move PaintTabBackgroundUsingFillId() into namespace.
This CL is moving everything it depends on out of Tab.

Review-Url: https://codereview.chromium.org/2150013002
Cr-Commit-Position: refs/heads/master@{#405620}

[modify] https://crrev.com/875add8fab36691c4bb5a32fbc503e986e07b743/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/875add8fab36691c4bb5a32fbc503e986e07b743/chrome/browser/ui/views/tabs/tab.h

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c7ae812a813610568c15c2ed7b24cc4e605646f

commit 4c7ae812a813610568c15c2ed7b24cc4e605646f
Author: glevin <glevin@chromium.org>
Date: Tue Aug 09 18:23:23 2016

Make PaintTabBackgroundUsingFillId() non-method

BUG= 621139 

As per off-line request, I've separated part of
   https://codereview.chromium.org/2118853002/
into this CL.  This moves the main PaintTabBackgroundUsingFillId()
implementation into a non-method in anonymous namespace.  This CL contains
no functional changes, and is intended to make the functional changes in
the original CL easier to see.

Review-Url: https://codereview.chromium.org/2197613002
Cr-Commit-Position: refs/heads/master@{#410749}

[modify] https://crrev.com/4c7ae812a813610568c15c2ed7b24cc4e605646f/chrome/browser/ui/views/tabs/tab.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95fa21d0ddf262b7c22233c842513c09c9f15d06

commit 95fa21d0ddf262b7c22233c842513c09c9f15d06
Author: glevin <glevin@chromium.org>
Date: Wed Aug 17 23:33:54 2016

Revert previous CL making PaintTabBackgroundUsingFillId() a non-method

BUG= 621139 

In preparation for https://codereview.chromium.org/2118853002/, two other
CLs were landed first.  Because the main CL was abandoned in favor of a
simpler approach, we are reverting one of these two preparatory CLs:

https://codereview.chromium.org/2197613002/ made major changes to the
prototype of PaintTabBackgroundUsingFillId() in order to force it to be
a non-method.  These and some related changes are now unnecessary, and
are being reverted here.  NOTE: The revert was done manually, so other
subsequent changes should be preserved.

(NOTE: https://codereview.chromium.org/2150013002/ moved a number of
static members and methods of the Tab class into the anonymous namespace,
along with a few methods that were "mostly static".  These changes are
considered a general code improvement, and are being left alone.)

Review-Url: https://codereview.chromium.org/2255823002
Cr-Commit-Position: refs/heads/master@{#412691}

[modify] https://crrev.com/95fa21d0ddf262b7c22233c842513c09c9f15d06/chrome/browser/ui/views/tabs/tab.cc

Status: Fixed (was: Started)
This issue was actually fixed by https://codereview.chromium.org/2246213003/ between Comments 9 and 10, but bugdroid didn't post a comment when the change landed.  I expect it would've looked something like this <puts on bugdroid hat...>:


The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e99b9c69a63d7857dd397ae2e488a16cc8e7c48d

commit e99b9c69a63d7857dd397ae2e488a16cc8e7c48d
Author: glevin <glevin@chromium.org>
Date: Tue Aug 16 14:43:16 2016

Fix pixelation of tab borders when device scale changes (alternate approach)

BUG= 621139 
TEST=Open browser, change device resolution (CTRL+SHIFT+ +/-), observe
quality of inactive tab borders.

Note that this is a simpler fix than
https://codereview.chromium.org/2118853002/
(assuming it's valid)

Review-Url: https://codereview.chromium.org/2246213003
Cr-Commit-Position: refs/heads/master@{#412234}

[modify] https://crrev.com/e99b9c69a63d7857dd397ae2e488a16cc8e7c48d/chrome/browser/ui/views/tabs/tab.cc
Status: Verified (was: Fixed)

Sign in to add a comment