Devices at 1.25x scale initially render tabs wrong |
||||||||
Issue descriptionChrome OS Version : 8350.21.1 / 52.0.2743.32 13" FHD devices What steps will reproduce the problem? 1. log in 2. @ NTP open some new tabs 3. Change resolution (Ctrl-Shift-+) to 1536x864 What is the expected output? No jaggy diagonals on tabstrip tabs. What do you see instead? Diagonals for background tabs on the tabstrip are jagged. The diagonals are straight for the foreground tab, and for any background tab under the pointer. How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always.
,
Jun 18 2016
There is a known issue that happen when you switch. I don't think this is P1.
,
Jun 18 2016
,
Jun 24 2016
glevin@ can you take a look at this one? oshima@ knows what needs to be done.
,
Jul 1 2016
See attached for before (bad) and after (good) results.
,
Jul 1 2016
,
Jul 4 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/875add8fab36691c4bb5a32fbc503e986e07b743 commit 875add8fab36691c4bb5a32fbc503e986e07b743 Author: glevin <glevin@chromium.org> Date: Thu Jul 14 23:15:53 2016 Move private static members and methods into namespace BUG= 621139 This is in preparation for https://codereview.chromium.org/2118853002/, which will also move PaintTabBackgroundUsingFillId() into namespace. This CL is moving everything it depends on out of Tab. Review-Url: https://codereview.chromium.org/2150013002 Cr-Commit-Position: refs/heads/master@{#405620} [modify] https://crrev.com/875add8fab36691c4bb5a32fbc503e986e07b743/chrome/browser/ui/views/tabs/tab.cc [modify] https://crrev.com/875add8fab36691c4bb5a32fbc503e986e07b743/chrome/browser/ui/views/tabs/tab.h
,
Aug 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c7ae812a813610568c15c2ed7b24cc4e605646f commit 4c7ae812a813610568c15c2ed7b24cc4e605646f Author: glevin <glevin@chromium.org> Date: Tue Aug 09 18:23:23 2016 Make PaintTabBackgroundUsingFillId() non-method BUG= 621139 As per off-line request, I've separated part of https://codereview.chromium.org/2118853002/ into this CL. This moves the main PaintTabBackgroundUsingFillId() implementation into a non-method in anonymous namespace. This CL contains no functional changes, and is intended to make the functional changes in the original CL easier to see. Review-Url: https://codereview.chromium.org/2197613002 Cr-Commit-Position: refs/heads/master@{#410749} [modify] https://crrev.com/4c7ae812a813610568c15c2ed7b24cc4e605646f/chrome/browser/ui/views/tabs/tab.cc
,
Aug 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95fa21d0ddf262b7c22233c842513c09c9f15d06 commit 95fa21d0ddf262b7c22233c842513c09c9f15d06 Author: glevin <glevin@chromium.org> Date: Wed Aug 17 23:33:54 2016 Revert previous CL making PaintTabBackgroundUsingFillId() a non-method BUG= 621139 In preparation for https://codereview.chromium.org/2118853002/, two other CLs were landed first. Because the main CL was abandoned in favor of a simpler approach, we are reverting one of these two preparatory CLs: https://codereview.chromium.org/2197613002/ made major changes to the prototype of PaintTabBackgroundUsingFillId() in order to force it to be a non-method. These and some related changes are now unnecessary, and are being reverted here. NOTE: The revert was done manually, so other subsequent changes should be preserved. (NOTE: https://codereview.chromium.org/2150013002/ moved a number of static members and methods of the Tab class into the anonymous namespace, along with a few methods that were "mostly static". These changes are considered a general code improvement, and are being left alone.) Review-Url: https://codereview.chromium.org/2255823002 Cr-Commit-Position: refs/heads/master@{#412691} [modify] https://crrev.com/95fa21d0ddf262b7c22233c842513c09c9f15d06/chrome/browser/ui/views/tabs/tab.cc
,
Aug 18 2016
This issue was actually fixed by https://codereview.chromium.org/2246213003/ between Comments 9 and 10, but bugdroid didn't post a comment when the change landed. I expect it would've looked something like this <puts on bugdroid hat...>: The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e99b9c69a63d7857dd397ae2e488a16cc8e7c48d commit e99b9c69a63d7857dd397ae2e488a16cc8e7c48d Author: glevin <glevin@chromium.org> Date: Tue Aug 16 14:43:16 2016 Fix pixelation of tab borders when device scale changes (alternate approach) BUG= 621139 TEST=Open browser, change device resolution (CTRL+SHIFT+ +/-), observe quality of inactive tab borders. Note that this is a simpler fix than https://codereview.chromium.org/2118853002/ (assuming it's valid) Review-Url: https://codereview.chromium.org/2246213003 Cr-Commit-Position: refs/heads/master@{#412234} [modify] https://crrev.com/e99b9c69a63d7857dd397ae2e488a16cc8e7c48d/chrome/browser/ui/views/tabs/tab.cc
,
Oct 20 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by sheriffbot@chromium.org
, Jun 18 2016