Don't send videos with an alpha channel to the hardware decoder. |
|||||||
Issue descriptionvp8a and vp9a are special formats only supported by the software decoder.
,
Jun 21 2016
This landed as https://codereview.chromium.org/2077023002 but is not showing up as a commit for some reason. Merge-Request for 52.
,
Jun 22 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 22 2016
I have tested the page given in the TEST section of the CL https://codereview.chromium.org/2077023002 OS --> Win7/64 bit Build --> Version 53.0.2774.3 canary (64-bit) Verified the following: 1. Able to drag a video on to the page. 2. Double clicking on the 2 images shown default on the page shows animation. Double clicking on a new video which was dragged on to this page does nothing other than just playing the video. 3. Double clicking on the default page background to swap between an image & video shows another video playing along with the 2 other images on the page. 4. Resizing the window resizes the video. But i see some color change at the bottom of the window. Please find the attached screen shots. 5. Selecting the video background color changes the video color. dalecurtis@, Can you please confirm the expected behavior?
,
Jun 22 2016
Dale, Wasn't this change intended for android? (i doubt if there are any windows devices at all that has the vp8 hardware decoder - so this CL wouldn't have changed the behavior on those devices). pucchakayala@, can you please confirm the exact model of laptop that you tried it in? i really doubt if it has a vp8 hardware decoder.
,
Jun 22 2016
That page is working correctly (it doesn't resize correctly), but yes it's only intended for android. If it wasn't working you'd see boxes around the dancing characters. So the screenshots are correct.
,
Jun 22 2016
I have tested this on Win 7 Enterprise corp desktop machine. If the change is intended only for Android, can you please change the OS label accordingly ?
,
Jun 22 2016
Technically it affects all platforms, but Android is the only platform with a hardware vp8/vp9 decoder, so sure.
,
Jun 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23a0e1edad1a1bcedb54ed9f961a810fb32168d0 commit 23a0e1edad1a1bcedb54ed9f961a810fb32168d0 Author: Dale Curtis <dalecurtis@chromium.org> Date: Wed Jun 22 23:55:30 2016 Merge M52: "GpuVideoDecoder should reject playback of videos with alpha channel." This channel is not decoded by the hardware decoder, so we should force these to fallback to software decoding. BUG= 621135 TEST=http://simpl.info/videoalpha Review-Url: https://codereview.chromium.org/2077023002 Cr-Commit-Position: refs/heads/master@{#400477} (cherry picked from commit 6a4d01c7fda0bf54c847ee1198a3a3e4670f8e27) Review URL: https://codereview.chromium.org/2086263003 . Cr-Commit-Position: refs/branch-heads/2743@{#450} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/23a0e1edad1a1bcedb54ed9f961a810fb32168d0/media/filters/gpu_video_decoder.cc
,
Jun 23 2016
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sheriffbot@chromium.org
, Jun 18 2016