New issue
Advanced search Search tips

Issue 621133 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Change Should.beCloseToArray to produce verbose output by default.

Project Member Reported by rtoy@chromium.org, Jun 17 2016 
Should.beCloseToArray currently produces a brief output on test failure.  It would be much better if the default were verbose output which provide much more information on the failure and gives the max absolute and relative errors.

When tests fail, you pretty much have to enable verbose output to understand the failure anyway, so might as well make it the default.  There's no harm since this verbose output only happens on failure.

We probably don't want to change verbose to default to true.  We probably want to remove verbose and replace it with brief (or similar name?), defaulting to false.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16f82ada8daa42e620e84801ed527733d732b0cb

commit 16f82ada8daa42e620e84801ed527733d732b0cb
Author: rtoy <rtoy@chromium.org>
Date: Thu Jul 07 03:18:47 2016

Replace verbose option with brief option for Should().

By default, Should() will produce verbose output on failure for
beCloseToArray(). This also changes beLessThanOrEqual and
beGreaterThanOrEqual to print out the actual value.

This is not wanted usually for beLessThan/beGreaterThan (because the
actual value might depend on the platform).  Thus, go through existing
tests and add brief:true to them and also remove verbose:true
everywhere.

Manually tested several cases by forcing the tests to fail to see that
the desired failure text is printed.

BUG= 621133 
TESTS=tests updated and manual spot checks done

Review-Url: https://codereview.chromium.org/2072313002
Cr-Commit-Position: refs/heads/master@{#404060}

[modify] https://crrev.com/16f82ada8daa42e620e84801ed527733d732b0cb/third_party/WebKit/LayoutTests/webaudio/audiolistener-automation-position.html
[modify] https://crrev.com/16f82ada8daa42e620e84801ed527733d732b0cb/third_party/WebKit/LayoutTests/webaudio/audioparam-automation-clamping.html
[modify] https://crrev.com/16f82ada8daa42e620e84801ed527733d732b0cb/third_party/WebKit/LayoutTests/webaudio/audioparam-setTargetAtTime-continuous.html
[modify] https://crrev.com/16f82ada8daa42e620e84801ed527733d732b0cb/third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-duration.html
[modify] https://crrev.com/16f82ada8daa42e620e84801ed527733d732b0cb/third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurveAtTime-interpolation.html
[modify] https://crrev.com/16f82ada8daa42e620e84801ed527733d732b0cb/third_party/WebKit/LayoutTests/webaudio/iirfilter.html
[modify] https://crrev.com/16f82ada8daa42e620e84801ed527733d732b0cb/third_party/WebKit/LayoutTests/webaudio/osc-low-freq.html
[modify] https://crrev.com/16f82ada8daa42e620e84801ed527733d732b0cb/third_party/WebKit/LayoutTests/webaudio/osc-negative-freq.html
[modify] https://crrev.com/16f82ada8daa42e620e84801ed527733d732b0cb/third_party/WebKit/LayoutTests/webaudio/panner-automation-position.html
[modify] https://crrev.com/16f82ada8daa42e620e84801ed527733d732b0cb/third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-byte-data.html
[modify] https://crrev.com/16f82ada8daa42e620e84801ed527733d732b0cb/third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-downmix.html
[modify] https://crrev.com/16f82ada8daa42e620e84801ed527733d732b0cb/third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-freq-data-smoothing.html
[modify] https://crrev.com/16f82ada8daa42e620e84801ed527733d732b0cb/third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-freq-data.html
[modify] https://crrev.com/16f82ada8daa42e620e84801ed527733d732b0cb/third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js

Comment 2 by rtoy@chromium.org, Jul 13 2016

Owner: rtoy@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment