New issue
Advanced search Search tips

Issue 621124 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 525752
issue 354261
issue 621677



Sign in to add a comment

syzygy failure on official gn builds

Project Member Reported by brucedaw...@chromium.org, Jun 17 2016

Issue description

When doing official gn builds on my local machine I consistently hit syzygy errors on chrome.dll and chrome_child.dll. Typical errors look like this:

FAILED: syzygy/chrome.dll syzygy/chrome.dll.pdb 
C:/src/depot_tools/python276_bin/python.exe ../../chrome/tools/build/win/syzygy/reorder.py --input_executable chrome.dll --input_symbol chrome.dll.pdb --destination_dir syzygy
INFO:root:Randomly reordering "chrome.dll"
INFO:root:Running command "('../../chrome/tools/build/win/syzygy\\../../../../..\\third_party/syzygy/binaries/exe/relink.exe', '--overwrite', '--input-image=chrome.dll', '--input-pdb=chrome.dll.pdb', '--output-image=C:\\src\\chromium3\\src\\out\\gn\\syzygy\\chrome.dll', '--output-pdb=C:\\src\\chromium3\\src\\out\\gn\\syzygy\\chrome.dll.pdb', '--seed=1347344')".
[0617/013004:INFO:application_impl.h(46)] Syzygy Relinker Version 0.8.19.0 (da2c31c).
[0617/013004:INFO:application_impl.h(48)] Copyright (c) Google Inc. All rights reserved.
[0617/013004:INFO:pe_relinker.cc(138)] Input module : C:\src\chromium3\src\out\gn\chrome.dll
[0617/013004:INFO:pe_relinker.cc(139)] Input PDB    : C:\src\chromium3\src\out\gn\chrome.dll.pdb
[0617/013004:INFO:pe_relinker.cc(140)] Output module: C:\src\chromium3\src\out\gn\syzygy\chrome.dll
[0617/013004:INFO:pe_relinker.cc(141)] Output PDB   : C:\src\chromium3\src\out\gn\syzygy\chrome.dll.pdb
[0617/013004:INFO:pe_relinker.cc(57)] Decomposing module: C:\src\chromium3\src\out\gn\chrome.dll
[0617/013013:ERROR:decomposer.cc(310)] PDB file does not contain a FIXUP stream. Module must be linked with '/PROFILE' or '/DEBUGINFO:FIXUP' flag.
[0617/013013:ERROR:pe_relinker.cc(66)] Unable to decompose module: C:\src\chromium3\src\out\gn\chrome.dll
[0617/013013:ERROR:relink_app.cc(215)] Failed to initialize relinker.
Traceback (most recent call last):
  File "../../chrome/tools/build/win/syzygy/reorder.py", line 111, in <module>
    sys.exit(main(_ParseOptions()))
  File "../../chrome/tools/build/win/syzygy/reorder.py", line 83, in main
    options.destination_dir)
  File "../../chrome/tools/build/win/syzygy/reorder.py", line 67, in _ReorderBinary
    return _Shell(*cmd)
  File "../../chrome/tools/build/win/syzygy/reorder.py", line 33, in _Shell
    raise RuntimeError('Command "%s" returned %d.' % (cmd, prog.returncode))
RuntimeError: Command "('../../chrome/tools/build/win/syzygy\\../../../../..\\third_party/syzygy/binaries/exe/relink.exe', '--overwrite', '--input-image=chrome.dll', '--input-pdb=chrome.dll.pdb', '--output-image=C:\\src\\chromium3\\src\\out\\gn\\syzygy\\chrome.dll', '--output-pdb=C:\\src\\chromium3\\src\\out\\gn\\syzygy\\chrome.dll.pdb', '--seed=1347344')" returned 1.

The args.gn settings are:

target_cpu="x86"
is_debug=false
is_component_build=false
is_official_build = true

The equivalent GYP build (GYP_DEFINES=buildtype=Official) builds without errors. This is interfering with GYP/gn build comparison tests.

Not sure how to tag so assigning to someone who can triage or suggest the fix.

Presumably the problem is that the .gn files are setup incorrectly such that official does not automatically add the /PROFILE flag.

 
Blocking: 525752
Labels: -Pri-3 Pri-1
I'm working on this. You're right, the solution is to use the /PROFILE flag. 
Blocking: 621677 354261
Components: Build
Labels: M-53 Proj-GN-Migration
Labels: OS-Windows
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d9805722d2a7fd45ff5d1138c2fb2936f3e9de3

commit 3d9805722d2a7fd45ff5d1138c2fb2936f3e9de3
Author: sebmarchand <sebmarchand@chromium.org>
Date: Thu Jun 23 01:54:14 2016

Use the /PROFILE linker flag for the Windows GN builds.

Note that we're already using this flag for the GYP builds.

R=chrisha@chromium.org, brucedawson@chromium.org
BUG= 621124 

Review-Url: https://codereview.chromium.org/2087723003
Cr-Commit-Position: refs/heads/master@{#401517}

[modify] https://crrev.com/3d9805722d2a7fd45ff5d1138c2fb2936f3e9de3/build/config/win/BUILD.gn

Status: Fixed (was: Assigned)
This is theoretically fixed ...

Sign in to add a comment