Some ToolbarActionsBarBubbles need to have no default action |
|||||||||
Issue descriptionfor example, the one that confirms you wanted an extension to change the ntp
,
Jun 18 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 20 2016
,
Jun 20 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 20 2016
estade@, please have the CL merged in to M52 branch by EOD so that it gets picked up for beta promotion scheduled this week.
,
Jun 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/389f429ccbf0bddbc85a19abae863370f012c7cb commit 389f429ccbf0bddbc85a19abae863370f012c7cb Author: Evan Stade <estade@chromium.org> Date: Mon Jun 20 21:10:02 2016 Don't set a default action for ToolbarActionsBarBubbles. This isn't totally correct; some of these bubbles should have defaults and some should not. But this was the behavior previous to dc0d234f7c87 so the more conservative approach is to revert to the old behavior and later change/improve individual bubbles that should have defaults by adding them. This patch is designed to be easy/safe to merge to M52. BUG= 621122 Review-Url: https://codereview.chromium.org/2076993002 Cr-Commit-Position: refs/heads/master@{#400503} (cherry picked from commit 0013e8398ca2cb80185a08bcf14358bc4310b27a) Review URL: https://codereview.chromium.org/2084713002 . Cr-Commit-Position: refs/branch-heads/2743@{#412} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/389f429ccbf0bddbc85a19abae863370f012c7cb/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc [modify] https://crrev.com/389f429ccbf0bddbc85a19abae863370f012c7cb/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.h
,
Jun 20 2016
,
Jun 22 2016
estade@ Can this be verified manually so that we can verify this issue from test team end? Please provide us test steps or URL to verify. Thanks,
,
Jun 22 2016
privard@ should be able to verify and/or provide manual test steps
,
Jul 26 2016
Verified that the bubbles no longer have a default action set in M52. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Jun 17 2016