New issue
Advanced search Search tips

Issue 621119 link

Starred by 3 users

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Consider adding "inputs" to GN tool definitions

Project Member Reported by brettw@chromium.org, Jun 17 2016

Issue description

Some tools in GN toolchains are implemented via scripts. When the script changes, we want to call all of those actions out-of-date.

This could be implemented as the deps of a toolchain but that's very heavyweight, both conceptually (requiring a dummy setup toolchain and a separate file) and at runtime (dependency file gets added to every single build rule, the entuire build is invalidated when one tool changes).

For this case it would be better to have an "inputs" entry for individual tools that causes a dependency for every rule that the tool is used for on those files. Tools would list all the scripts and other inputs they require in this field.

Currently this is coming up because of the mac linker_driver tool, but is also theoretically present on everything implemented via gyp-*-tool.
 

Comment 1 by brettw@chromium.org, Jun 17 2016

Labels: Build-Tools-GN
Components: Tools
Components: -Tools Build
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 28 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment