New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 621108 link

Starred by 1 user
Status: Fixed
Owner:
█ mkwst@chromium.org
Buried. Ping if important.
Closed: Jun 2016
Cc:
pdr@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Presubmit checks for `js-test.js`.

Project Member Reported by mkwst@chromium.org, Jun 17 2016 
We should have a presubmit rule that fires on newly written `js-test.js`-based tests. `testharness.js` is the new hotness.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccdcf1d6a4b123d51fb7295d712bf9c37bd8785b

commit ccdcf1d6a4b123d51fb7295d712bf9c37bd8785b
Author: mkwst <mkwst@chromium.org>
Date: Wed Jun 22 21:23:11 2016

Deprecate 'js-test.js' with an overridable pre-upload check.

Throw a presubmit warning if a line containing 'resources/js-test.js'
appears inside a patch's modifications to //LayoutTests. Point developers
to 'testharness.js' instead.

BUG= 621108 
R=pdr@chromium.org

Review-Url: https://codereview.chromium.org/2080663004
Cr-Commit-Position: refs/heads/master@{#401409}

[modify] https://crrev.com/ccdcf1d6a4b123d51fb7295d712bf9c37bd8785b/third_party/WebKit/PRESUBMIT.py

Comment 2 by tkent@chromium.org, Jun 22 2016 

I support this direction.  Would you announce it on blink-dev please?

Comment 3 by mkwst@chromium.org, Jun 24 2016

Status: Fixed (was: Assigned)
tkent@: Will do!
►

Sign in to add a comment