New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621094 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Crash in CCodec_GifModule::LoadFrameInfo

Project Member Reported by ClusterFuzz, Jun 17 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6487512726110208

Fuzzer: libfuzzer_pdf_codec_gif_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000000
Crash State:
  CCodec_GifModule::LoadFrameInfo
  CCodec_ProgressiveDecoder::GetFrames
  XFACodecFuzzer::Fuzz
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=400121:400191

Minimized Testcase (0.00 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv957oM230j5O_Te5A2SY2QxSUXMLxl5Aw4lwhganZS4-bYMPuEYr3AiEO7K0nfJxTPZaW_AsNxgwfFGcmLcWnY2HKdilBW2xtuN02zgKwpfIiG6ajKV1cEkDOlmiAsNTB7-RmZU5TsqcYsDZ8T7_BOVLFw-UDw
G


Filer: mmoroz

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 

Comment 1 by mmoroz@chromium.org, Jun 17 2016

Cc: mmoroz@chromium.org kcc@chromium.org aizatsky@chromium.org
Components: Internals>Plugins>PDF
Cc: dsinclair@chromium.org och...@chromium.org
Looks like bSkipImageTypeCheck means we proceed with CCodec_ProgressiveDecoder::GetFrames() without ever going through CCodec_ProgressiveDecoder::DetectImageType() to initialize the gif context?
Owner: dsinclair@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 20 2016

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium.git/+/54d027dbbff8a0270531855082e4f61cb457c173

commit 54d027dbbff8a0270531855082e4f61cb457c173
Author: dsinclair <dsinclair@chromium.org>
Date: Mon Jun 20 16:09:56 2016

Fixup LoadImageInfo type checking.

The ::DetectImageType method does more then just detecting the image type, it
also sets up various needed structures to handle the decoding. Instead of
skipping the ::DetectImageType call this CL changes the code to return early if
the image check fails. This should allow us to stop working on images which do
not match the required data format.

BUG= chromium:621094 

Review-Url: https://codereview.chromium.org/2085493002

[modify] https://crrev.com/54d027dbbff8a0270531855082e4f61cb457c173/core/fxcodec/codec/fx_codec_progress.cpp

Status: Fixed (was: Started)
Is there a way to force clusterfuzz to try again off of HEAD so I can verify this is fixed?

Comment 6 by mmoroz@chromium.org, Jun 20 2016

dsinclair@, there is no way to do it.

Though you may run Redo "Fixed" job (the button is on the top of CF report page), but it will not use HEAD updated just a couple of minutes ago, because CF uses builds provided by build-bot (https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Linux%20ASan).

The good thing is that CF will update the bug description automatically once he will check the fix with a new build.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 20 2016

Project Member

Comment 8 by ClusterFuzz, Jun 21 2016

ClusterFuzz has detected this issue as fixed in range 400757:400887.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6487512726110208

Fuzzer: libfuzzer_pdf_codec_gif_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000000
Crash State:
  CCodec_GifModule::LoadFrameInfo
  CCodec_ProgressiveDecoder::GetFrames
  XFACodecFuzzer::Fuzz
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=400121:400191
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=400757:400887

Minimized Testcase (0.00 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv957oM230j5O_Te5A2SY2QxSUXMLxl5Aw4lwhganZS4-bYMPuEYr3AiEO7K0nfJxTPZaW_AsNxgwfFGcmLcWnY2HKdilBW2xtuN02zgKwpfIiG6ajKV1cEkDOlmiAsNTB7-RmZU5TsqcYsDZ8T7_BOVLFw-UDw?testcase_id=6487512726110208
G


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment