Remove DCHECK(IsEncryptionEstablished()) from QuicChromiumClientSession::OnConnectTimeout() |
|||
Issue description
Moving internal bug 28993134.
It is possible to get an incomplete reject from the server and hence end up timing out without encryption being re-established.
If that happens, the DCHECK(IsEncryptionEstablished()) will fail. This introduce a crash in debug builds.
void QuicChromiumClientSession::OnConnectTimeout() {
DCHECK(callback_.is_null());
DCHECK(IsEncryptionEstablished());
...
}
Suggestion is to remove the DCHECK.
,
Jun 17 2016
Agreed. Removing the DCHECK sounds right to me.
,
Jun 28 2016
,
Jun 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15315986badb434e679db773c1965336b626c448 commit 15315986badb434e679db773c1965336b626c448 Author: kapishnikov <kapishnikov@chromium.org> Date: Wed Jun 29 14:59:32 2016 Removed DCHECK(IsEncryptionEstablished()) BUG= 621091 Review-Url: https://codereview.chromium.org/2108553003 Cr-Commit-Position: refs/heads/master@{#402808} [modify] https://crrev.com/15315986badb434e679db773c1965336b626c448/net/quic/quic_chromium_client_session.cc
,
Jun 29 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by lisamill...@gmail.com
, Jun 17 2016