New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 621050 link

Starred by 2 users
Status: Verified
Owner:
msw@chromium.org
Closed: Jun 2016
Cc:
nyerramilli@chromium.org
█ m.pistr...@gmail.com
█ tkonch...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Focus highlight is stays 'Next' button even after tap/touch 'Previous' button in Find textbox.

Reported by jshan...@etouch.net, Jun 17 2016 
Chrome Version: 53.0.2770.0 (Official Build) 318e6f543c58eeeac93b122030041139da7e1e6a-refs/heads/master@{#400326}-32/64 bit
OS: Windows 10 (Touch device)

Steps:
1. Launch Chrome, go to NTP and Press 'Ctrl+F' key to open Find in page.
2. Type some letter like 'g' and press tab key until focus is on 'Next' button.
3. Now tap/touch on 'Previous' button and observe.

Actual: Focus highlight is stays on 'Next' button even after tap/touch on 'Previous' button.

Expected: Focus highlight should not stay on 'Next' button after tap/touch on 'Previous' button.

This is a regression issue broken in M-50, below is bisect info.

Good build: 50.0.2646.0
Bad build: 50.0.2647.0

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/ef3511f30c78a2e286c7dc427b2af18ec54cb0c9..f1777a5bee5a24d196deab700bf4c4a5e118a156?pretty=fuller&n=100

Suspecting: r374578 ?

Please help to re-assign if your change is not the cause for this issue.

Note: This is touch device specific issue, same works fine via mouse click.
Actual_video.mp4
664 KB View Download
Expected_video.mp4
398 KB View Download

Comment 1 by msw@chromium.org, Jun 17 2016

Labels: OS-Chrome
Status: Started (was: Assigned)
I can also repro on Chrome OS, but I'm not quite sure what should happen.
Prior to r374578, we would have focused the search textfield after tapping.
We can restore that; afaict, tapping controls doesn't makes them take focus in general.
(that CL just meant to keep focus on next/previous when continuously pressing [SPACE]/[ENTER])

Comment 2 by m.pistr...@gmail.com, Jun 19 2016 

I can take a look at this issue if it is decided that the current behavior should change. It does look strange that a button which is not tapped keeps the focus.

Comment 3 by msw@chromium.org, Jun 19 2016 

I have a WIP CL at https://codereview.chromium.org/2078953003/
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/098645c6ee78757f03819207645ff151b8edf01d

commit 098645c6ee78757f03819207645ff151b8edf01d
Author: msw <msw@chromium.org>
Date: Tue Jun 21 19:39:23 2016

Remove find bar focus redirection on mouse events.

Pressing next/previous buttons shouldn't change focus.
Focus was redirected to the textfield for  Issue 524373 .
That defect is no longer reproducible on ToT @ #400257.

Update and enable the interactive ui test.

BUG= 621050 , 584043 , 524373 
TEST=CTRL+F, 'a', TAB to focus previous button, touch/click next button, focus remains on previous button.
R=pkasting@chromium.org

Review-Url: https://codereview.chromium.org/2078953003
Cr-Commit-Position: refs/heads/master@{#401079}

[modify] https://crrev.com/098645c6ee78757f03819207645ff151b8edf01d/chrome/browser/ui/views/find_bar_host.h
[modify] https://crrev.com/098645c6ee78757f03819207645ff151b8edf01d/chrome/browser/ui/views/find_bar_view.cc
[modify] https://crrev.com/098645c6ee78757f03819207645ff151b8edf01d/chrome/browser/ui/views/find_bar_views_interactive_uitest.cc

Comment 5 by msw@chromium.org, Jun 21 2016

Status: Fixed (was: Started)
Peter and I decided that button use should *NOT* redirect focus to the textfield.
(that was the behavior prior to the  Issue 524373  workaround, seems most sane)

Comment 6 by pbath...@chromium.org, Jul 19 2016

Status: Verified (was: Fixed)
verified on 53.0.2785.15
►

Sign in to add a comment