New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621037 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 621028
issue 621034
issue 621035
issue 631964

Blocking:
issue 581716



Sign in to add a comment

Deprecate & remove TBMv1 memory metric

Project Member Reported by petrcermak@chromium.org, Jun 17 2016

Issue description

I suggest we:

  1. (now) Add a logging.warning and a #comment that the TBMv1 metric is
     now deprecated and will be removed in the near future. People
     should use the TBMv2 metric instead.

  2. (once issue 621028,  issue 621034  and  issue 621035  are fixed) Remove
     the TBMv1 metric from the codebase.
 
As Juan suggested in issue 621028, we should rename old (TBMv1) memory values across all benchmarks to the new TBMv2 structure (memory:<browser>:<process>:<source>:<component>:<size-property>, e.g. memory:chrome:renderer_processes:reported_by_os:system_memory:native_heap:private_dirty).
Blockedon: 631964
The last benchmark using the TBMv1 memory metric has just been switched (see  issue 621035 ). I propose we wait for a day or two (in case there's a revert or something) and then go ahead with removing the TBMv1 memory metric altogether.
Blocking: 581716
woot! sgtm
perezju: I think you can go ahead and remove the metric :-)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73a0a85430693ea5424c0b15707ed8a117ad21fb

commit 73a0a85430693ea5424c0b15707ed8a117ad21fb
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Fri Aug 19 01:31:18 2016

Roll src/third_party/catapult/ 56fe75e82..b1fb8ff42 (7 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/56fe75e82add..b1fb8ff42918

$ git log 56fe75e82..b1fb8ff42 --date=short --no-merges --format='%ad %ae %s'

BUG= 621037 

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2260043002
Cr-Commit-Position: refs/heads/master@{#413007}

[modify] https://crrev.com/73a0a85430693ea5424c0b15707ed8a117ad21fb/DEPS

Fixed?
Status: Fixed (was: Assigned)
Yep, in  issue 632021  I'll track the removal of the remainder things.

Sign in to add a comment