New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621034 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 581716
issue 621037



Sign in to add a comment

Switch memory.blink_memory_mobile to TBMv2 memory metric

Project Member Reported by petrcermak@chromium.org, Jun 17 2016

Issue description

Switch memory.blink_memory_mobile to the TBMv2 memory metric.

Rationale: The TBMv2 memory metric reports more detailed and accurate data. The TBMv1 memory metric (currently used by the benchmark) will be deprecated soon. Example:

  TBMv1: memory_allocated_objects_v8_renderer
  TBMv2: memory:chrome:renderer_processes:reported_by_chrome:v8:allocated_objects_size_avg

bashi@: Are you fine with me doing this? If so, please re-assign this bug back to me and I'll take care of the migration. On the other hand, if no-one tracks this benchmark and you are happy to have it completely removed, please let me know (to avoid doing unnecessary work). Thanks!
 
Blocking: 621037

Comment 2 by bashi@chromium.org, Jun 18 2016

Status: Assigned (was: Untriaged)
Thanks for the head-up. I'll try to switch the benchmark to TBMv2 (or just remove) next week.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d6528f73fa996e6c34d7f5ea2c08441efd99751

commit 0d6528f73fa996e6c34d7f5ea2c08441efd99751
Author: bashi <bashi@chromium.org>
Date: Fri Jun 24 09:14:01 2016

Switch memory.blink_memory_mobile to TBMv2

BUG= 621034 
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2090293002
Cr-Commit-Position: refs/heads/master@{#401837}

[modify] https://crrev.com/0d6528f73fa996e6c34d7f5ea2c08441efd99751/tools/perf/benchmarks/memory_infra.py

Status: Fixed (was: Assigned)
bashi@: Thanks a lot for taking care of this!

Sign in to add a comment