New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621027 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Unable to navigate to chrome://history page using keyboard shortcut.

Reported by dchau...@etouch.net, Jun 17 2016

Issue description

Chrome Version: 53.0.2770.0 (Official Build)318e6f543c58eeeac93b122030041139da7e1e6a-refs/heads/master@{#400326} 32/64-bit.
OS: Windows(7,8,10), Linux(Ubuntu 14.04 LTS) 

Precondition: Enable Material Design history flag from chrome://flags.

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://history page.
2. Click on 'CLEAR BROWSING DATA' link (navigates to 'Clear Browsing Data' page).
3. Without clicking anywhere on page, Press 'Alt' + 'Left arrow' key from keyboard and observe.

Nothing happens after pressing 'Alt' + 'Left arrow' key from keyboard.
'Clear Browsing Data' page should navigate to chrome://history page on pressing 'Alt' + 'Left arrow' key.

This is a regression issue, broken in M-52 series, below is bisect info.

Good build: 52.0.2730.0 (52.0.2731.0 {#392557})
Bad build: 52.0.2732.0 (52.0.2731.0 {#392561})

Narrow bisect;
https://chromium.googlesource.com/chromium/src/+log/dbec398ead9639b0aaf3790f864615267d09e8a1..107c2dd4bab61ff1876daccc56f40a8436dfdf10?pretty=fuller&n=50

Suspecting: r392559

Note: This issue is not reproducible on Mac OS.

Kindly review the attached screen-cast for reference.
 
Actual behavior.mp4
1.1 MB View Download
Labels: Proj-MaterialDesign-WebUI
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 4 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef0e6195fe0f61340de3e6516ebc7c57e085a09a

commit ef0e6195fe0f61340de3e6516ebc7c57e085a09a
Author: tsergeant <tsergeant@chromium.org>
Date: Wed Jul 13 03:21:22 2016

MD History: Change how Clear Browsing Data is opened

This CL changes the Clear Browsing Data button in MD History to use the
same chrome.send call as the old history page. This ensures that the
Settings app is opened on CrOS and that a new tab is opened on non-CrOS.

BUG= 621027 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2137903002
Cr-Commit-Position: refs/heads/master@{#404952}

[modify] https://crrev.com/ef0e6195fe0f61340de3e6516ebc7c57e085a09a/chrome/browser/resources/md_history/browser_service.js
[modify] https://crrev.com/ef0e6195fe0f61340de3e6516ebc7c57e085a09a/chrome/browser/resources/md_history/compiled_resources2.gyp
[modify] https://crrev.com/ef0e6195fe0f61340de3e6516ebc7c57e085a09a/chrome/browser/resources/md_history/side_bar.html
[modify] https://crrev.com/ef0e6195fe0f61340de3e6516ebc7c57e085a09a/chrome/browser/resources/md_history/side_bar.js

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef0e6195fe0f61340de3e6516ebc7c57e085a09a

commit ef0e6195fe0f61340de3e6516ebc7c57e085a09a
Author: tsergeant <tsergeant@chromium.org>
Date: Wed Jul 13 03:21:22 2016

MD History: Change how Clear Browsing Data is opened

This CL changes the Clear Browsing Data button in MD History to use the
same chrome.send call as the old history page. This ensures that the
Settings app is opened on CrOS and that a new tab is opened on non-CrOS.

BUG= 621027 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2137903002
Cr-Commit-Position: refs/heads/master@{#404952}

[modify] https://crrev.com/ef0e6195fe0f61340de3e6516ebc7c57e085a09a/chrome/browser/resources/md_history/browser_service.js
[modify] https://crrev.com/ef0e6195fe0f61340de3e6516ebc7c57e085a09a/chrome/browser/resources/md_history/compiled_resources2.gyp
[modify] https://crrev.com/ef0e6195fe0f61340de3e6516ebc7c57e085a09a/chrome/browser/resources/md_history/side_bar.html
[modify] https://crrev.com/ef0e6195fe0f61340de3e6516ebc7c57e085a09a/chrome/browser/resources/md_history/side_bar.js

Status: Fixed (was: Assigned)
The clear browsing data dialog now opens in a new tab. It is possible to go back to the history page by closing that tab.

Marking this as Fixed.

Sign in to add a comment