Issue metadata
Sign in to add a comment
|
1.5%-100% regression in webrtc_perf_tests at 13149:13149 |
||||||||||||||||||||
Issue descriptionSee graphs below.
,
Jun 17 2016
Hi Per, looks like your CL caused some impressive perf improvements all around (nice!), could you have a look at the changes in bitrate_stats_min_transmit_bitrate/bitrate_kbps? I don't know enough about it to tell if it's an improvement or regression. Thanks.
,
Jun 17 2016
Oops, forgot to include a link to your CL, it's this one: https://codereview.webrtc.org/1993113003.
,
Jun 17 2016
I will try to understand what have happened.
,
Jun 17 2016
,
Jun 17 2016
If I understand this correctly, ramp up times are unaffected and also the total number of packets are unaffected. What have changed in the number of rtx packets that we sent. I don't understand really how my cl could affect that but considering that the the total number of packets are the same and the ramp up times are the same I think we can wait until stefan come back and can maybe take a look?
,
Jul 4 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 11 2016
Perf sheriff ping.
,
Jul 12 2016
Sorry, I assigned the wrong Stefan.
,
Jul 12 2016
We definitely seem to be sending less padding in these tests now. I can't really say why, which worries me. Per, could you investigate a bit to see if the padding calculations are any different when running simulcast? Are we at all sending padding packets when using simulcast now?
,
Jul 13 2016
,
Jul 13 2016
Yes- we send padding and the set max padding bitrate is 1.3Mbit/s. See the attached log: I added logging to where we set the padding limits and where we actually send padding.
,
Jul 13 2016
,
Jul 13 2016
Might just be a timing issue then. It's a huge difference between your example and the perf bot: Your example: RESULT ramp-up-rtx-total-sent: AbsSendTimeSimulcastByRedWithRtx= 297965 bytes RESULT ramp-up-rtx-padding-sent: AbsSendTimeSimulcastByRedWithRtx= 15456 bytes Perf bot: Padding on rtx stream went from 224 bytes (a single padding packet) to 0 bytes. Total on rtx stream went from about 8000 bytes to 3000 bytes. I think we can conclude that we're sending a bit less on the rtx stream, but ramping up as quickly. I won't investigate it more since it doesn't have any negative side effects and the bugs that come to mind have been investigated. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by ivoc@chromium.org
, Jun 17 2016