New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621019 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.5%-100% regression in webrtc_perf_tests at 13149:13149

Project Member Reported by ivoc@chromium.org, Jun 17 2016

Issue description

See graphs below.
 

Comment 1 by ivoc@chromium.org, Jun 17 2016

Comment 2 by ivoc@chromium.org, Jun 17 2016

Labels: -M-51 M-53
Owner: perkj@chromium.org
Hi Per, looks like your CL caused some impressive perf improvements all around (nice!), could you have a look at the changes in bitrate_stats_min_transmit_bitrate/bitrate_kbps? I don't know enough about it to tell if it's an improvement or regression. Thanks.

Comment 3 by ivoc@chromium.org, Jun 17 2016

Oops, forgot to include a link to your CL, it's this one: https://codereview.webrtc.org/1993113003.

Comment 4 by perkj@chromium.org, Jun 17 2016

I will try to understand what have happened.

Comment 5 by perkj@chromium.org, Jun 17 2016

Cc: stefan@webrtc.org mflodman@webrtc.org

Comment 6 by perkj@chromium.org, Jun 17 2016

Cc: perkj@chromium.org perkj@webrtc.org
Owner: stefanoc@chromium.org
If I understand this correctly, ramp up times are unaffected and also the total number of packets are unaffected. 
What have changed in the number of rtx packets that we sent. I don't understand really how my cl could affect that but considering that the the total number of packets are the same and the ramp up times are the same I think we can wait until stefan come back and can maybe take a look?  


Project Member

Comment 7 by sheriffbot@chromium.org, Jul 4 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Perf sheriff ping.

Comment 9 by perkj@chromium.org, Jul 12 2016

Owner: holmer@chromium.org
Sorry, I assigned the wrong Stefan. 
We definitely seem to be sending less padding in these tests now. I can't
really say why, which worries me.

Per, could you investigate a bit to see if the padding calculations are any
different when running simulcast? Are we at all sending padding packets
when using simulcast now?
Owner: perkj@chromium.org

Comment 12 by perkj@chromium.org, Jul 13 2016

Yes- we send padding and the set max padding bitrate is 1.3Mbit/s. 

See the attached log:
I added logging to where we set the padding limits and where we actually send padding.
RampUpTest_AbsSendTimeSimulcastByRedWithRtx.txt
70.2 KB View Download

Comment 13 by perkj@chromium.org, Jul 13 2016

Owner: holmer@chromium.org
Status: WontFix (was: Assigned)
Might just be a timing issue then. It's a huge difference between your example and the perf bot:
Your example: 
RESULT ramp-up-rtx-total-sent: AbsSendTimeSimulcastByRedWithRtx= 297965 bytes
RESULT ramp-up-rtx-padding-sent: AbsSendTimeSimulcastByRedWithRtx= 15456 bytes

Perf bot: 
Padding on rtx stream went from 224 bytes (a single padding packet) to 0 bytes.
Total on rtx stream went from about 8000 bytes to 3000 bytes.

I think we can conclude that we're sending a bit less on the rtx stream, but ramping up as quickly. I won't investigate it more since it doesn't have any negative side effects and the bugs that come to mind have been investigated.

Sign in to add a comment