New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 621015 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Favicon icon colour doesn’t change even after reseting theme to default

Reported by dmascare...@etouch.net, Jun 17 2016

Issue description

Chrome Version:53.0.2770.0 (Official Build) 318e6f543c58eeeac93b122030041139da7e1e6a-refs/heads/master@{#400326} 
OS: MAC Pro (10.10.5, 10.11.4)

Test url :1. https://chrome.google.com/webstore/detail/cookies-milk/niboghheambbpfbehljofglebpmofjgk?hl=en
          2. https://chromium.googlesource.com/chromium/src/+log/52.0.2720.0..52.0.2721.0?pretty=fuller&n=10000

What steps will reproduce the problem?
1. Launch chrome and navigate to test url 2.
2. Navigate to chrome://settings/ and click on ‘Reset the default theme’ button.

Actual:Favicon icon colour doesn’t change even after reseting theme to default
Expected: Favicon icon colour should change to default colour (i.e black)

This is regression issue, broken in ‘M 53’ and will soon update the bisect info:

Good build: 53.0.2768.0
Bad build: 53.0.2769.0

 
Actual_theme.mov
4.9 MB Download
Exp_theme.mov
7.0 MB Download
Labels: hasbisect
Owner: spqc...@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/3d2d190935003c2b4a4ad7b3d2cf2c580214a272..95ba699eba9413f257437534e9e58dc42bfc82ae?pretty=fuller&n=100

Suspecting: r399930

Note: Above issue is not seen on Windows and Linux OS.
Labels: ReleaseBlock-Stable
Adding RB label as this is a recent regression.
Cc: shrike@chromium.org
Hey shrike, I'm looking into this and I'm not sure if the icon should be black or white since the cookie theme is a bit dark.

Comment 4 by ajha@chromium.org, Jun 23 2016

shrike@: Can we get an update on this as per C#3. Would be good to have a fix for this before M-53 is branched(Probably next week).

Comment 5 by shrike@chromium.org, Jun 23 2016

To clarify steps to reproduce:

1. Install the theme at https://chrome.google.com/webstore/detail/cookies-milk/niboghheambbpfbehljofglebpmofjgk?hl=en
2. Open https://chromium.googlesource.com/chromium/src/+log/52.0.2720.0..52.0.2721.0?pretty=fuller&n=10000 in a new tab (let's call it Tab 2)
3. Open chrome://settings/ in a new tab and reset to the default tab

The problem is that the tab icon for Tab 2 (which is the default favicon) is still colored brown instead of the default favicon color. See attached screenshot.

I think the default color for the default favicon is black, but I don't remember. When the theme changes, the tab favicon view/button is not getting redrawn. The fix is perhaps similar to the one I recently made for the close button, which had a similar problem: https://codereview.chromium.org/2080973002/.


Screen Shot 2016-06-23 at 9.36.38 AM.png
9.8 KB View Download
Status: Started (was: Assigned)

Comment 7 by ajha@chromium.org, Jul 13 2016

Friendly ping to get an update on this blocker issue.
It's in the works https://codereview.chromium.org/2126043002/
Cc: rnimmagadda@chromium.org
Labels: Needs-Feedback
Unable to repro this issue on MAC (10.11.5) for Google Chrome Canary Version - 54.0.2800.0

Screen-recording is attached.

@dmascarenhas: Could you please perform the steps mentioned beneath and let us know your observations. 

1. Update your Google Chrome Canary Version - 54.0.2800.0
2. Re-test the same on a clean profile [chrome://settings -> Add Person]

Thank you.
621015.mov
16.1 MB Download
Status: Fixed (was: Started)

Sign in to add a comment