Issue metadata
Sign in to add a comment
|
Regression: Favicon icon colour doesn’t change even after reseting theme to default
Reported by
dmascare...@etouch.net,
Jun 17 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:53.0.2770.0 (Official Build) 318e6f543c58eeeac93b122030041139da7e1e6a-refs/heads/master@{#400326} OS: MAC Pro (10.10.5, 10.11.4) Test url :1. https://chrome.google.com/webstore/detail/cookies-milk/niboghheambbpfbehljofglebpmofjgk?hl=en 2. https://chromium.googlesource.com/chromium/src/+log/52.0.2720.0..52.0.2721.0?pretty=fuller&n=10000 What steps will reproduce the problem? 1. Launch chrome and navigate to test url 2. 2. Navigate to chrome://settings/ and click on ‘Reset the default theme’ button. Actual:Favicon icon colour doesn’t change even after reseting theme to default Expected: Favicon icon colour should change to default colour (i.e black) This is regression issue, broken in ‘M 53’ and will soon update the bisect info: Good build: 53.0.2768.0 Bad build: 53.0.2769.0
,
Jun 17 2016
Adding RB label as this is a recent regression.
,
Jun 20 2016
Hey shrike, I'm looking into this and I'm not sure if the icon should be black or white since the cookie theme is a bit dark.
,
Jun 23 2016
shrike@: Can we get an update on this as per C#3. Would be good to have a fix for this before M-53 is branched(Probably next week).
,
Jun 23 2016
To clarify steps to reproduce: 1. Install the theme at https://chrome.google.com/webstore/detail/cookies-milk/niboghheambbpfbehljofglebpmofjgk?hl=en 2. Open https://chromium.googlesource.com/chromium/src/+log/52.0.2720.0..52.0.2721.0?pretty=fuller&n=10000 in a new tab (let's call it Tab 2) 3. Open chrome://settings/ in a new tab and reset to the default tab The problem is that the tab icon for Tab 2 (which is the default favicon) is still colored brown instead of the default favicon color. See attached screenshot. I think the default color for the default favicon is black, but I don't remember. When the theme changes, the tab favicon view/button is not getting redrawn. The fix is perhaps similar to the one I recently made for the close button, which had a similar problem: https://codereview.chromium.org/2080973002/.
,
Jun 29 2016
,
Jul 13 2016
Friendly ping to get an update on this blocker issue.
,
Jul 13 2016
It's in the works https://codereview.chromium.org/2126043002/
,
Jul 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d57b7e232022e031e8a0908215f9ad4eee61117 commit 7d57b7e232022e031e8a0908215f9ad4eee61117 Author: spqchan <spqchan@chromium.org> Date: Thu Jul 14 22:51:00 2016 [Material][Mac] Fix Default Favicon's Color Default favicon now has the same color as the close button. This CL also makes sure that the favicon's color gets updated when the theme changes. CloseButtonColor has been refactored. BUG= 621015 , 625821 Review-Url: https://codereview.chromium.org/2126043002 Cr-Commit-Position: refs/heads/master@{#405612} [modify] https://crrev.com/7d57b7e232022e031e8a0908215f9ad4eee61117/chrome/browser/ui/cocoa/hover_close_button.h [modify] https://crrev.com/7d57b7e232022e031e8a0908215f9ad4eee61117/chrome/browser/ui/cocoa/hover_close_button.mm [modify] https://crrev.com/7d57b7e232022e031e8a0908215f9ad4eee61117/chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa.mm [modify] https://crrev.com/7d57b7e232022e031e8a0908215f9ad4eee61117/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm [modify] https://crrev.com/7d57b7e232022e031e8a0908215f9ad4eee61117/chrome/browser/ui/cocoa/tabs/tab_view.h [modify] https://crrev.com/7d57b7e232022e031e8a0908215f9ad4eee61117/chrome/browser/ui/cocoa/tabs/tab_view.mm
,
Jul 20 2016
Unable to repro this issue on MAC (10.11.5) for Google Chrome Canary Version - 54.0.2800.0 Screen-recording is attached. @dmascarenhas: Could you please perform the steps mentioned beneath and let us know your observations. 1. Update your Google Chrome Canary Version - 54.0.2800.0 2. Re-test the same on a clean profile [chrome://settings -> Add Person] Thank you.
,
Jul 20 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dmascare...@etouch.net
, Jun 17 2016Owner: spqc...@chromium.org
Status: Assigned (was: Unconfirmed)