Files app's "Set wallpaper..." button shouldn't have ellipsis |
||||||
Issue descriptionVersion: 53.0.2768.0 1. Open Files app 2. Right-click an image file Expected: "Set wallpaper" option Actual: "Set wallpaper..." option In ash, "Set wallpaper..." actually opens the wallpaper dialog, so the ellipsis make sense. In the file manager, it immediately sets the wallpaper, so the "..." is misleading. Seems like we're using the same string (IDS_SET_WALLPAPER_BUTTON), when we should have a separate string without the ellipsis. See: https://codereview.chromium.org/1679983003
,
Jun 17 2016
Yes.
,
Jun 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a4ebed40bbadbe44df52ab3c7d73e8f22930524 commit 5a4ebed40bbadbe44df52ab3c7d73e8f22930524 Author: oka <oka@chromium.org> Date: Wed Jun 22 04:07:03 2016 Remove ellipsis from "Set wallpaper..." context menu item. BUG= 620982 TEST=manually Review-Url: https://codereview.chromium.org/2077293002 Cr-Commit-Position: refs/heads/master@{#401203} [modify] https://crrev.com/5a4ebed40bbadbe44df52ab3c7d73e8f22930524/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/5a4ebed40bbadbe44df52ab3c7d73e8f22930524/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
,
Jun 22 2016
,
Jun 27 2016
Still have "Set wallpaper..." option ChromeOS:8508.0.0/53.0.2773.0 daisy
,
Jun 27 2016
its old Chrome, I will retest once latest chrome is available.
,
Jul 1 2016
,
Aug 12 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by fukino@chromium.org
, Jun 17 2016Status: Assigned (was: Untriaged)