New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 620978 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Weird flickering is observed on rotating cube

Reported by adha...@etouch.net, Jun 17 2016

Issue description

Chrome Version:53.0.2769.2 (Official Build) 67c1583dc8789efc61a90031de836e361e7635e3-refs/branch-heads/2769@{#3} 32/64-bit.
OS:Windows (7,8,8.1,10)

Test URL: http://paulrhayes.com/experiments/cube-3d/

Steps:
1.Launch chrome,navigate to above URL.
2.Press up/down arrow keys to rotate the cube,observe.

Actual: Weird flickering is observed on rotating the cube. 
Expected: Weird flickering should not be seen on rotating the cube.

This is a regression issue, broken in M-53 series,will soon update the other info.

 

Comment 1 by adha...@etouch.net, Jun 17 2016

Labels: hasbisect OS-Linux
Owner: f...@opera.com
Status: Assigned (was: Unconfirmed)
Correction: 
In step 2:Press up/down or left/right arrow keys to rotate the cube,observe.

Good build: 53.0.2754.0 
Bad build: 53.0.2756.0 

Narrow bisect:  
https://chromium.googlesource.com/chromium/src/+log/8a208672ab14fa87cd1dd5ad6043a11c22e4d71e..d4cff44e1023869434c07689e29ee4440a3b7a2e?pretty=fuller&n=1000

Suspecting: r397202

Please re-assign if your change is not cause of this issue.

Note: This issue is not seen on Mac OS.

Comment 2 by f...@opera.com, Jun 17 2016

Owner: jaydasika@chromium.org
r397201 appears more related.
Labels: ReleaseBlock-Stable
Adding RB label as this is a recent regression.
@jaydasika: Could you please provide an update on this issue.

Thank you.
Unable to reproduce on ToT on Linux. 

Comment 6 by suzyh@chromium.org, Jun 22 2016

Labels: Update-fortnightly
I was able to repro on dev on Linux. Not seeing it in stable or canary.

Comment 7 by suzyh@chromium.org, Jun 22 2016

Whoops, I meant not seeing it in stable or beta.
I don't see it on dev. Are you running it with some flags ?

Comment 9 by suzyh@chromium.org, Jun 22 2016

Ah, yes, good point. I forgot about that. I have experimental web platform features enabled on dev. But then I just turned off the flag and I'm still seeing the occasional jump. I'm in the process of updating my checkout and will see if I can repro on ToT.

Comment 10 by suzyh@chromium.org, Jun 22 2016

I'm seeing the same jumps with and without --enable-experimental-web-platform-features on ToT.

Comment 11 by suzyh@chromium.org, Jun 22 2016

Video attached of repro on dev on Linux, no special flags enabled.
repro.ogv
6.7 MB View Download
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94bcfedec292cc72e7b98cea38da392fbf1dc18a

commit 94bcfedec292cc72e7b98cea38da392fbf1dc18a
Author: jaydasika <jaydasika@chromium.org>
Date: Fri Jun 24 23:29:01 2016

cc: Fix property tree animation sync bug

Property trees animation sync at commit depends on the value of
is_currently_animating value of a property tree node on the main thread.
So, we need to do this sync before calling AnimationHost::PushProperties
as AnimationHost::PushProperties can delete animations and change the
is_currently_animating value.

BUG= 620978 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2090793002
Cr-Commit-Position: refs/heads/master@{#402011}

[modify] https://crrev.com/94bcfedec292cc72e7b98cea38da392fbf1dc18a/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/94bcfedec292cc72e7b98cea38da392fbf1dc18a/cc/trees/layer_tree_host_unittest_animation.cc

Labels: Merge-Request-53

Comment 14 by dimu@google.com, Jun 27 2016

Labels: -Merge-Request-53 Merge-Review-53 Hotlist-Merge-Review
[Automated comment] Commit may have occurred before M53 branch point (6/30/2016), needs manual review.
Labels: -Hotlist-Merge-review -Merge-Review-53
Whoops, my bad. This doesn't need a merge
Status: Fixed (was: Assigned)

Sign in to add a comment