Mouse Wheel triggering MouseDown event in fullscreen
Reported by
kratikaa...@gmail.com,
Jun 17 2016
|
|||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.84 Safari/537.36 Steps to reproduce the problem: 1) Run attached mouse_wheel.html in chrome browser 2) click on Fullscreen 3) now scroll the mouse wheel What is the expected behavior? only mouse wheel event is fired What went wrong? mouse wheel event is fired (as well as mouse down event is also fired which should not get fired) Did this work before? Yes Chrome injection is revision 382353 51.0.0.2687.0. ChangeLog URL- https://chromium.googlesource.com/chromium/src/+log/9231ba274a1c6525bf06cfc1a214fae2967663b7..28f39b53d44b7ae58d6d7d125db15786628f21d9 Chrome version: 51.0.2704.84 Channel: n/a OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Shockwave Flash 21.0 0.242 It passes on chrome 51.0.0.2687.0 revision 382342 with FP 21.0.0.242 and Fails on chrome 51.0.0.2687.0 revision 382353 with FP 21.0.0.242
,
Jun 17 2016
Assignment based on symptom and the CL described in the bisect range.
,
Jun 17 2016
,
Jun 20 2016
Fix posted here: https://codereview.chromium.org/2085663002/
,
Jun 20 2016
Excellent, thank you. Once that CL has baked, would you mind merge requesting it to M52?
,
Jun 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/527139c5692500e9b5587be7226d54f7e8f870b2 commit 527139c5692500e9b5587be7226d54f7e8f870b2 Author: dtapuska <dtapuska@chromium.org> Date: Mon Jun 20 22:00:22 2016 Do not convert mouse wheel gesture events in pepper. It appears GesutreScrollBegin and End get translated to mouse events when in full screen mode. Do not convert touchpad/mouse wheel gesture events. BUG= 620974 Review-Url: https://codereview.chromium.org/2085663002 Cr-Commit-Position: refs/heads/master@{#400802} [modify] https://crrev.com/527139c5692500e9b5587be7226d54f7e8f870b2/content/renderer/render_widget_fullscreen_pepper.cc
,
Jun 22 2016
,
Jun 22 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0a319db4c38b6669e0b39aa62138f4c39675f88 commit e0a319db4c38b6669e0b39aa62138f4c39675f88 Author: Dave Tapuska <dtapuska@chromium.org> Date: Wed Jun 22 17:10:12 2016 Do not convert mouse wheel gesture events in pepper. It appears GesutreScrollBegin and End get translated to mouse events when in full screen mode. Do not convert touchpad/mouse wheel gesture events. BUG= 620974 Review-Url: https://codereview.chromium.org/2085663002 Cr-Commit-Position: refs/heads/master@{#400802} (cherry picked from commit 527139c5692500e9b5587be7226d54f7e8f870b2) Review URL: https://codereview.chromium.org/2090113002 . Cr-Commit-Position: refs/branch-heads/2743@{#447} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/e0a319db4c38b6669e0b39aa62138f4c39675f88/content/renderer/render_widget_fullscreen_pepper.cc
,
Jun 30 2016
Tested the same on win8.1 chrome version 52.0.2743.60 - observed only mouse wheel event firing. Please find the screenshot Fix works as expected. Adding TE Verified labels
,
Jul 20 2016
Issue 624475 has been merged into this issue. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by jecl...@adobe.com
, Jun 17 2016