New issue
Advanced search Search tips

Issue 620932 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task

Blocked on:
issue 734150

Blocking:
issue 616244



Sign in to add a comment

Move crw_swipe_recognizer_provider.h to ui/base/ios

Project Member Reported by eugene...@chromium.org, Jun 17 2016

Issue description

CRWSwipeRecognizerProvider is used in both web// and chrome// and is definitely not a part of web// API.
 
Components: Mobile>WebView>Glue
Labels: -Restrict-View-Google -Type-Bug -Pri-2 Pri-3 Type-Feature
Labels: -Type-Feature Type-Task
Cc: danyao@chromium.org justincohen@chromium.org
Components: -Mobile>WebView>Glue UI>Browser>Navigation>GestureNav
Labels: Proj-WKBackForwardList
crw_swipe_recognizer_provider.h will be unnecessary after switching to WKBackForwardList based navigation. With WKBackForwardList Chrome can use WKWebView side swipe UI.
Will toolbar swipe still need this?
I removed CRWSwipeRecognizerProvider code from Chrome and it looks like toolbar swipe still works correctly. So I guess the answer is: NO.
Blockedon: 734150
Labels: -Proj-WKBackForwardList
We can throw away this code once SlimNav launches and we implement native back/forward swipe.

Sign in to add a comment