Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 620927 Mojo communication in Mus/Ozone
Starred by 7 users Project Member Reported by rjkroege@chromium.org, Jun 17 2016 Back to list
Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 649366

Blocking:
issue 581462
issue 698030



Sign in to add a comment
In split-mus, mus-ws needs to communicate with mus-gpu. Existing mus does this via PostTask because these components are in the same process. In split-mus, they are not. Use mojo to communicate between ws and gpu specific components so that they can be easily executed in both single and multiple process modes.

 
Cc: kylec...@chromium.org
Labels: -Pri-3 tadpole mustash mus Pri-2
Owner: rjkroege@chromium.org
Status: Started
Labels: screen
Project Member Comment 3 by bugdroid1@chromium.org, Jun 17 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e577e7306cf9eb00f5099747630ebd46e0613758

commit e577e7306cf9eb00f5099747630ebd46e0613758
Author: rjkroege <rjkroege@chromium.org>
Date: Fri Jun 17 20:05:13 2016

Add a flexible ozone configuration scheme

Make it possible to deliver additional parameters into an ozone
platform such as the mojo shell::Connector handle on platforms that
wish to use mojo.

BUG=620927

Review-Url: https://codereview.chromium.org/2079693002
Cr-Commit-Position: refs/heads/master@{#400478}

[modify] https://crrev.com/e577e7306cf9eb00f5099747630ebd46e0613758/ui/ozone/public/ozone_platform.cc
[modify] https://crrev.com/e577e7306cf9eb00f5099747630ebd46e0613758/ui/ozone/public/ozone_platform.h

Project Member Comment 4 by bugdroid1@chromium.org, Jun 21 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/160cfd0956839fd92f053cf46db1de3613d831d9

commit 160cfd0956839fd92f053cf46db1de3613d831d9
Author: rjkroege <rjkroege@chromium.org>
Date: Tue Jun 21 20:47:16 2016

Ozone Mojo setup in mus

Configure the ozone platform with the necessary parameters to use mojo
if the platform should desire to do so.

BUG=620927

Review-Url: https://codereview.chromium.org/2079233003
Cr-Commit-Position: refs/heads/master@{#401102}

[modify] https://crrev.com/160cfd0956839fd92f053cf46db1de3613d831d9/components/mus/mus_app.cc

Project Member Comment 5 by bugdroid1@chromium.org, Jun 22 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e

commit 6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e
Author: rjkroege <rjkroege@chromium.org>
Date: Wed Jun 22 13:04:38 2016

Refactor ozone drm cursor code for mojo

Adjust code in ozone drm platform to simplify the introduction of mojo IPC for
cursor control.

BUG=620927

Review-Url: https://codereview.chromium.org/2088533002
Cr-Commit-Position: refs/heads/master@{#401265}

[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/events/ozone/evdev/cursor_delegate_evdev.h
[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/events/ozone/evdev/event_converter_evdev_impl_unittest.cc
[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/events/ozone/evdev/event_thread_evdev.cc
[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/events/ozone/evdev/input_injector_evdev_unittest.cc
[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc
[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/ozone/platform/drm/gpu/drm_thread.h
[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/ozone/platform/drm/host/drm_cursor.cc
[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/ozone/platform/drm/host/drm_cursor.h
[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc
[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/ozone/platform/drm/mus_thread_proxy.cc
[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/ozone/platform/drm/mus_thread_proxy.h

Cc: j.iso...@samsung.com
Project Member Comment 8 by bugdroid1@chromium.org, Jul 25 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24836dd05bc3168a3b9833ea9ed0231419d07897

commit 24836dd05bc3168a3b9833ea9ed0231419d07897
Author: rjkroege <rjkroege@chromium.org>
Date: Mon Jul 25 20:33:08 2016

Update thread usage notes in CursorDelegateEvdev

Comments in CursorDelegateEvdev incorrectly specified thread usage
so update appropriately.

BUG=620927

Review-Url: https://codereview.chromium.org/2179123002
Cr-Commit-Position: refs/heads/master@{#407565}

[modify] https://crrev.com/24836dd05bc3168a3b9833ea9ed0231419d07897/ui/events/ozone/evdev/cursor_delegate_evdev.h

Blockedon: 626778
Project Member Comment 10 by bugdroid1@chromium.org, Jul 30 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19f44a11dcc5866c52e86bee2eab07149d06ddd0

commit 19f44a11dcc5866c52e86bee2eab07149d06ddd0
Author: rjkroege <rjkroege@chromium.org>
Date: Sat Jul 30 01:59:25 2016

Use mojo for cursor control in ozone drm

Use mojo to control the cursor in ozone drm in mus. First in a series of patches to
convert Ozone IPC to mojo.

BUG=620927

Review-Url: https://codereview.chromium.org/2156093004
Cr-Commit-Position: refs/heads/master@{#408840}

[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/services/ui/common/run_all_shelltests.cc
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/services/ui/gpu/gpu_service_mus.cc
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/services/ui/manifest.json
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/services/ui/service.cc
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/gl/test/run_all_unittests.cc
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/BUILD.gn
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/BUILD.gn
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/DEPS
[add] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/cursor_proxy_mojo.cc
[add] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/cursor_proxy_mojo.h
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/gpu/drm_thread.h
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/gpu/drm_thread_proxy.cc
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/gpu/drm_thread_proxy.h
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/host/drm_cursor.h
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/mus_thread_proxy.cc
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/mus_thread_proxy.h
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/ozone_platform_gbm.cc
[add] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/public/interfaces/BUILD.gn
[add] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/public/interfaces/OWNERS
[add] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/public/interfaces/device_cursor.mojom

Blockedon: -626778
Components: MUS
Blockedon: 649366
Components: Internals>MUS
Labels: Proj-Mustash
Cc: fsam...@chromium.org rjkroege@chromium.org sadrul@chromium.org
 Issue 611506  has been merged into this issue.
Blocking: 581462
Components: -MUS -Internals>MUS Internals>GPU>Internals
Labels: -mus -mustash -tadpole Proj-Mustash-Milestone-Tadpole Proj-Ozone-DRM Proj-Mustash-Mus-GPU
Blocking:
Labels: mustash-2
Project Member Comment 21 by bugdroid1@chromium.org, Apr 19
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b8df9f9ab51716b373227c373ae0b43b7034dc8

commit 0b8df9f9ab51716b373227c373ae0b43b7034dc8
Author: rjkroege <rjkroege@chromium.org>
Date: Wed Apr 19 23:05:37 2017

Re-order fields for better alignment

Trivial change to possibly reduce DisplayMode size.

BUG=620927

Review-Url: https://codereview.chromium.org/2809913003
Cr-Commit-Position: refs/heads/master@{#465802}

[modify] https://crrev.com/0b8df9f9ab51716b373227c373ae0b43b7034dc8/ui/display/types/display_mode.cc
[modify] https://crrev.com/0b8df9f9ab51716b373227c373ae0b43b7034dc8/ui/display/types/display_mode.h

Blocking: 698030
Project Member Comment 23 by bugdroid1@chromium.org, May 10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a82a006f8420ecc7c75deab4f1e9d23c43616e1f

commit a82a006f8420ecc7c75deab4f1e9d23c43616e1f
Author: rjkroege <rjkroege@chromium.org>
Date: Wed May 10 21:25:00 2017

Update ozone/drm proxy_helpers.h to support move-only types.

As a helpful prerequisite for the use of mojo IPC in ozone/drm,
support move only types in proxy_helpers.h callback sequences.

BUG=620927

Review-Url: https://codereview.chromium.org/2873963004
Cr-Commit-Position: refs/heads/master@{#470715}

[modify] https://crrev.com/a82a006f8420ecc7c75deab4f1e9d23c43616e1f/ui/ozone/platform/drm/BUILD.gn
[modify] https://crrev.com/a82a006f8420ecc7c75deab4f1e9d23c43616e1f/ui/ozone/platform/drm/gpu/proxy_helpers.h
[add] https://crrev.com/a82a006f8420ecc7c75deab4f1e9d23c43616e1f/ui/ozone/platform/drm/gpu/proxy_helpers_unittest.cc

Project Member Comment 24 by bugdroid1@chromium.org, May 12
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ae4e4bee29bcb52bc0dd21a2dd59551003cd678

commit 2ae4e4bee29bcb52bc0dd21a2dd59551003cd678
Author: rjkroege <rjkroege@chromium.org>
Date: Fri May 12 23:30:11 2017

Update ozone/drm proxy_helpers.h to support move-only types.

As a helpful prerequisite for the use of mojo IPC in ozone/drm,
support move only types in proxy_helpers.h callback sequences.

BUG=620927

Review-Url: https://codereview.chromium.org/2873963004
Cr-Original-Commit-Position: refs/heads/master@{#470715}
Committed: https://chromium.googlesource.com/chromium/src/+/a82a006f8420ecc7c75deab4f1e9d23c43616e1f
Review-Url: https://codereview.chromium.org/2873963004
Cr-Commit-Position: refs/heads/master@{#471486}

[modify] https://crrev.com/2ae4e4bee29bcb52bc0dd21a2dd59551003cd678/ui/ozone/platform/drm/BUILD.gn
[modify] https://crrev.com/2ae4e4bee29bcb52bc0dd21a2dd59551003cd678/ui/ozone/platform/drm/gpu/proxy_helpers.h
[add] https://crrev.com/2ae4e4bee29bcb52bc0dd21a2dd59551003cd678/ui/ozone/platform/drm/gpu/proxy_helpers_unittest.cc

Project Member Comment 25 by bugdroid1@chromium.org, May 15
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2421ee1aeb0c71573527fd33145ce1e0b18a9888

commit 2421ee1aeb0c71573527fd33145ce1e0b18a9888
Author: rjkroege <rjkroege@chromium.org>
Date: Mon May 15 15:15:03 2017

Convert ozone/drm to OnceCallback

As a helpful prerequisite to the addition of mojo IPC in ozone/drm,
use base::OnceCallback in place of base::Callback for all non swap
callbacks.

BUG=620927

Review-Url: https://codereview.chromium.org/2875823005
Cr-Commit-Position: refs/heads/master@{#471769}

[modify] https://crrev.com/2421ee1aeb0c71573527fd33145ce1e0b18a9888/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/2421ee1aeb0c71573527fd33145ce1e0b18a9888/ui/ozone/platform/drm/gpu/drm_thread.h
[modify] https://crrev.com/2421ee1aeb0c71573527fd33145ce1e0b18a9888/ui/ozone/platform/drm/gpu/drm_thread_message_proxy.cc
[modify] https://crrev.com/2421ee1aeb0c71573527fd33145ce1e0b18a9888/ui/ozone/platform/drm/mus_thread_proxy.cc

Project Member Comment 26 by bugdroid1@chromium.org, Today (18 hours ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a15746c2355c8ef9a09028465d727add7a241a69

commit a15746c2355c8ef9a09028465d727add7a241a69
Author: rjkroege <rjkroege@chromium.org>
Date: Tue May 23 20:52:49 2017

Convert additional ozone/drm callbacks to OnceCallback

Further replace base::Callback with base::OnceCallback in ozone/drm in swap
buffers implementation.

BUG=620927

Review-Url: https://codereview.chromium.org/2886503002
Cr-Commit-Position: refs/heads/master@{#474045}

[modify] https://crrev.com/a15746c2355c8ef9a09028465d727add7a241a69/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/a15746c2355c8ef9a09028465d727add7a241a69/ui/ozone/platform/drm/gpu/drm_thread.h
[modify] https://crrev.com/a15746c2355c8ef9a09028465d727add7a241a69/ui/ozone/platform/drm/gpu/drm_window.cc
[modify] https://crrev.com/a15746c2355c8ef9a09028465d727add7a241a69/ui/ozone/platform/drm/gpu/drm_window.h
[modify] https://crrev.com/a15746c2355c8ef9a09028465d727add7a241a69/ui/ozone/platform/drm/gpu/drm_window_proxy.cc
[modify] https://crrev.com/a15746c2355c8ef9a09028465d727add7a241a69/ui/ozone/platform/drm/gpu/drm_window_proxy.h
[modify] https://crrev.com/a15746c2355c8ef9a09028465d727add7a241a69/ui/ozone/platform/drm/gpu/hardware_display_controller.cc
[modify] https://crrev.com/a15746c2355c8ef9a09028465d727add7a241a69/ui/ozone/platform/drm/gpu/hardware_display_controller.h
[modify] https://crrev.com/a15746c2355c8ef9a09028465d727add7a241a69/ui/ozone/platform/drm/gpu/page_flip_request.cc
[modify] https://crrev.com/a15746c2355c8ef9a09028465d727add7a241a69/ui/ozone/platform/drm/gpu/page_flip_request.h
[modify] https://crrev.com/a15746c2355c8ef9a09028465d727add7a241a69/ui/ozone/public/swap_completion_callback.h

Project Member Comment 27 by bugdroid1@chromium.org, Today (12 hours ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54fee5d86ef41e706cb794d1c587a5269ecee9ec

commit 54fee5d86ef41e706cb794d1c587a5269ecee9ec
Author: rjkroege <rjkroege@chromium.org>
Date: Wed May 24 02:50:25 2017

Use display::DisplayMode in the ozone/drm DrmThread boundary to simplify
implementing a Mojo interface with the DrmThread interface.

BUG=620927

Review-Url: https://codereview.chromium.org/2894523007
Cr-Commit-Position: refs/heads/master@{#474139}

[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/BUILD.gn
[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/common/drm_util.cc
[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/common/drm_util.h
[add] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/common/drm_util_unittest.cc
[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc
[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/gpu/drm_gpu_display_manager.h
[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/gpu/drm_thread.h
[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/gpu/drm_thread_message_proxy.cc
[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/gpu/drm_thread_message_proxy.h
[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/gpu/proxy_helpers_unittest.cc
[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/host/drm_display_host.cc
[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/mus_thread_proxy.cc

Sign in to add a comment