New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 620927 link

Starred by 11 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Sign in to add a comment

Mojo communication in Mus/Ozone

Project Member Reported by rjkroege@chromium.org, Jun 17 2016

Issue description

In split-mus, mus-ws needs to communicate with mus-gpu. Existing mus does this via PostTask because these components are in the same process. In split-mus, they are not. Use mojo to communicate between ws and gpu specific components so that they can be easily executed in both single and multiple process modes.

 
Cc: kylec...@chromium.org
Labels: -Pri-3 tadpole mustash mus Pri-2
Owner: rjkroege@chromium.org
Status: Started (was: St)
Labels: screen
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e577e7306cf9eb00f5099747630ebd46e0613758

commit e577e7306cf9eb00f5099747630ebd46e0613758
Author: rjkroege <rjkroege@chromium.org>
Date: Fri Jun 17 20:05:13 2016

Add a flexible ozone configuration scheme

Make it possible to deliver additional parameters into an ozone
platform such as the mojo shell::Connector handle on platforms that
wish to use mojo.

BUG=620927

Review-Url: https://codereview.chromium.org/2079693002
Cr-Commit-Position: refs/heads/master@{#400478}

[modify] https://crrev.com/e577e7306cf9eb00f5099747630ebd46e0613758/ui/ozone/public/ozone_platform.cc
[modify] https://crrev.com/e577e7306cf9eb00f5099747630ebd46e0613758/ui/ozone/public/ozone_platform.h

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/160cfd0956839fd92f053cf46db1de3613d831d9

commit 160cfd0956839fd92f053cf46db1de3613d831d9
Author: rjkroege <rjkroege@chromium.org>
Date: Tue Jun 21 20:47:16 2016

Ozone Mojo setup in mus

Configure the ozone platform with the necessary parameters to use mojo
if the platform should desire to do so.

BUG=620927

Review-Url: https://codereview.chromium.org/2079233003
Cr-Commit-Position: refs/heads/master@{#401102}

[modify] https://crrev.com/160cfd0956839fd92f053cf46db1de3613d831d9/components/mus/mus_app.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e

commit 6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e
Author: rjkroege <rjkroege@chromium.org>
Date: Wed Jun 22 13:04:38 2016

Refactor ozone drm cursor code for mojo

Adjust code in ozone drm platform to simplify the introduction of mojo IPC for
cursor control.

BUG=620927

Review-Url: https://codereview.chromium.org/2088533002
Cr-Commit-Position: refs/heads/master@{#401265}

[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/events/ozone/evdev/cursor_delegate_evdev.h
[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/events/ozone/evdev/event_converter_evdev_impl_unittest.cc
[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/events/ozone/evdev/event_thread_evdev.cc
[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/events/ozone/evdev/input_injector_evdev_unittest.cc
[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc
[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/ozone/platform/drm/gpu/drm_thread.h
[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/ozone/platform/drm/host/drm_cursor.cc
[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/ozone/platform/drm/host/drm_cursor.h
[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc
[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/ozone/platform/drm/mus_thread_proxy.cc
[modify] https://crrev.com/6b5aaf6974e27f524ed8e6f87cfe511ff32c5c4e/ui/ozone/platform/drm/mus_thread_proxy.h

Cc: j.iso...@samsung.com
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24836dd05bc3168a3b9833ea9ed0231419d07897

commit 24836dd05bc3168a3b9833ea9ed0231419d07897
Author: rjkroege <rjkroege@chromium.org>
Date: Mon Jul 25 20:33:08 2016

Update thread usage notes in CursorDelegateEvdev

Comments in CursorDelegateEvdev incorrectly specified thread usage
so update appropriately.

BUG=620927

Review-Url: https://codereview.chromium.org/2179123002
Cr-Commit-Position: refs/heads/master@{#407565}

[modify] https://crrev.com/24836dd05bc3168a3b9833ea9ed0231419d07897/ui/events/ozone/evdev/cursor_delegate_evdev.h

Blockedon: 626778
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19f44a11dcc5866c52e86bee2eab07149d06ddd0

commit 19f44a11dcc5866c52e86bee2eab07149d06ddd0
Author: rjkroege <rjkroege@chromium.org>
Date: Sat Jul 30 01:59:25 2016

Use mojo for cursor control in ozone drm

Use mojo to control the cursor in ozone drm in mus. First in a series of patches to
convert Ozone IPC to mojo.

BUG=620927

Review-Url: https://codereview.chromium.org/2156093004
Cr-Commit-Position: refs/heads/master@{#408840}

[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/services/ui/common/run_all_shelltests.cc
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/services/ui/gpu/gpu_service_mus.cc
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/services/ui/manifest.json
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/services/ui/service.cc
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/gl/test/run_all_unittests.cc
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/BUILD.gn
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/BUILD.gn
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/DEPS
[add] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/cursor_proxy_mojo.cc
[add] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/cursor_proxy_mojo.h
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/gpu/drm_thread.h
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/gpu/drm_thread_proxy.cc
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/gpu/drm_thread_proxy.h
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/host/drm_cursor.h
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/mus_thread_proxy.cc
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/mus_thread_proxy.h
[modify] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/platform/drm/ozone_platform_gbm.cc
[add] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/public/interfaces/BUILD.gn
[add] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/public/interfaces/OWNERS
[add] https://crrev.com/19f44a11dcc5866c52e86bee2eab07149d06ddd0/ui/ozone/public/interfaces/device_cursor.mojom

Blockedon: -626778
Components: MUS
Blockedon: 649366
Components: Internals>MUS
Labels: Proj-Mustash
Cc: fsam...@chromium.org rjkroege@chromium.org sadrul@chromium.org
 Issue 611506  has been merged into this issue.
Blocking: 581462
Components: -MUS -Internals>MUS Internals>GPU>Internals
Labels: -mus -mustash -tadpole Proj-Mustash-Milestone-Tadpole Proj-Ozone-DRM Proj-Mustash-Mus-GPU
Blocking:

Comment 20 by sky@chromium.org, Mar 27 2017

Labels: mustash-2
Project Member

Comment 21 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b8df9f9ab51716b373227c373ae0b43b7034dc8

commit 0b8df9f9ab51716b373227c373ae0b43b7034dc8
Author: rjkroege <rjkroege@chromium.org>
Date: Wed Apr 19 23:05:37 2017

Re-order fields for better alignment

Trivial change to possibly reduce DisplayMode size.

BUG=620927

Review-Url: https://codereview.chromium.org/2809913003
Cr-Commit-Position: refs/heads/master@{#465802}

[modify] https://crrev.com/0b8df9f9ab51716b373227c373ae0b43b7034dc8/ui/display/types/display_mode.cc
[modify] https://crrev.com/0b8df9f9ab51716b373227c373ae0b43b7034dc8/ui/display/types/display_mode.h

Blocking: 698030
Project Member

Comment 23 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a82a006f8420ecc7c75deab4f1e9d23c43616e1f

commit a82a006f8420ecc7c75deab4f1e9d23c43616e1f
Author: rjkroege <rjkroege@chromium.org>
Date: Wed May 10 21:25:00 2017

Update ozone/drm proxy_helpers.h to support move-only types.

As a helpful prerequisite for the use of mojo IPC in ozone/drm,
support move only types in proxy_helpers.h callback sequences.

BUG=620927

Review-Url: https://codereview.chromium.org/2873963004
Cr-Commit-Position: refs/heads/master@{#470715}

[modify] https://crrev.com/a82a006f8420ecc7c75deab4f1e9d23c43616e1f/ui/ozone/platform/drm/BUILD.gn
[modify] https://crrev.com/a82a006f8420ecc7c75deab4f1e9d23c43616e1f/ui/ozone/platform/drm/gpu/proxy_helpers.h
[add] https://crrev.com/a82a006f8420ecc7c75deab4f1e9d23c43616e1f/ui/ozone/platform/drm/gpu/proxy_helpers_unittest.cc

Project Member

Comment 24 by bugdroid1@chromium.org, May 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ae4e4bee29bcb52bc0dd21a2dd59551003cd678

commit 2ae4e4bee29bcb52bc0dd21a2dd59551003cd678
Author: rjkroege <rjkroege@chromium.org>
Date: Fri May 12 23:30:11 2017

Update ozone/drm proxy_helpers.h to support move-only types.

As a helpful prerequisite for the use of mojo IPC in ozone/drm,
support move only types in proxy_helpers.h callback sequences.

BUG=620927

Review-Url: https://codereview.chromium.org/2873963004
Cr-Original-Commit-Position: refs/heads/master@{#470715}
Committed: https://chromium.googlesource.com/chromium/src/+/a82a006f8420ecc7c75deab4f1e9d23c43616e1f
Review-Url: https://codereview.chromium.org/2873963004
Cr-Commit-Position: refs/heads/master@{#471486}

[modify] https://crrev.com/2ae4e4bee29bcb52bc0dd21a2dd59551003cd678/ui/ozone/platform/drm/BUILD.gn
[modify] https://crrev.com/2ae4e4bee29bcb52bc0dd21a2dd59551003cd678/ui/ozone/platform/drm/gpu/proxy_helpers.h
[add] https://crrev.com/2ae4e4bee29bcb52bc0dd21a2dd59551003cd678/ui/ozone/platform/drm/gpu/proxy_helpers_unittest.cc

Project Member

Comment 25 by bugdroid1@chromium.org, May 15 2017

Project Member

Comment 26 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a15746c2355c8ef9a09028465d727add7a241a69

commit a15746c2355c8ef9a09028465d727add7a241a69
Author: rjkroege <rjkroege@chromium.org>
Date: Tue May 23 20:52:49 2017

Convert additional ozone/drm callbacks to OnceCallback

Further replace base::Callback with base::OnceCallback in ozone/drm in swap
buffers implementation.

BUG=620927

Review-Url: https://codereview.chromium.org/2886503002
Cr-Commit-Position: refs/heads/master@{#474045}

[modify] https://crrev.com/a15746c2355c8ef9a09028465d727add7a241a69/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/a15746c2355c8ef9a09028465d727add7a241a69/ui/ozone/platform/drm/gpu/drm_thread.h
[modify] https://crrev.com/a15746c2355c8ef9a09028465d727add7a241a69/ui/ozone/platform/drm/gpu/drm_window.cc
[modify] https://crrev.com/a15746c2355c8ef9a09028465d727add7a241a69/ui/ozone/platform/drm/gpu/drm_window.h
[modify] https://crrev.com/a15746c2355c8ef9a09028465d727add7a241a69/ui/ozone/platform/drm/gpu/drm_window_proxy.cc
[modify] https://crrev.com/a15746c2355c8ef9a09028465d727add7a241a69/ui/ozone/platform/drm/gpu/drm_window_proxy.h
[modify] https://crrev.com/a15746c2355c8ef9a09028465d727add7a241a69/ui/ozone/platform/drm/gpu/hardware_display_controller.cc
[modify] https://crrev.com/a15746c2355c8ef9a09028465d727add7a241a69/ui/ozone/platform/drm/gpu/hardware_display_controller.h
[modify] https://crrev.com/a15746c2355c8ef9a09028465d727add7a241a69/ui/ozone/platform/drm/gpu/page_flip_request.cc
[modify] https://crrev.com/a15746c2355c8ef9a09028465d727add7a241a69/ui/ozone/platform/drm/gpu/page_flip_request.h
[modify] https://crrev.com/a15746c2355c8ef9a09028465d727add7a241a69/ui/ozone/public/swap_completion_callback.h

Project Member

Comment 27 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54fee5d86ef41e706cb794d1c587a5269ecee9ec

commit 54fee5d86ef41e706cb794d1c587a5269ecee9ec
Author: rjkroege <rjkroege@chromium.org>
Date: Wed May 24 02:50:25 2017

Use display::DisplayMode in the ozone/drm DrmThread boundary to simplify
implementing a Mojo interface with the DrmThread interface.

BUG=620927

Review-Url: https://codereview.chromium.org/2894523007
Cr-Commit-Position: refs/heads/master@{#474139}

[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/BUILD.gn
[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/common/drm_util.cc
[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/common/drm_util.h
[add] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/common/drm_util_unittest.cc
[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc
[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/gpu/drm_gpu_display_manager.h
[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/gpu/drm_thread.h
[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/gpu/drm_thread_message_proxy.cc
[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/gpu/drm_thread_message_proxy.h
[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/gpu/proxy_helpers_unittest.cc
[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/host/drm_display_host.cc
[modify] https://crrev.com/54fee5d86ef41e706cb794d1c587a5269ecee9ec/ui/ozone/platform/drm/mus_thread_proxy.cc

Blocking: 732805
Project Member

Comment 30 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd2587383919cd365bc3b8b81dfdff78cf3b6eb0

commit dd2587383919cd365bc3b8b81dfdff78cf3b6eb0
Author: rjkroege <rjkroege@chromium.org>
Date: Tue Jun 13 21:18:10 2017

Convert ozone/drm DisplaySnapshot_Param to DisplaySnapshotMojo

In ozone/drm, modify DrmThread::RefreshNativeDisplay to use
DisplaySnapshotMojo. This is another incremental step in using mojo
communication in ozone/drm. In particular, using the DrmThread as an
implementation of a mojo interface for cursor, display and buffer
control.

BUG=620927

Review-Url: https://codereview.chromium.org/2930163002
Cr-Commit-Position: refs/heads/master@{#479152}

[modify] https://crrev.com/dd2587383919cd365bc3b8b81dfdff78cf3b6eb0/ui/display/types/display_snapshot_mojo.cc
[modify] https://crrev.com/dd2587383919cd365bc3b8b81dfdff78cf3b6eb0/ui/display/types/display_snapshot_mojo.h
[modify] https://crrev.com/dd2587383919cd365bc3b8b81dfdff78cf3b6eb0/ui/ozone/BUILD.gn
[modify] https://crrev.com/dd2587383919cd365bc3b8b81dfdff78cf3b6eb0/ui/ozone/common/display_snapshot_proxy.cc
[modify] https://crrev.com/dd2587383919cd365bc3b8b81dfdff78cf3b6eb0/ui/ozone/common/display_snapshot_proxy.h
[modify] https://crrev.com/dd2587383919cd365bc3b8b81dfdff78cf3b6eb0/ui/ozone/platform/drm/BUILD.gn
[add] https://crrev.com/dd2587383919cd365bc3b8b81dfdff78cf3b6eb0/ui/ozone/platform/drm/common/display_types.h
[modify] https://crrev.com/dd2587383919cd365bc3b8b81dfdff78cf3b6eb0/ui/ozone/platform/drm/common/drm_util.cc
[modify] https://crrev.com/dd2587383919cd365bc3b8b81dfdff78cf3b6eb0/ui/ozone/platform/drm/common/drm_util.h
[modify] https://crrev.com/dd2587383919cd365bc3b8b81dfdff78cf3b6eb0/ui/ozone/platform/drm/common/drm_util_unittest.cc
[modify] https://crrev.com/dd2587383919cd365bc3b8b81dfdff78cf3b6eb0/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/dd2587383919cd365bc3b8b81dfdff78cf3b6eb0/ui/ozone/platform/drm/gpu/drm_thread.h
[modify] https://crrev.com/dd2587383919cd365bc3b8b81dfdff78cf3b6eb0/ui/ozone/platform/drm/gpu/drm_thread_message_proxy.cc
[modify] https://crrev.com/dd2587383919cd365bc3b8b81dfdff78cf3b6eb0/ui/ozone/platform/drm/gpu/drm_thread_message_proxy.h
[modify] https://crrev.com/dd2587383919cd365bc3b8b81dfdff78cf3b6eb0/ui/ozone/platform/drm/mus_thread_proxy.cc
[modify] https://crrev.com/dd2587383919cd365bc3b8b81dfdff78cf3b6eb0/ui/ozone/platform/drm/mus_thread_proxy.h

Blockedon: 735237
Blocking: 611505
Project Member

Comment 33 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/211fb8b5e6d4a167d28f28774070e10b845951bf

commit 211fb8b5e6d4a167d28f28774070e10b845951bf
Author: Robert Kroeger <rjkroege@chromium.org>
Date: Tue Jul 18 00:18:13 2017

mojo struct_traits for ozone OverlaySurfaceCandidate

Add struct_traits for OverlaySurfaceCandidate to enable mojo IPC in
ozone.

BUG=620927

Change-Id: I16a6058f6ef411ab7acfeedc8ba35d080baed674
Reviewed-on: https://chromium-review.googlesource.com/571980
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487315}
[modify] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/mojo/public/tools/bindings/chromium_bindings_configuration.gni
[modify] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/gfx/BUILD.gn
[modify] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/gfx/mojo/BUILD.gn
[add] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/gfx/mojo/overlay_transform.mojom
[add] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/gfx/mojo/overlay_transform.typemap
[add] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/gfx/mojo/overlay_transform_struct_traits.h
[modify] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/gfx/typemaps.gni
[modify] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/ozone/BUILD.gn
[modify] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/ozone/DEPS
[modify] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/ozone/common/gpu/ozone_gpu_message_params.cc
[modify] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/ozone/common/gpu/ozone_gpu_message_params.h
[modify] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/ozone/demo/surfaceless_gl_renderer.cc
[modify] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/ozone/platform/drm/host/drm_overlay_manager.cc
[modify] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/ozone/platform/drm/host/drm_overlay_manager.h
[modify] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/ozone/public/interfaces/BUILD.gn
[add] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/ozone/public/interfaces/DEPS
[modify] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/ozone/public/interfaces/OWNERS
[add] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/ozone/public/interfaces/overlay_surface_candidate.mojom
[add] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/ozone/public/interfaces/overlay_surface_candidate.typemap
[add] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/ozone/public/interfaces/overlay_surface_candidate_struct_traits.h
[add] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/ozone/public/interfaces/overlay_surface_candidate_struct_traits_unittest.cc
[add] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/ozone/public/interfaces/typemaps.gni
[modify] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/ozone/public/overlay_candidates_ozone.cc
[modify] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/ozone/public/overlay_candidates_ozone.h
[add] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/ozone/public/overlay_surface_candidate.cc
[add] https://crrev.com/211fb8b5e6d4a167d28f28774070e10b845951bf/ui/ozone/public/overlay_surface_candidate.h
[delete] https://crrev.com/5289ff36697917c664cd07bac96f4d2c1380ba82/ui/ozone/run_all_unittests.cc

Project Member

Comment 34 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0b8cf5e3ba5bc7574273e42d2122d4c0578b31a

commit f0b8cf5e3ba5bc7574273e42d2122d4c0578b31a
Author: Robert Kroeger <rjkroege@chromium.org>
Date: Tue Jul 18 22:02:11 2017

Add EnumTraits for overlay checking return  codes

Extract overlay checking status into a stand-alone enum and provide a
corresponding mojo EnumTraits for it.

BUG=620927

Change-Id: I411e5ec402ce580a61478383ac9b2482a33989f0
Reviewed-on: https://chromium-review.googlesource.com/575701
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487622}
[modify] https://crrev.com/f0b8cf5e3ba5bc7574273e42d2122d4c0578b31a/ui/ozone/common/gpu/ozone_gpu_message_params.h
[modify] https://crrev.com/f0b8cf5e3ba5bc7574273e42d2122d4c0578b31a/ui/ozone/common/gpu/ozone_gpu_messages.h
[modify] https://crrev.com/f0b8cf5e3ba5bc7574273e42d2122d4c0578b31a/ui/ozone/platform/drm/gpu/drm_overlay_validator.cc
[modify] https://crrev.com/f0b8cf5e3ba5bc7574273e42d2122d4c0578b31a/ui/ozone/platform/drm/gpu/drm_overlay_validator_unittest.cc
[modify] https://crrev.com/f0b8cf5e3ba5bc7574273e42d2122d4c0578b31a/ui/ozone/platform/drm/host/drm_overlay_manager.cc
[modify] https://crrev.com/f0b8cf5e3ba5bc7574273e42d2122d4c0578b31a/ui/ozone/public/interfaces/overlay_surface_candidate.mojom
[modify] https://crrev.com/f0b8cf5e3ba5bc7574273e42d2122d4c0578b31a/ui/ozone/public/interfaces/overlay_surface_candidate.typemap
[modify] https://crrev.com/f0b8cf5e3ba5bc7574273e42d2122d4c0578b31a/ui/ozone/public/interfaces/overlay_surface_candidate_struct_traits.h
[modify] https://crrev.com/f0b8cf5e3ba5bc7574273e42d2122d4c0578b31a/ui/ozone/public/interfaces/overlay_surface_candidate_struct_traits_unittest.cc
[modify] https://crrev.com/f0b8cf5e3ba5bc7574273e42d2122d4c0578b31a/ui/ozone/public/overlay_surface_candidate.h

Project Member

Comment 35 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3817977756471f18782ea88f867fe22f24a7669e

commit 3817977756471f18782ea88f867fe22f24a7669e
Author: Robert Kroeger <rjkroege@chromium.org>
Date: Mon Jul 24 21:28:43 2017

Convert DrmThread::CheckOverlayCapabilities to mojo signature

In ozone, overlay candidates are sent from the host to the Drm thread
via IPC. Convert this flow to mojo compatible type signatures as a
precondition to using mojo IPC inside of ozone/drm.

BUG=620927

Change-Id: I60a5356f37eef8a9882047bdbf85d6b45d33ed9a
Reviewed-on: https://chromium-review.googlesource.com/581853
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489078}
[modify] https://crrev.com/3817977756471f18782ea88f867fe22f24a7669e/ui/ozone/common/gpu/ozone_gpu_message_params.cc
[modify] https://crrev.com/3817977756471f18782ea88f867fe22f24a7669e/ui/ozone/common/gpu/ozone_gpu_message_params.h
[modify] https://crrev.com/3817977756471f18782ea88f867fe22f24a7669e/ui/ozone/platform/drm/common/drm_util.cc
[modify] https://crrev.com/3817977756471f18782ea88f867fe22f24a7669e/ui/ozone/platform/drm/common/drm_util.h
[modify] https://crrev.com/3817977756471f18782ea88f867fe22f24a7669e/ui/ozone/platform/drm/common/drm_util_unittest.cc
[modify] https://crrev.com/3817977756471f18782ea88f867fe22f24a7669e/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/3817977756471f18782ea88f867fe22f24a7669e/ui/ozone/platform/drm/gpu/drm_thread.h
[modify] https://crrev.com/3817977756471f18782ea88f867fe22f24a7669e/ui/ozone/platform/drm/gpu/drm_thread_message_proxy.cc
[modify] https://crrev.com/3817977756471f18782ea88f867fe22f24a7669e/ui/ozone/platform/drm/gpu/drm_thread_message_proxy.h
[modify] https://crrev.com/3817977756471f18782ea88f867fe22f24a7669e/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc
[modify] https://crrev.com/3817977756471f18782ea88f867fe22f24a7669e/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h
[modify] https://crrev.com/3817977756471f18782ea88f867fe22f24a7669e/ui/ozone/platform/drm/host/drm_overlay_manager.cc
[modify] https://crrev.com/3817977756471f18782ea88f867fe22f24a7669e/ui/ozone/platform/drm/host/drm_overlay_manager.h
[modify] https://crrev.com/3817977756471f18782ea88f867fe22f24a7669e/ui/ozone/platform/drm/host/gpu_thread_adapter.h
[modify] https://crrev.com/3817977756471f18782ea88f867fe22f24a7669e/ui/ozone/platform/drm/mus_thread_proxy.cc
[modify] https://crrev.com/3817977756471f18782ea88f867fe22f24a7669e/ui/ozone/platform/drm/mus_thread_proxy.h
[modify] https://crrev.com/3817977756471f18782ea88f867fe22f24a7669e/ui/ozone/public/overlay_candidates_ozone.h
[modify] https://crrev.com/3817977756471f18782ea88f867fe22f24a7669e/ui/ozone/public/overlay_surface_candidate.cc
[modify] https://crrev.com/3817977756471f18782ea88f867fe22f24a7669e/ui/ozone/public/overlay_surface_candidate.h

Project Member

Comment 36 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87d7e6ddb22a1cf4916fcbb74b293ee5a8fa6227

commit 87d7e6ddb22a1cf4916fcbb74b293ee5a8fa6227
Author: Robert Kroeger <rjkroege@chromium.org>
Date: Mon Aug 21 23:40:26 2017

Mojo ipc in ozone/drm for host/gpu communication.

Ozone/DRM is split between the VIZ process and its host (typically the
browser or services/ui process.) Provide complete mojo IPC connection
between the host and viz processes.

As part of this CL, the one-process mode for ozone/drm was converted
to use mojo in-process communication and hence always requires a valid
mojo connection ptr so also update the the GL unit test harness to provide
a test-style in-process mojo connection to ozone/drm.

BUG=620927

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I32d691d0c02868561d1dbe838c8f6bb23493dae6
Reviewed-on: https://chromium-review.googlesource.com/614426
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496121}
[modify] https://crrev.com/87d7e6ddb22a1cf4916fcbb74b293ee5a8fa6227/services/ui/manifest.json
[modify] https://crrev.com/87d7e6ddb22a1cf4916fcbb74b293ee5a8fa6227/ui/gl/BUILD.gn
[modify] https://crrev.com/87d7e6ddb22a1cf4916fcbb74b293ee5a8fa6227/ui/gl/test/DEPS
[modify] https://crrev.com/87d7e6ddb22a1cf4916fcbb74b293ee5a8fa6227/ui/gl/test/run_all_unittests.cc
[modify] https://crrev.com/87d7e6ddb22a1cf4916fcbb74b293ee5a8fa6227/ui/ozone/platform/drm/gpu/drm_device_manager.cc
[modify] https://crrev.com/87d7e6ddb22a1cf4916fcbb74b293ee5a8fa6227/ui/ozone/platform/drm/gpu/drm_device_manager.h
[modify] https://crrev.com/87d7e6ddb22a1cf4916fcbb74b293ee5a8fa6227/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/87d7e6ddb22a1cf4916fcbb74b293ee5a8fa6227/ui/ozone/platform/drm/gpu/drm_thread.h
[modify] https://crrev.com/87d7e6ddb22a1cf4916fcbb74b293ee5a8fa6227/ui/ozone/platform/drm/gpu/drm_thread_message_proxy.cc
[modify] https://crrev.com/87d7e6ddb22a1cf4916fcbb74b293ee5a8fa6227/ui/ozone/platform/drm/gpu/drm_thread_proxy.cc
[modify] https://crrev.com/87d7e6ddb22a1cf4916fcbb74b293ee5a8fa6227/ui/ozone/platform/drm/gpu/drm_thread_proxy.h
[modify] https://crrev.com/87d7e6ddb22a1cf4916fcbb74b293ee5a8fa6227/ui/ozone/platform/drm/host/drm_display_host_manager.cc
[modify] https://crrev.com/87d7e6ddb22a1cf4916fcbb74b293ee5a8fa6227/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc
[modify] https://crrev.com/87d7e6ddb22a1cf4916fcbb74b293ee5a8fa6227/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h
[modify] https://crrev.com/87d7e6ddb22a1cf4916fcbb74b293ee5a8fa6227/ui/ozone/platform/drm/host/gpu_thread_adapter.h
[modify] https://crrev.com/87d7e6ddb22a1cf4916fcbb74b293ee5a8fa6227/ui/ozone/platform/drm/mus_thread_proxy.cc
[modify] https://crrev.com/87d7e6ddb22a1cf4916fcbb74b293ee5a8fa6227/ui/ozone/platform/drm/mus_thread_proxy.h
[modify] https://crrev.com/87d7e6ddb22a1cf4916fcbb74b293ee5a8fa6227/ui/ozone/platform/drm/ozone_platform_gbm.cc
[modify] https://crrev.com/87d7e6ddb22a1cf4916fcbb74b293ee5a8fa6227/ui/ozone/public/interfaces/BUILD.gn
[add] https://crrev.com/87d7e6ddb22a1cf4916fcbb74b293ee5a8fa6227/ui/ozone/public/interfaces/gpu_adapter.mojom

Project Member

Comment 37 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d87c5c7fa88ee03c903f9a63ef95368d90d3599

commit 2d87c5c7fa88ee03c903f9a63ef95368d90d3599
Author: Robert Kroeger <rjkroege@chromium.org>
Date: Tue Aug 29 18:55:19 2017

ozone/drm: rename a mojo interface

Rename the GpuAdapter mojo interface in ozone/drm to DrmAdapter to
better describe its intent: the interface to the DRM device service.

BUG=620927

Change-Id: I4dff7923dc3ead52234350561adbe77f764df457
Reviewed-on: https://chromium-review.googlesource.com/629105
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498183}
[modify] https://crrev.com/2d87c5c7fa88ee03c903f9a63ef95368d90d3599/services/ui/manifest.json
[modify] https://crrev.com/2d87c5c7fa88ee03c903f9a63ef95368d90d3599/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/2d87c5c7fa88ee03c903f9a63ef95368d90d3599/ui/ozone/platform/drm/gpu/drm_thread.h
[modify] https://crrev.com/2d87c5c7fa88ee03c903f9a63ef95368d90d3599/ui/ozone/platform/drm/gpu/drm_thread_proxy.cc
[modify] https://crrev.com/2d87c5c7fa88ee03c903f9a63ef95368d90d3599/ui/ozone/platform/drm/gpu/drm_thread_proxy.h
[modify] https://crrev.com/2d87c5c7fa88ee03c903f9a63ef95368d90d3599/ui/ozone/platform/drm/mus_thread_proxy.h
[modify] https://crrev.com/2d87c5c7fa88ee03c903f9a63ef95368d90d3599/ui/ozone/platform/drm/ozone_platform_gbm.cc
[modify] https://crrev.com/2d87c5c7fa88ee03c903f9a63ef95368d90d3599/ui/ozone/public/interfaces/BUILD.gn
[rename] https://crrev.com/2d87c5c7fa88ee03c903f9a63ef95368d90d3599/ui/ozone/public/interfaces/drm_device.mojom

Project Member

Comment 38 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d13b71466c83b6e72adc6860fae78c439f55e5f

commit 1d13b71466c83b6e72adc6860fae78c439f55e5f
Author: Robert Kroeger <rjkroege@chromium.org>
Date: Wed Aug 30 22:11:06 2017

ozone/drm: explicit Viz host/GPU separation

Restructure the ozone/drm mojo implementation into Viz host and Viz
(i.e. GPU) portions that can run in different processes.

BUG=620927

Change-Id: Ia08969fde0d0a3581a715aa9b2a5980df5f6f132
Reviewed-on: https://chromium-review.googlesource.com/641946
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498635}
[modify] https://crrev.com/1d13b71466c83b6e72adc6860fae78c439f55e5f/ui/ozone/platform/drm/BUILD.gn
[modify] https://crrev.com/1d13b71466c83b6e72adc6860fae78c439f55e5f/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/1d13b71466c83b6e72adc6860fae78c439f55e5f/ui/ozone/platform/drm/gpu/drm_thread.h
[modify] https://crrev.com/1d13b71466c83b6e72adc6860fae78c439f55e5f/ui/ozone/platform/drm/gpu/drm_thread_proxy.cc
[modify] https://crrev.com/1d13b71466c83b6e72adc6860fae78c439f55e5f/ui/ozone/platform/drm/gpu/drm_thread_proxy.h
[rename] https://crrev.com/1d13b71466c83b6e72adc6860fae78c439f55e5f/ui/ozone/platform/drm/host/host_cursor_proxy.cc
[rename] https://crrev.com/1d13b71466c83b6e72adc6860fae78c439f55e5f/ui/ozone/platform/drm/host/host_cursor_proxy.h
[add] https://crrev.com/1d13b71466c83b6e72adc6860fae78c439f55e5f/ui/ozone/platform/drm/host/host_drm_device.cc
[rename] https://crrev.com/1d13b71466c83b6e72adc6860fae78c439f55e5f/ui/ozone/platform/drm/host/host_drm_device.h
[delete] https://crrev.com/a7c3ab1ed4e25020ab1194452aab06abba7f6747/ui/ozone/platform/drm/mus_thread_proxy.cc
[modify] https://crrev.com/1d13b71466c83b6e72adc6860fae78c439f55e5f/ui/ozone/platform/drm/ozone_platform_gbm.cc
[modify] https://crrev.com/1d13b71466c83b6e72adc6860fae78c439f55e5f/ui/ozone/public/interfaces/drm_device.mojom

Comment 39 by sky@chromium.org, Oct 26 2017

Blocking: 731255

Comment 40 by sky@chromium.org, Nov 3 2017

Blocking: -731255
Project Member

Comment 41 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4

commit 7faa3b0c8896cb0ecde97fdfe77a4359d94104e4
Author: Robert Kroeger <rjkroege@chromium.org>
Date: Fri Jan 19 18:08:15 2018

[ozone/drm]: support content and service manager launching

The existing in-progress implementation of ozone/drm over mojo IPC
assumed that the ozone host would use a mojo ServiceManager provided
at initialization that it could use to launch and connect to the DRM
and cursor services. However, when used in a src/content context (such
as would be the case in Chrome), there is no service manager available
at ozone initialization time. Instead, content::GpuProcessHost
notifies the ozone host later from the browser I/O thread when the GPU
process containing the DRM and cursor services is running.

This CL refactors the ozone/drm/mojo implementation to isolate the
acquisition of mojo pipes into a separate class that supports both
styles of pipe acquistion: either by the use of a ServiceManager or
via an asynchronously injected dependency on content.

This CL also restructures the launch of the DRM thread itself so that
it can be deferred until after the GPU sandbox is initialized in a way
that does not depend on the use of legacy IPC message filters.

BUG=620927

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Icfb2261326cd1d5d6e2769d9801c02a744e1102a
Reviewed-on: https://chromium-review.googlesource.com/861749
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530562}
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/gpu/ipc/service/gpu_init.cc
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/services/test/run_all_service_tests.cc
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/gl/test/gl_image_test_support.cc
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/gl/test/gl_surface_test_support.cc
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/ozone/demo/ozone_demo.cc
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/ozone/platform/drm/BUILD.gn
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/ozone/platform/drm/gpu/drm_thread.h
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/ozone/platform/drm/gpu/drm_thread_message_proxy.cc
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/ozone/platform/drm/gpu/drm_thread_proxy.cc
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/ozone/platform/drm/gpu/drm_thread_proxy.h
[add] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/ozone/platform/drm/host/drm_device_connector.cc
[add] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/ozone/platform/drm/host/drm_device_connector.h
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/ozone/platform/drm/host/host_cursor_proxy.cc
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/ozone/platform/drm/host/host_cursor_proxy.h
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/ozone/platform/drm/host/host_drm_device.cc
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/ozone/platform/drm/host/host_drm_device.h
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/ozone/platform/drm/ozone_platform_gbm.cc
[rename] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/ozone/public/DEPS
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/ozone/public/gpu_platform_support_host.cc
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/ozone/public/gpu_platform_support_host.h
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/ozone/public/ozone_platform.cc
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/ozone/public/ozone_platform.h
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/ozone/public/ozone_switches.cc
[modify] https://crrev.com/7faa3b0c8896cb0ecde97fdfe77a4359d94104e4/ui/ozone/public/ozone_switches.h

Project Member

Comment 42 by bugdroid1@chromium.org, Jan 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/062531a9af2cf1cc690020bb122c353ee7433604

commit 062531a9af2cf1cc690020bb122c353ee7433604
Author: Dan Erat <derat@chromium.org>
Date: Sat Jan 20 01:14:47 2018

Revert "[ozone/drm]: support content and service manager launching"

This reverts commit 7faa3b0c8896cb0ecde97fdfe77a4359d94104e4.

Reason for revert: This appears to cause Chrome crashes in the
desktopui_MashLogin Autotest, resulting in failures in the
informational Chrome PFQ builders:  https://crbug.com/804052 

Original change's description:
> [ozone/drm]: support content and service manager launching
> 
> The existing in-progress implementation of ozone/drm over mojo IPC
> assumed that the ozone host would use a mojo ServiceManager provided
> at initialization that it could use to launch and connect to the DRM
> and cursor services. However, when used in a src/content context (such
> as would be the case in Chrome), there is no service manager available
> at ozone initialization time. Instead, content::GpuProcessHost
> notifies the ozone host later from the browser I/O thread when the GPU
> process containing the DRM and cursor services is running.
> 
> This CL refactors the ozone/drm/mojo implementation to isolate the
> acquisition of mojo pipes into a separate class that supports both
> styles of pipe acquistion: either by the use of a ServiceManager or
> via an asynchronously injected dependency on content.
> 
> This CL also restructures the launch of the DRM thread itself so that
> it can be deferred until after the GPU sandbox is initialized in a way
> that does not depend on the use of legacy IPC message filters.
> 
> BUG=620927
> 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: Icfb2261326cd1d5d6e2769d9801c02a744e1102a
> Reviewed-on: https://chromium-review.googlesource.com/861749
> Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
> Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#530562}

TBR=rjkroege@chromium.org,yzshen@chromium.org,dnicoara@chromium.org,piman@chromium.org

Change-Id: Ieb533a2c3db1634953437fcd4c34200f38e51601
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 620927
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/876936
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530712}
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/gpu/ipc/service/gpu_init.cc
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/services/test/run_all_service_tests.cc
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/ui/gl/test/gl_image_test_support.cc
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/ui/gl/test/gl_surface_test_support.cc
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/ui/ozone/demo/ozone_demo.cc
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/ui/ozone/platform/drm/BUILD.gn
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/ui/ozone/platform/drm/gpu/drm_thread.h
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/ui/ozone/platform/drm/gpu/drm_thread_message_proxy.cc
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/ui/ozone/platform/drm/gpu/drm_thread_proxy.cc
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/ui/ozone/platform/drm/gpu/drm_thread_proxy.h
[delete] https://crrev.com/e29eea14f91a8adb8ed3a443fb23eab673f2932b/ui/ozone/platform/drm/host/drm_device_connector.cc
[delete] https://crrev.com/e29eea14f91a8adb8ed3a443fb23eab673f2932b/ui/ozone/platform/drm/host/drm_device_connector.h
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/ui/ozone/platform/drm/host/host_cursor_proxy.cc
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/ui/ozone/platform/drm/host/host_cursor_proxy.h
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/ui/ozone/platform/drm/host/host_drm_device.cc
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/ui/ozone/platform/drm/host/host_drm_device.h
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/ui/ozone/platform/drm/ozone_platform_gbm.cc
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/ui/ozone/public/gpu_platform_support_host.cc
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/ui/ozone/public/gpu_platform_support_host.h
[rename] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/ui/ozone/public/interfaces/DEPS
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/ui/ozone/public/ozone_platform.cc
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/ui/ozone/public/ozone_platform.h
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/ui/ozone/public/ozone_switches.cc
[modify] https://crrev.com/062531a9af2cf1cc690020bb122c353ee7433604/ui/ozone/public/ozone_switches.h

Blockedon: 804052
Project Member

Comment 44 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9435ed8fa7d997aa54609dd3080f367eb20c8ee4

commit 9435ed8fa7d997aa54609dd3080f367eb20c8ee4
Author: Robert Kroeger <rjkroege@chromium.org>
Date: Wed Jan 24 17:10:37 2018

Reland "[ozone/drm]: support content and service manager launching"

This is a reland of 7faa3b0c8896cb0ecde97fdfe77a4359d94104e4.

With modified ozone setup to not regress --mash mode.

Original change's description:
> [ozone/drm]: support content and service manager launching
>
> The existing in-progress implementation of ozone/drm over mojo IPC
> assumed that the ozone host would use a mojo ServiceManager provided
> at initialization that it could use to launch and connect to the DRM
> and cursor services. However, when used in a src/content context (such
> as would be the case in Chrome), there is no service manager available
> at ozone initialization time. Instead, content::GpuProcessHost
> notifies the ozone host later from the browser I/O thread when the GPU
> process containing the DRM and cursor services is running.
>
> This CL refactors the ozone/drm/mojo implementation to isolate the
> acquisition of mojo pipes into a separate class that supports both
> styles of pipe acquistion: either by the use of a ServiceManager or
> via an asynchronously injected dependency on content.
>
> This CL also restructures the launch of the DRM thread itself so that
> it can be deferred until after the GPU sandbox is initialized in a way
> that does not depend on the use of legacy IPC message filters.
>
> BUG=620927
>
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: Icfb2261326cd1d5d6e2769d9801c02a744e1102a
> Reviewed-on: https://chromium-review.googlesource.com/861749
> Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
> Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#530562}

TBR=dnicoara@chromium.org,yzshen@chromium.org

Bug: 620927
Change-Id: I1453fc61b096600495276731c3bc749a040d14d3
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/882482
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531572}
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/gpu/ipc/service/gpu_init.cc
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/services/test/run_all_service_tests.cc
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/gl/test/gl_image_test_support.cc
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/gl/test/gl_surface_test_support.cc
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/ozone/demo/ozone_demo.cc
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/ozone/platform/drm/BUILD.gn
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/ozone/platform/drm/gpu/drm_thread.h
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/ozone/platform/drm/gpu/drm_thread_message_proxy.cc
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/ozone/platform/drm/gpu/drm_thread_proxy.cc
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/ozone/platform/drm/gpu/drm_thread_proxy.h
[add] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/ozone/platform/drm/host/drm_device_connector.cc
[add] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/ozone/platform/drm/host/drm_device_connector.h
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/ozone/platform/drm/host/host_cursor_proxy.cc
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/ozone/platform/drm/host/host_cursor_proxy.h
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/ozone/platform/drm/host/host_drm_device.cc
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/ozone/platform/drm/host/host_drm_device.h
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/ozone/platform/drm/ozone_platform_gbm.cc
[rename] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/ozone/public/DEPS
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/ozone/public/gpu_platform_support_host.cc
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/ozone/public/gpu_platform_support_host.h
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/ozone/public/ozone_platform.cc
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/ozone/public/ozone_platform.h
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/ozone/public/ozone_switches.cc
[modify] https://crrev.com/9435ed8fa7d997aa54609dd3080f367eb20c8ee4/ui/ozone/public/ozone_switches.h

Comment 45 by piman@chromium.org, Jan 25 2018

Blocking: 806092
Project Member

Comment 46 by bugdroid1@chromium.org, Jan 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2460e71463578a452799e945b0e96c4f3cfdadcf

commit 2460e71463578a452799e945b0e96c4f3cfdadcf
Author: Robert Kroeger <rjkroege@chromium.org>
Date: Fri Jan 26 23:33:07 2018

[ozone/drm] Modify GpuProcessHost to use ozone/drm/mojo

Modify GpuProcessHost to be able to inject the necessary mojo pipe
creation functionality so that ozone/drm can use mojo IPC when enabled
by a command line flag.

BUG=620927

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I585b1f66cbddb60beea886dda700a37357b89e5c
Reviewed-on: https://chromium-review.googlesource.com/861906
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532090}
[modify] https://crrev.com/2460e71463578a452799e945b0e96c4f3cfdadcf/components/viz/service/DEPS
[modify] https://crrev.com/2460e71463578a452799e945b0e96c4f3cfdadcf/components/viz/service/main/viz_main_impl.cc
[modify] https://crrev.com/2460e71463578a452799e945b0e96c4f3cfdadcf/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/2460e71463578a452799e945b0e96c4f3cfdadcf/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/2460e71463578a452799e945b0e96c4f3cfdadcf/content/gpu/gpu_child_thread.cc
[modify] https://crrev.com/2460e71463578a452799e945b0e96c4f3cfdadcf/content/public/app/mojo/content_gpu_manifest.json
[modify] https://crrev.com/2460e71463578a452799e945b0e96c4f3cfdadcf/gpu/ipc/service/gpu_init.cc
[modify] https://crrev.com/2460e71463578a452799e945b0e96c4f3cfdadcf/services/ui/service.cc
[modify] https://crrev.com/2460e71463578a452799e945b0e96c4f3cfdadcf/ui/aura/env.cc

Project Member

Comment 47 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abed4f3887d920d5ac0300034a2c7637fa7cda8d

commit abed4f3887d920d5ac0300034a2c7637fa7cda8d
Author: Robert Kroeger <rjkroege@chromium.org>
Date: Mon Jan 29 16:20:21 2018

[ozone/drm] --mus and mojo/ozone work at the same time

When --mus mode is enabled, the window server thread (aka mus) serves
as the ozone host. However, the DisplayCompositor continues to run on
the Chrome UI compositor (pending OOP-D completion.) As a result, the
DisplayCompositor's dependencies on ozone need to use a different
message pipe to communicate with the DrmDevice service. This CL adds
the creation and use of this additional mojo pipe when necessary.

BUG=620927

Change-Id: I4ebd0b7fc060cfff60a75796d5431d0f919f113e
Reviewed-on: https://chromium-review.googlesource.com/885261
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532452}
[modify] https://crrev.com/abed4f3887d920d5ac0300034a2c7637fa7cda8d/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/abed4f3887d920d5ac0300034a2c7637fa7cda8d/ui/ozone/platform/drm/gpu/drm_thread.h
[modify] https://crrev.com/abed4f3887d920d5ac0300034a2c7637fa7cda8d/ui/ozone/platform/drm/host/drm_device_connector.cc
[modify] https://crrev.com/abed4f3887d920d5ac0300034a2c7637fa7cda8d/ui/ozone/platform/drm/host/drm_device_connector.h
[modify] https://crrev.com/abed4f3887d920d5ac0300034a2c7637fa7cda8d/ui/ozone/platform/drm/host/host_drm_device.cc
[modify] https://crrev.com/abed4f3887d920d5ac0300034a2c7637fa7cda8d/ui/ozone/platform/drm/host/host_drm_device.h

Blockedon: 846501
Project Member

Comment 49 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01bfbe3235ba6e9957f23f9139b9d6206361f76b

commit 01bfbe3235ba6e9957f23f9139b9d6206361f76b
Author: Robert Kroeger <rjkroege@chromium.org>
Date: Wed Jul 18 14:55:56 2018

[ozone/drm] Support GPU process restart with mojo IPC

ozone/drm/mojo did not support GPU process restart. Add the necessary
handler to clear the cursor bindings and mark the connection as
unavailable.

BUG=620927
TEST=Run chrome --enable-drm-mojo on device, use chrome://gpucrash

Change-Id: I6a552a93bc923d7633e5c60890c53197accb48f8
Reviewed-on: https://chromium-review.googlesource.com/1139017
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576056}
[modify] https://crrev.com/01bfbe3235ba6e9957f23f9139b9d6206361f76b/ui/ozone/platform/drm/host/drm_device_connector.cc
[modify] https://crrev.com/01bfbe3235ba6e9957f23f9139b9d6206361f76b/ui/ozone/platform/drm/host/host_drm_device.cc
[modify] https://crrev.com/01bfbe3235ba6e9957f23f9139b9d6206361f76b/ui/ozone/platform/drm/host/host_drm_device.h

Blockedon: -846501
Project Member

Comment 51 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/189efd75161c086a7769187a6912e2eedf157df2

commit 189efd75161c086a7769187a6912e2eedf157df2
Author: Robert Kroeger <rjkroege@chromium.org>
Date: Fri Jul 20 14:48:42 2018

Convert ozone/drm/mojo flag to feature

To permit finch-trialing the use of mojo transport in ozone/drm, make the
transport be a feature.

BUG=620927
TEST=Run chrome on chell in standard, mojo and mash modes

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ieb7cd42c75a3ff047218b62714e629e873101a8a
Reviewed-on: https://chromium-review.googlesource.com/1142449
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576859}
[modify] https://crrev.com/189efd75161c086a7769187a6912e2eedf157df2/components/viz/service/main/viz_main_impl.cc
[modify] https://crrev.com/189efd75161c086a7769187a6912e2eedf157df2/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/189efd75161c086a7769187a6912e2eedf157df2/gpu/ipc/service/gpu_init.cc
[modify] https://crrev.com/189efd75161c086a7769187a6912e2eedf157df2/services/ui/service.cc
[modify] https://crrev.com/189efd75161c086a7769187a6912e2eedf157df2/ui/aura/env.cc
[modify] https://crrev.com/189efd75161c086a7769187a6912e2eedf157df2/ui/base/ui_base_features.cc
[modify] https://crrev.com/189efd75161c086a7769187a6912e2eedf157df2/ui/base/ui_base_features.h
[modify] https://crrev.com/189efd75161c086a7769187a6912e2eedf157df2/ui/ozone/public/ozone_switches.cc
[modify] https://crrev.com/189efd75161c086a7769187a6912e2eedf157df2/ui/ozone/public/ozone_switches.h

Project Member

Comment 52 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a954d47c58a69eb5ca3388073cdd0e6fb20d8c67

commit a954d47c58a69eb5ca3388073cdd0e6fb20d8c67
Author: Robert Kroeger <rjkroege@chromium.org>
Date: Fri Jul 27 23:33:45 2018

[ozone/drm/mojo] Remove a mash only DCHECK

Ozone/drm/mojo contained a DCHECK only appropriate for legacy mash mode.
This mode has been removed so remove the DCHECK as well.

BUG=620927
TEST=by hand

Change-Id: Ieb8c6b21ed79de2202ee06eedf47029d32183421
Reviewed-on: https://chromium-review.googlesource.com/1153968
Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578859}
[modify] https://crrev.com/a954d47c58a69eb5ca3388073cdd0e6fb20d8c67/ui/ozone/platform/drm/host/drm_device_connector.cc

Labels: -Proj-Mustash Proj-Mash-MultiProcess
fyi: feature is on in finch now.
Labels: -Proj-Mustash-Mus-GPU
Cleaning up old Proj-Mustash labels.

Sign in to add a comment