New issue
Advanced search Search tips

Issue 620911 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

bootstrap page is broken

Project Member Reported by no...@chromium.org, Jun 16 2016

Issue description

if I switch to bootstrap theme the build https://luci-milo.appspot.com/swarming/prod/2f745106e6a9e610 cannot download css.

I wonder if we should hide that setting (settings page) for now. I'd prefer shipping working milo with one theme and after we feedback, address it, after we are confident that users like milo functionality, implement another theme with all the functionality included.
 

Comment 1 by hinoka@chromium.org, Jun 16 2016

Well thats not supposed to happen, i think one of the symlinks is broken.

But you have a point, the bootstrap theme is a bit neglected.

Comment 2 by hinoka@chromium.org, Jun 16 2016

I think this was the breaking CL: https://codereview.chromium.org/1960443004

It passed all tests

I think we need tests to catch when static assets are moved? Maybe like an integration test.

Comment 3 by no...@chromium.org, Jun 23 2016

Recently we added a bot link in build view, it points to a swarming bot page which shows tasks the bot executed. However it obviously doesn't have links back to Milo which means a user cannot just navigate from a bot page to Milo build pages. For that a Milo page that displays bot info and links to Milo builds would be nice.

Implementing that in two themes is twice more work. I think users won't care about bootstrap theme at this point, so i purpose to hide theme selector and bootstrap theme features for now. Wdyt?

Comment 4 by no...@chromium.org, Jun 23 2016

Labels: Type-Bug
The "twice more work" applies to any new Milo page including builder view
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/5a4faaa2472d1220c5dcdcd8c29b6dbe2ca738e2

commit 5a4faaa2472d1220c5dcdcd8c29b6dbe2ca738e2
Author: hinoka <hinoka@google.com>
Date: Thu Jun 23 18:10:47 2016

Milo: Remove settings link

Currently the bootstrap theme is unloved, hide the UI element until we fix it.

BUG= 620911 

Review-Url: https://codereview.chromium.org/2096773002

[modify] https://crrev.com/5a4faaa2472d1220c5dcdcd8c29b6dbe2ca738e2/appengine/cmd/milo/frontend/expectations/buildbot-buildbot.TestableBuild-Debug_page-_CrWinGoma_30608.html
[modify] https://crrev.com/5a4faaa2472d1220c5dcdcd8c29b6dbe2ca738e2/appengine/cmd/milo/frontend/expectations/buildbot-buildbot.TestableBuilder-Basic_Test_no_builds.html
[modify] https://crrev.com/5a4faaa2472d1220c5dcdcd8c29b6dbe2ca738e2/appengine/cmd/milo/frontend/expectations/buildbot-buildbot.TestableBuilder-Basic_Test_with_builds.html
[modify] https://crrev.com/5a4faaa2472d1220c5dcdcd8c29b6dbe2ca738e2/appengine/cmd/milo/frontend/expectations/buildbot-frontend.testableFrontpage-Basic_frontpage.html
[modify] https://crrev.com/5a4faaa2472d1220c5dcdcd8c29b6dbe2ca738e2/appengine/cmd/milo/frontend/expectations/buildbot-settings.TestableSettings-Settings.html
[modify] https://crrev.com/5a4faaa2472d1220c5dcdcd8c29b6dbe2ca738e2/appengine/cmd/milo/frontend/expectations/buildbot-swarming.TestableBuild-Basic_successful_build.html
[modify] https://crrev.com/5a4faaa2472d1220c5dcdcd8c29b6dbe2ca738e2/appengine/cmd/milo/frontend/expectations/buildbot-swarming.TestableLog-Basic_log.html
[modify] https://crrev.com/5a4faaa2472d1220c5dcdcd8c29b6dbe2ca738e2/appengine/cmd/milo/frontend/templates/buildbot/includes/buildbot.html

Comment 6 by no...@chromium.org, Jun 23 2016

Labels: -Pri-1 Pri-3
Now it is not time critical

Comment 7 by no...@chromium.org, Jun 23 2016

Status: Available (was: Untriaged)

Comment 8 by hinoka@chromium.org, Jun 27 2016

Labels: luci-milo W-0704
Project Member

Comment 9 by sheriffbot@chromium.org, Jul 4 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: W0711
Labels: -W-0704 -W0711 W-0711
Labels: -W-0711 W-0718
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/b98cf83f2b7e526dfd65c97037f06e5348b1ac2b

commit b98cf83f2b7e526dfd65c97037f06e5348b1ac2b
Author: hinoka <hinoka@google.com>
Date: Fri Jul 15 20:55:11 2016

Fix the milo-bootstrap theme css

Someone moved the bootstrap files again which caused the bootstrap theme to break.
Checking two css files and one js file directly into the milo repository to
avoid this.

BUG= 620911 

Review-Url: https://codereview.chromium.org/2095773002

[modify] https://crrev.com/b98cf83f2b7e526dfd65c97037f06e5348b1ac2b/appengine/cmd/milo/frontend/expectations/bootstrap-buildbot.TestableBuild-Debug_page-_CrWinGoma_30608.html
[modify] https://crrev.com/b98cf83f2b7e526dfd65c97037f06e5348b1ac2b/appengine/cmd/milo/frontend/expectations/bootstrap-buildbot.TestableBuild-Debug_page-_win_chromium_rel_ng_246309.html
[modify] https://crrev.com/b98cf83f2b7e526dfd65c97037f06e5348b1ac2b/appengine/cmd/milo/frontend/expectations/bootstrap-buildbot.TestableBuilder-Basic_Test_no_builds.html
[modify] https://crrev.com/b98cf83f2b7e526dfd65c97037f06e5348b1ac2b/appengine/cmd/milo/frontend/expectations/bootstrap-buildbot.TestableBuilder-Basic_Test_with_builds.html
[modify] https://crrev.com/b98cf83f2b7e526dfd65c97037f06e5348b1ac2b/appengine/cmd/milo/frontend/expectations/bootstrap-frontend.testableFrontpage-Basic_frontpage.html
[modify] https://crrev.com/b98cf83f2b7e526dfd65c97037f06e5348b1ac2b/appengine/cmd/milo/frontend/expectations/bootstrap-settings.TestableSettings-Settings.html
[modify] https://crrev.com/b98cf83f2b7e526dfd65c97037f06e5348b1ac2b/appengine/cmd/milo/frontend/expectations/bootstrap-swarming.TestableBuild-Basic_successful_build.html
[modify] https://crrev.com/b98cf83f2b7e526dfd65c97037f06e5348b1ac2b/appengine/cmd/milo/frontend/expectations/bootstrap-swarming.TestableLog-Basic_log.html
[add] https://crrev.com/b98cf83f2b7e526dfd65c97037f06e5348b1ac2b/appengine/cmd/milo/frontend/static/bootstrap/third_party/css/bootstrap-theme.min.css
[add] https://crrev.com/b98cf83f2b7e526dfd65c97037f06e5348b1ac2b/appengine/cmd/milo/frontend/static/bootstrap/third_party/css/bootstrap.min.css
[add] https://crrev.com/b98cf83f2b7e526dfd65c97037f06e5348b1ac2b/appengine/cmd/milo/frontend/static/bootstrap/third_party/js/bootstrap.min.js
[add] https://crrev.com/b98cf83f2b7e526dfd65c97037f06e5348b1ac2b/appengine/cmd/milo/frontend/static/common/third_party/js/jquery.min.js
[modify] https://crrev.com/b98cf83f2b7e526dfd65c97037f06e5348b1ac2b/appengine/cmd/milo/frontend/templates/bootstrap/includes/bootstrap.html

Owner: hinoka@chromium.org
Status: Assigned (was: Available)
Labels: -W-0718 W-0801
Labels: -W-0801 W-0815
Labels: -M-54 -luci -luci-milo -MovedFrom-53 -W-0815 S-Medium
Status: WontFix (was: Assigned)
We can revisit this in the future. It will be some time until we're ready for this.

Sign in to add a comment