New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 620910 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[search] spinner while loading search results is oddly positioned

Project Member Reported by dbeam@chromium.org, Jun 16 2016

Issue description

bugs: repro steps (I did X and expected Y but Z happened!)

1. search for stuff

what do you expect?
an intuitively positioned progress indicator

what do you see instead?
a spinner on top of the search magnifying glass
 

Comment 1 by dbeam@chromium.org, Jun 16 2016

this effectively resulted in stuff like this for ~150ms
2016-06-16-162649_129x46_scrot.png
1.9 KB View Download
Hey dbeam@ -- are you still looking to change this? Neither Chris or I can really see the problem you're talking about. If you could record a video of what you're seeing that would help us out. 

Comment 3 by dbeam@chromium.org, Jun 29 2016

we figured out what was going on here: this affects really fast local searches
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcb81706c2577bcee91c9056be3d26cae373830f

commit bcb81706c2577bcee91c9056be3d26cae373830f
Author: dbeam <dbeam@chromium.org>
Date: Wed Jun 29 20:18:01 2016

MD History: show and hide search spinner and icon the same way

R=tsergeant@chromium.org
BUG= 620910 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2075013002
Cr-Commit-Position: refs/heads/master@{#402922}

[modify] https://crrev.com/bcb81706c2577bcee91c9056be3d26cae373830f/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

Comment 5 by dbeam@chromium.org, Jun 29 2016

Status: Fixed (was: Started)
Labels: Needs-Feedback
dbeam@, can you please provide the exact repro steps to verify the fix?

Thank you!

Comment 7 by dbeam@chromium.org, Jul 7 2016

0. sign out of chrome
1. visit chrome://history
2. search within your history

expected: good looking spinner notifications while searching (note: you may not see a spinner at all if your results are fast)

Sign in to add a comment