Borderline transform in unit test DamageTrackerTest.VerifyDamageForPerspectiveClippedLayer |
||
Issue descriptionThe net transformation in DamageTrackerTest.VerifyDamageForPerspectiveClippedLayer causes a surface that intersects the window on an angle from 498 to something somewhat lower in the X direction, but tests for an intersection with the clipping rect of 500x500. This works since the surface outside of the root extends to x=500, but outside of y<500. If we ever improve the clipping rect calculation to be more conservative this test could needlessly fail. See attached html file for a visual.
,
Jun 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fba53156de8910caa6e6a76bef02e2bad33be1ad commit fba53156de8910caa6e6a76bef02e2bad33be1ad Author: petermayo <petermayo@chromium.org> Date: Fri Jun 17 21:37:02 2016 Improve DamageTrackerTest.VerifyDamageForPerspectiveClippedLayer The transform hits the expected dimension outside of the basic visual rect, so if we were more accurate in triming the limits we would get this test wrong in the future. R=vollick@chromium.org BUG= 620909 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2075933002 Cr-Commit-Position: refs/heads/master@{#400510} [modify] https://crrev.com/fba53156de8910caa6e6a76bef02e2bad33be1ad/cc/trees/damage_tracker_unittest.cc
,
Jun 17 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by petermayo@chromium.org
, Jun 16 2016